You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Vijay (Created) (JIRA)" <ji...@apache.org> on 2011/11/12 19:58:51 UTC
[jira] [Created] (CASSANDRA-3486) Node Tool command to stop repair
Node Tool command to stop repair
--------------------------------
Key: CASSANDRA-3486
URL: https://issues.apache.org/jira/browse/CASSANDRA-3486
Project: Cassandra
Issue Type: Improvement
Components: Tools
Affects Versions: 1.0.4
Environment: JVM
Reporter: Vijay
Assignee: Vijay
Priority: Minor
Fix For: 1.0.4
After CASSANDRA-1740, If the validation compaction is stopped then the repair will hang. This ticket will allow users to kill the original repair.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-3486) Node Tool command to stop
repair
Posted by "Radim Kolar (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-3486?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13175110#comment-13175110 ]
Radim Kolar commented on CASSANDRA-3486:
----------------------------------------
It will be useful. sometimes validation eats too much disk bandwidth making compaction too slow
> Node Tool command to stop repair
> --------------------------------
>
> Key: CASSANDRA-3486
> URL: https://issues.apache.org/jira/browse/CASSANDRA-3486
> Project: Cassandra
> Issue Type: Improvement
> Components: Tools
> Affects Versions: 1.1
> Environment: JVM
> Reporter: Vijay
> Assignee: Vijay
> Priority: Minor
> Labels: nodetool, repair, stop
>
> After CASSANDRA-1740, If the validation compaction is stopped then the repair will hang. This ticket will allow users to kill the original repair.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CASSANDRA-3486) Node Tool command to stop repair
Posted by "Sylvain Lebresne (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-3486?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sylvain Lebresne updated CASSANDRA-3486:
----------------------------------------
Affects Version/s: (was: 1.0.4)
1.1
Fix Version/s: (was: 1.0.4)
Moving to 1.1 because this will almost certainly require a wire protocol change. Also, CASSANDRA-3112 requires a very similar change (basically validation needs to be able to report an error back to the repair), so it's worth making room for both of those changes together.
> Node Tool command to stop repair
> --------------------------------
>
> Key: CASSANDRA-3486
> URL: https://issues.apache.org/jira/browse/CASSANDRA-3486
> Project: Cassandra
> Issue Type: Improvement
> Components: Tools
> Affects Versions: 1.1
> Environment: JVM
> Reporter: Vijay
> Assignee: Vijay
> Priority: Minor
> Labels: nodetool, repair, stop
>
> After CASSANDRA-1740, If the validation compaction is stopped then the repair will hang. This ticket will allow users to kill the original repair.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-3486) Node Tool command to stop
repair
Posted by "Vijay (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-3486?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13178528#comment-13178528 ]
Vijay commented on CASSANDRA-3486:
----------------------------------
Sounds good to me, Let me know if you want me to clear the streaming sessions which where associated with the repair while running (SS.forceTerminateAllRepairSessions) i can do that (as a part of this ticket or a separate one)...
if the current state is good enough, i can close this ticket as it is already exposed for the advanced users (I think the streaming sessions are mostly harmless for most of the users).
> Node Tool command to stop repair
> --------------------------------
>
> Key: CASSANDRA-3486
> URL: https://issues.apache.org/jira/browse/CASSANDRA-3486
> Project: Cassandra
> Issue Type: Improvement
> Components: Tools
> Environment: JVM
> Reporter: Vijay
> Assignee: Vijay
> Priority: Minor
> Labels: nodetool, repair, stop
> Fix For: 1.1
>
> Attachments: 0001-stop-repair-3583.patch
>
>
> After CASSANDRA-1740, If the validation compaction is stopped then the repair will hang. This ticket will allow users to kill the original repair.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-3486) Node Tool command to stop
repair
Posted by "Sylvain Lebresne (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-3486?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13178504#comment-13178504 ]
Sylvain Lebresne commented on CASSANDRA-3486:
---------------------------------------------
As a said back on CASSANDRA-3316, I see forceTerminateAllRepairSessions more as a band-aid solution to avoid having someone stuck until we better handle repair failures and have a correct to stop it. But it isn't really a very use friendly solution since it doesn't stop properly the repair (it won't stop the validation compaction (though we can do that by other means now), nor any streaming that would be running) and you have to run it everywhere. For all those reason, my opinion is that we should keep this JMX only, I see no good reason to promote it to nodetool. That's just an opinion though.
> Node Tool command to stop repair
> --------------------------------
>
> Key: CASSANDRA-3486
> URL: https://issues.apache.org/jira/browse/CASSANDRA-3486
> Project: Cassandra
> Issue Type: Improvement
> Components: Tools
> Environment: JVM
> Reporter: Vijay
> Assignee: Vijay
> Priority: Minor
> Labels: nodetool, repair, stop
> Fix For: 1.1
>
> Attachments: 0001-stop-repair-3583.patch
>
>
> After CASSANDRA-1740, If the validation compaction is stopped then the repair will hang. This ticket will allow users to kill the original repair.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CASSANDRA-3486) Node Tool command to stop repair
Posted by "Jonathan Ellis (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-3486?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Ellis updated CASSANDRA-3486:
--------------------------------------
Reviewer: slebresne
Affects Version/s: (was: 1.1)
Fix Version/s: 1.1
> Node Tool command to stop repair
> --------------------------------
>
> Key: CASSANDRA-3486
> URL: https://issues.apache.org/jira/browse/CASSANDRA-3486
> Project: Cassandra
> Issue Type: Improvement
> Components: Tools
> Environment: JVM
> Reporter: Vijay
> Assignee: Vijay
> Priority: Minor
> Labels: nodetool, repair, stop
> Fix For: 1.1
>
> Attachments: 0001-stop-repair-3583.patch
>
>
> After CASSANDRA-1740, If the validation compaction is stopped then the repair will hang. This ticket will allow users to kill the original repair.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-3486) Node Tool command to stop
repair
Posted by "Sylvain Lebresne (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-3486?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13178705#comment-13178705 ]
Sylvain Lebresne commented on CASSANDRA-3486:
---------------------------------------------
I don't think we should close that ticket because I don't think that we have a satisfying way to stop repair. A satisfying way to run repair would be to be able to run 'nodetool repair stop <some_repair_session_id>' on the host the repair was started on, on have it cleaning stop everything related to that repair (including any validation or streaming going on) and this on every participating nodes. That require a bit more work however and let me note that I don't see this ticket as a priority at all.
> Node Tool command to stop repair
> --------------------------------
>
> Key: CASSANDRA-3486
> URL: https://issues.apache.org/jira/browse/CASSANDRA-3486
> Project: Cassandra
> Issue Type: Improvement
> Components: Tools
> Environment: JVM
> Reporter: Vijay
> Assignee: Vijay
> Priority: Minor
> Labels: nodetool, repair, stop
> Fix For: 1.1
>
> Attachments: 0001-stop-repair-3583.patch
>
>
> After CASSANDRA-1740, If the validation compaction is stopped then the repair will hang. This ticket will allow users to kill the original repair.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CASSANDRA-3486) Node Tool command to stop repair
Posted by "Vijay (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-3486?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Vijay updated CASSANDRA-3486:
-----------------------------
Attachment: 0001-stop-repair-3583.patch
Attached is a simple patch to expose SS.forceTerminateAllRepairSessions in NodeTool
#nt stop repairsessions
will stop the repair sessions in the repair originating node (cleanup).
NOTE: User might need to do "#nt stop Validation" in all the nodes which are involved in the repair.
> Node Tool command to stop repair
> --------------------------------
>
> Key: CASSANDRA-3486
> URL: https://issues.apache.org/jira/browse/CASSANDRA-3486
> Project: Cassandra
> Issue Type: Improvement
> Components: Tools
> Affects Versions: 1.1
> Environment: JVM
> Reporter: Vijay
> Assignee: Vijay
> Priority: Minor
> Labels: nodetool, repair, stop
> Attachments: 0001-stop-repair-3583.patch
>
>
> After CASSANDRA-1740, If the validation compaction is stopped then the repair will hang. This ticket will allow users to kill the original repair.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira