Re: svn commit: rev 1339 - trunk/subversion/clients/cmdline

[Greg Stein <gs...@lyra.org>]

On Wed, Feb 20, 2002 at 04:53:19PM -0600, daniel@tigris.org wrote:
>...
> +#define SVN_ERROR_START \
> +	static const err_defn error_table[] = { \
> +	  { SVN_ERR_CDMLINE__WARNING, "Warning" },

We're going to need to have a way to define and use this error table
somehow. Otherwise, all we have are symbolic constants and no strings.

>...
> +static svn_boolean_t
> +print_single_file_status (apr_file_t *file,
> +                          const char *path,
> +                          const char *editor_prefix,
> +                          svn_wc_status_t *status)
> +{

I like the changes here which spool everything into a file rather than an
in-memory buffer. That buffer could get out of hand when you copy or modify
a huge tree :-)

>...
> +/*
> + * Invoke $EDITOR to get a commit message.
> + */
>  static svn_error_t *
> -store_message (svn_stringbuf_t *message,
> -               svn_stringbuf_t *path,
> -               apr_pool_t *pool)
> +message_from_editor (apr_pool_t *pool,
> +                     apr_array_header_t *targets,
> +                     svn_client_auth_baton_t *auth_baton,
> +                     svn_stringbuf_t *path,
> +                     svn_cl__opt_state_t *opt_state,
> +                     svn_stringbuf_t **messagep,
> +                     const char *editor_prefix,
> +                     const char *default_msg, /* text to include in editor */
> +                     svn_boolean_t include_status_output)
>  {

These changes in here stomped over Mike's commit to extract the invocation
of the editor.

I'm not sure that reviewing it makes sense right now, as the use of
svn_cl__edit_externally() needs to be dealt with first:

> -      /* Now, edit the message. */
> -      SVN_ERR (svn_cl__edit_externally (&editor_message,
> -                                        base_dir,
> -                                        &contents,
> -                                        pool));


Cheers,
-g

-- 
Greg Stein, http://www.lyra.org/

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org