You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "lidavidm (via GitHub)" <gi...@apache.org> on 2023/01/24 22:04:02 UTC

[GitHub] [arrow-adbc] lidavidm opened a new pull request, #383: feat(go/adbc/driver/flightsql): implement GetObjects

lidavidm opened a new pull request, #383:
URL: https://github.com/apache/arrow-adbc/pull/383

   Punts in implementing column constraint (primary key/foreign key/unique constraint) info.
   
   Part of #380.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow-adbc] zeroshade commented on a diff in pull request #383: feat(go/adbc/driver/flightsql): implement GetObjects

Posted by "zeroshade (via GitHub)" <gi...@apache.org>.
zeroshade commented on code in PR #383:
URL: https://github.com/apache/arrow-adbc/pull/383#discussion_r1085996367


##########
go/adbc/driver/flightsql/flightsql_adbc.go:
##########
@@ -532,10 +536,339 @@ func (c *cnxn) GetInfo(ctx context.Context, infoCodes []adbc.InfoCode) (array.Re
 // All non-empty, non-nil strings should be a search pattern (as described
 // earlier).
 func (c *cnxn) GetObjects(ctx context.Context, depth adbc.ObjectDepth, catalog *string, dbSchema *string, tableName *string, columnName *string, tableType []string) (array.RecordReader, error) {
-	return nil, adbc.Error{
-		Msg:  "Not implemented: GetObjects",
-		Code: adbc.StatusNotImplemented,
+	builder := array.NewRecordBuilder(c.db.alloc, adbc.GetObjectsSchema)
+	defer builder.Release()
+
+	// To avoid an N+1 query problem, we assume result sets here will fit in memory and build up a single response.
+	info, err := c.cl.GetCatalogs(ctx)
+	if err != nil {
+		return nil, adbcFromFlightStatus(err)
+	}
+
+	rdr, err := c.readInfo(ctx, schema_ref.Catalogs, info)
+	if err != nil {
+		return nil, adbcFromFlightStatus(err)
+	}
+	defer rdr.Release()
+
+	catalogToDbSchemas, err := c.getObjectsDbSchemas(ctx, depth, catalog, dbSchema)
+	if err != nil {
+		return nil, err
+	}
+
+	tableLookup, err := c.getObjectsTables(ctx, depth, catalog, dbSchema, tableName, columnName, tableType)
+	if err != nil {
+		return nil, err
+	}
+
+	catalogNameBuilder := builder.Field(0).(*array.StringBuilder)
+	catalogDbSchemasBuilder := builder.Field(1).(*array.ListBuilder)
+	catalogDbSchemasItems := catalogDbSchemasBuilder.ValueBuilder().(*array.StructBuilder)
+	dbSchemaNameBuilder := catalogDbSchemasItems.FieldBuilder(0).(*array.StringBuilder)
+	dbSchemaTablesBuilder := catalogDbSchemasItems.FieldBuilder(1).(*array.ListBuilder)
+	dbSchemaTablesItems := dbSchemaTablesBuilder.ValueBuilder().(*array.StructBuilder)
+	tableNameBuilder := dbSchemaTablesItems.FieldBuilder(0).(*array.StringBuilder)
+	tableTypeBuilder := dbSchemaTablesItems.FieldBuilder(1).(*array.StringBuilder)
+	tableColumnsBuilder := dbSchemaTablesItems.FieldBuilder(2).(*array.ListBuilder)
+	tableColumnsItems := tableColumnsBuilder.ValueBuilder().(*array.StructBuilder)
+	columnNameBuilder := tableColumnsItems.FieldBuilder(0).(*array.StringBuilder)
+	ordinalPositionBuilder := tableColumnsItems.FieldBuilder(1).(*array.Int32Builder)
+	remarksBuilder := tableColumnsItems.FieldBuilder(2).(*array.StringBuilder)
+	xdbcDataTypeBuilder := tableColumnsItems.FieldBuilder(3).(*array.Int16Builder)
+	xdbcTypeNameBuilder := tableColumnsItems.FieldBuilder(4).(*array.StringBuilder)
+	xdbcColumnSizeBuilder := tableColumnsItems.FieldBuilder(5).(*array.Int32Builder)
+	xdbcDecimalDigitsBuilder := tableColumnsItems.FieldBuilder(6).(*array.Int16Builder)
+	xdbcNumPrecRadixBuilder := tableColumnsItems.FieldBuilder(7).(*array.Int16Builder)
+	xdbcNullableBuilder := tableColumnsItems.FieldBuilder(8).(*array.Int16Builder)
+	xdbcColumnDefBuilder := tableColumnsItems.FieldBuilder(9).(*array.StringBuilder)
+	xdbcSqlDataTypeBuilder := tableColumnsItems.FieldBuilder(10).(*array.Int16Builder)
+	xdbcDatetimeSubBuilder := tableColumnsItems.FieldBuilder(11).(*array.Int16Builder)
+	xdbcCharOctetLengthBuilder := tableColumnsItems.FieldBuilder(12).(*array.Int32Builder)
+	xdbcIsNullableBuilder := tableColumnsItems.FieldBuilder(13).(*array.StringBuilder)
+	xdbcScopeCatalogBuilder := tableColumnsItems.FieldBuilder(14).(*array.StringBuilder)
+	xdbcScopeSchemaBuilder := tableColumnsItems.FieldBuilder(15).(*array.StringBuilder)
+	xdbcScopeTableBuilder := tableColumnsItems.FieldBuilder(16).(*array.StringBuilder)
+	xdbcIsAutoincrementBuilder := tableColumnsItems.FieldBuilder(17).(*array.BooleanBuilder)
+	xdbcIsGeneratedcolumnBuilder := tableColumnsItems.FieldBuilder(18).(*array.BooleanBuilder)
+	tableConstraintsBuilder := dbSchemaTablesItems.FieldBuilder(3).(*array.ListBuilder)
+
+	catalogPattern, err := patternToRegexp(catalog)
+	if err != nil {
+		return nil, adbc.Error{
+			Msg:  err.Error(),
+			Code: adbc.StatusInvalidArgument,
+		}
+	}
+	columnNamePattern, err := patternToRegexp(columnName)
+	if err != nil {
+		return nil, adbc.Error{
+			Msg:  err.Error(),
+			Code: adbc.StatusInvalidArgument,
+		}
+	}
+
+	for rdr.Next() {
+		arr := rdr.Record().Column(0).(*array.String)
+		for i := 0; i < arr.Len(); i++ {
+			catalogName := arr.Value(i)
+			if catalogPattern != nil && !catalogPattern.MatchString(catalogName) {
+				continue
+			}
+			catalogNameBuilder.Append(catalogName)

Review Comment:
   *sigh* I guess I should implement a regex_match kernel? haha



##########
go/adbc/driver/flightsql/flightsql_adbc.go:
##########
@@ -532,10 +536,339 @@ func (c *cnxn) GetInfo(ctx context.Context, infoCodes []adbc.InfoCode) (array.Re
 // All non-empty, non-nil strings should be a search pattern (as described
 // earlier).
 func (c *cnxn) GetObjects(ctx context.Context, depth adbc.ObjectDepth, catalog *string, dbSchema *string, tableName *string, columnName *string, tableType []string) (array.RecordReader, error) {
-	return nil, adbc.Error{
-		Msg:  "Not implemented: GetObjects",
-		Code: adbc.StatusNotImplemented,
+	builder := array.NewRecordBuilder(c.db.alloc, adbc.GetObjectsSchema)
+	defer builder.Release()
+
+	// To avoid an N+1 query problem, we assume result sets here will fit in memory and build up a single response.
+	info, err := c.cl.GetCatalogs(ctx)
+	if err != nil {
+		return nil, adbcFromFlightStatus(err)
+	}
+
+	rdr, err := c.readInfo(ctx, schema_ref.Catalogs, info)
+	if err != nil {
+		return nil, adbcFromFlightStatus(err)
+	}
+	defer rdr.Release()
+
+	catalogToDbSchemas, err := c.getObjectsDbSchemas(ctx, depth, catalog, dbSchema)
+	if err != nil {
+		return nil, err
+	}
+
+	tableLookup, err := c.getObjectsTables(ctx, depth, catalog, dbSchema, tableName, columnName, tableType)
+	if err != nil {
+		return nil, err
+	}
+
+	catalogNameBuilder := builder.Field(0).(*array.StringBuilder)
+	catalogDbSchemasBuilder := builder.Field(1).(*array.ListBuilder)
+	catalogDbSchemasItems := catalogDbSchemasBuilder.ValueBuilder().(*array.StructBuilder)
+	dbSchemaNameBuilder := catalogDbSchemasItems.FieldBuilder(0).(*array.StringBuilder)
+	dbSchemaTablesBuilder := catalogDbSchemasItems.FieldBuilder(1).(*array.ListBuilder)
+	dbSchemaTablesItems := dbSchemaTablesBuilder.ValueBuilder().(*array.StructBuilder)
+	tableNameBuilder := dbSchemaTablesItems.FieldBuilder(0).(*array.StringBuilder)
+	tableTypeBuilder := dbSchemaTablesItems.FieldBuilder(1).(*array.StringBuilder)
+	tableColumnsBuilder := dbSchemaTablesItems.FieldBuilder(2).(*array.ListBuilder)
+	tableColumnsItems := tableColumnsBuilder.ValueBuilder().(*array.StructBuilder)
+	columnNameBuilder := tableColumnsItems.FieldBuilder(0).(*array.StringBuilder)
+	ordinalPositionBuilder := tableColumnsItems.FieldBuilder(1).(*array.Int32Builder)
+	remarksBuilder := tableColumnsItems.FieldBuilder(2).(*array.StringBuilder)
+	xdbcDataTypeBuilder := tableColumnsItems.FieldBuilder(3).(*array.Int16Builder)
+	xdbcTypeNameBuilder := tableColumnsItems.FieldBuilder(4).(*array.StringBuilder)
+	xdbcColumnSizeBuilder := tableColumnsItems.FieldBuilder(5).(*array.Int32Builder)
+	xdbcDecimalDigitsBuilder := tableColumnsItems.FieldBuilder(6).(*array.Int16Builder)
+	xdbcNumPrecRadixBuilder := tableColumnsItems.FieldBuilder(7).(*array.Int16Builder)
+	xdbcNullableBuilder := tableColumnsItems.FieldBuilder(8).(*array.Int16Builder)
+	xdbcColumnDefBuilder := tableColumnsItems.FieldBuilder(9).(*array.StringBuilder)
+	xdbcSqlDataTypeBuilder := tableColumnsItems.FieldBuilder(10).(*array.Int16Builder)
+	xdbcDatetimeSubBuilder := tableColumnsItems.FieldBuilder(11).(*array.Int16Builder)
+	xdbcCharOctetLengthBuilder := tableColumnsItems.FieldBuilder(12).(*array.Int32Builder)
+	xdbcIsNullableBuilder := tableColumnsItems.FieldBuilder(13).(*array.StringBuilder)
+	xdbcScopeCatalogBuilder := tableColumnsItems.FieldBuilder(14).(*array.StringBuilder)
+	xdbcScopeSchemaBuilder := tableColumnsItems.FieldBuilder(15).(*array.StringBuilder)
+	xdbcScopeTableBuilder := tableColumnsItems.FieldBuilder(16).(*array.StringBuilder)
+	xdbcIsAutoincrementBuilder := tableColumnsItems.FieldBuilder(17).(*array.BooleanBuilder)
+	xdbcIsGeneratedcolumnBuilder := tableColumnsItems.FieldBuilder(18).(*array.BooleanBuilder)
+	tableConstraintsBuilder := dbSchemaTablesItems.FieldBuilder(3).(*array.ListBuilder)
+
+	catalogPattern, err := patternToRegexp(catalog)
+	if err != nil {
+		return nil, adbc.Error{
+			Msg:  err.Error(),
+			Code: adbc.StatusInvalidArgument,
+		}
+	}
+	columnNamePattern, err := patternToRegexp(columnName)
+	if err != nil {
+		return nil, adbc.Error{
+			Msg:  err.Error(),
+			Code: adbc.StatusInvalidArgument,
+		}
+	}
+
+	for rdr.Next() {
+		arr := rdr.Record().Column(0).(*array.String)
+		for i := 0; i < arr.Len(); i++ {
+			catalogName := arr.Value(i)
+			if catalogPattern != nil && !catalogPattern.MatchString(catalogName) {
+				continue
+			}
+			catalogNameBuilder.Append(catalogName)
+
+			if depth != adbc.ObjectDepthCatalogs {

Review Comment:
   Can we reduce the levels of indentation by having this be 
   ```go
   if depth == adbc.ObjectDepthCatalogs {
       // do a thing
       continue
   }
   ```
   
   same for the other situations. make the code more readable by doing early `continue`s to reduce the level of indentation.



##########
go/adbc/driver/flightsql/flightsql_adbc.go:
##########
@@ -532,10 +536,339 @@ func (c *cnxn) GetInfo(ctx context.Context, infoCodes []adbc.InfoCode) (array.Re
 // All non-empty, non-nil strings should be a search pattern (as described
 // earlier).
 func (c *cnxn) GetObjects(ctx context.Context, depth adbc.ObjectDepth, catalog *string, dbSchema *string, tableName *string, columnName *string, tableType []string) (array.RecordReader, error) {
-	return nil, adbc.Error{
-		Msg:  "Not implemented: GetObjects",
-		Code: adbc.StatusNotImplemented,
+	builder := array.NewRecordBuilder(c.db.alloc, adbc.GetObjectsSchema)
+	defer builder.Release()
+
+	// To avoid an N+1 query problem, we assume result sets here will fit in memory and build up a single response.
+	info, err := c.cl.GetCatalogs(ctx)
+	if err != nil {
+		return nil, adbcFromFlightStatus(err)
+	}
+
+	rdr, err := c.readInfo(ctx, schema_ref.Catalogs, info)

Review Comment:
   we're guaranteed that there'll only ever be one endpoint for this?



##########
go/adbc/driver/flightsql/flightsql_adbc.go:
##########
@@ -532,10 +536,339 @@ func (c *cnxn) GetInfo(ctx context.Context, infoCodes []adbc.InfoCode) (array.Re
 // All non-empty, non-nil strings should be a search pattern (as described
 // earlier).
 func (c *cnxn) GetObjects(ctx context.Context, depth adbc.ObjectDepth, catalog *string, dbSchema *string, tableName *string, columnName *string, tableType []string) (array.RecordReader, error) {
-	return nil, adbc.Error{
-		Msg:  "Not implemented: GetObjects",
-		Code: adbc.StatusNotImplemented,
+	builder := array.NewRecordBuilder(c.db.alloc, adbc.GetObjectsSchema)
+	defer builder.Release()
+
+	// To avoid an N+1 query problem, we assume result sets here will fit in memory and build up a single response.
+	info, err := c.cl.GetCatalogs(ctx)
+	if err != nil {
+		return nil, adbcFromFlightStatus(err)
+	}
+
+	rdr, err := c.readInfo(ctx, schema_ref.Catalogs, info)
+	if err != nil {
+		return nil, adbcFromFlightStatus(err)
+	}
+	defer rdr.Release()
+
+	catalogToDbSchemas, err := c.getObjectsDbSchemas(ctx, depth, catalog, dbSchema)
+	if err != nil {
+		return nil, err
+	}
+
+	tableLookup, err := c.getObjectsTables(ctx, depth, catalog, dbSchema, tableName, columnName, tableType)
+	if err != nil {
+		return nil, err
+	}
+
+	catalogNameBuilder := builder.Field(0).(*array.StringBuilder)
+	catalogDbSchemasBuilder := builder.Field(1).(*array.ListBuilder)
+	catalogDbSchemasItems := catalogDbSchemasBuilder.ValueBuilder().(*array.StructBuilder)
+	dbSchemaNameBuilder := catalogDbSchemasItems.FieldBuilder(0).(*array.StringBuilder)
+	dbSchemaTablesBuilder := catalogDbSchemasItems.FieldBuilder(1).(*array.ListBuilder)
+	dbSchemaTablesItems := dbSchemaTablesBuilder.ValueBuilder().(*array.StructBuilder)
+	tableNameBuilder := dbSchemaTablesItems.FieldBuilder(0).(*array.StringBuilder)
+	tableTypeBuilder := dbSchemaTablesItems.FieldBuilder(1).(*array.StringBuilder)
+	tableColumnsBuilder := dbSchemaTablesItems.FieldBuilder(2).(*array.ListBuilder)
+	tableColumnsItems := tableColumnsBuilder.ValueBuilder().(*array.StructBuilder)
+	columnNameBuilder := tableColumnsItems.FieldBuilder(0).(*array.StringBuilder)
+	ordinalPositionBuilder := tableColumnsItems.FieldBuilder(1).(*array.Int32Builder)
+	remarksBuilder := tableColumnsItems.FieldBuilder(2).(*array.StringBuilder)
+	xdbcDataTypeBuilder := tableColumnsItems.FieldBuilder(3).(*array.Int16Builder)
+	xdbcTypeNameBuilder := tableColumnsItems.FieldBuilder(4).(*array.StringBuilder)
+	xdbcColumnSizeBuilder := tableColumnsItems.FieldBuilder(5).(*array.Int32Builder)
+	xdbcDecimalDigitsBuilder := tableColumnsItems.FieldBuilder(6).(*array.Int16Builder)
+	xdbcNumPrecRadixBuilder := tableColumnsItems.FieldBuilder(7).(*array.Int16Builder)
+	xdbcNullableBuilder := tableColumnsItems.FieldBuilder(8).(*array.Int16Builder)
+	xdbcColumnDefBuilder := tableColumnsItems.FieldBuilder(9).(*array.StringBuilder)
+	xdbcSqlDataTypeBuilder := tableColumnsItems.FieldBuilder(10).(*array.Int16Builder)
+	xdbcDatetimeSubBuilder := tableColumnsItems.FieldBuilder(11).(*array.Int16Builder)
+	xdbcCharOctetLengthBuilder := tableColumnsItems.FieldBuilder(12).(*array.Int32Builder)
+	xdbcIsNullableBuilder := tableColumnsItems.FieldBuilder(13).(*array.StringBuilder)
+	xdbcScopeCatalogBuilder := tableColumnsItems.FieldBuilder(14).(*array.StringBuilder)
+	xdbcScopeSchemaBuilder := tableColumnsItems.FieldBuilder(15).(*array.StringBuilder)
+	xdbcScopeTableBuilder := tableColumnsItems.FieldBuilder(16).(*array.StringBuilder)
+	xdbcIsAutoincrementBuilder := tableColumnsItems.FieldBuilder(17).(*array.BooleanBuilder)
+	xdbcIsGeneratedcolumnBuilder := tableColumnsItems.FieldBuilder(18).(*array.BooleanBuilder)
+	tableConstraintsBuilder := dbSchemaTablesItems.FieldBuilder(3).(*array.ListBuilder)

Review Comment:
   i'm horrified but i don't think there's a better way haha. Maybe hide this behind a struct and then implement methods on that struct so we can pass it around and better modularize this huge function?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow-adbc] lidavidm commented on a diff in pull request #383: feat(go/adbc/driver/flightsql): implement GetObjects

Posted by "lidavidm (via GitHub)" <gi...@apache.org>.
lidavidm commented on code in PR #383:
URL: https://github.com/apache/arrow-adbc/pull/383#discussion_r1086001372


##########
go/adbc/driver/flightsql/flightsql_adbc.go:
##########
@@ -532,10 +536,339 @@ func (c *cnxn) GetInfo(ctx context.Context, infoCodes []adbc.InfoCode) (array.Re
 // All non-empty, non-nil strings should be a search pattern (as described
 // earlier).
 func (c *cnxn) GetObjects(ctx context.Context, depth adbc.ObjectDepth, catalog *string, dbSchema *string, tableName *string, columnName *string, tableType []string) (array.RecordReader, error) {
-	return nil, adbc.Error{
-		Msg:  "Not implemented: GetObjects",
-		Code: adbc.StatusNotImplemented,
+	builder := array.NewRecordBuilder(c.db.alloc, adbc.GetObjectsSchema)
+	defer builder.Release()
+
+	// To avoid an N+1 query problem, we assume result sets here will fit in memory and build up a single response.
+	info, err := c.cl.GetCatalogs(ctx)
+	if err != nil {
+		return nil, adbcFromFlightStatus(err)
+	}
+
+	rdr, err := c.readInfo(ctx, schema_ref.Catalogs, info)
+	if err != nil {
+		return nil, adbcFromFlightStatus(err)
+	}
+	defer rdr.Release()
+
+	catalogToDbSchemas, err := c.getObjectsDbSchemas(ctx, depth, catalog, dbSchema)
+	if err != nil {
+		return nil, err
+	}
+
+	tableLookup, err := c.getObjectsTables(ctx, depth, catalog, dbSchema, tableName, columnName, tableType)
+	if err != nil {
+		return nil, err
+	}
+
+	catalogNameBuilder := builder.Field(0).(*array.StringBuilder)
+	catalogDbSchemasBuilder := builder.Field(1).(*array.ListBuilder)
+	catalogDbSchemasItems := catalogDbSchemasBuilder.ValueBuilder().(*array.StructBuilder)
+	dbSchemaNameBuilder := catalogDbSchemasItems.FieldBuilder(0).(*array.StringBuilder)
+	dbSchemaTablesBuilder := catalogDbSchemasItems.FieldBuilder(1).(*array.ListBuilder)
+	dbSchemaTablesItems := dbSchemaTablesBuilder.ValueBuilder().(*array.StructBuilder)
+	tableNameBuilder := dbSchemaTablesItems.FieldBuilder(0).(*array.StringBuilder)
+	tableTypeBuilder := dbSchemaTablesItems.FieldBuilder(1).(*array.StringBuilder)
+	tableColumnsBuilder := dbSchemaTablesItems.FieldBuilder(2).(*array.ListBuilder)
+	tableColumnsItems := tableColumnsBuilder.ValueBuilder().(*array.StructBuilder)
+	columnNameBuilder := tableColumnsItems.FieldBuilder(0).(*array.StringBuilder)
+	ordinalPositionBuilder := tableColumnsItems.FieldBuilder(1).(*array.Int32Builder)
+	remarksBuilder := tableColumnsItems.FieldBuilder(2).(*array.StringBuilder)
+	xdbcDataTypeBuilder := tableColumnsItems.FieldBuilder(3).(*array.Int16Builder)
+	xdbcTypeNameBuilder := tableColumnsItems.FieldBuilder(4).(*array.StringBuilder)
+	xdbcColumnSizeBuilder := tableColumnsItems.FieldBuilder(5).(*array.Int32Builder)
+	xdbcDecimalDigitsBuilder := tableColumnsItems.FieldBuilder(6).(*array.Int16Builder)
+	xdbcNumPrecRadixBuilder := tableColumnsItems.FieldBuilder(7).(*array.Int16Builder)
+	xdbcNullableBuilder := tableColumnsItems.FieldBuilder(8).(*array.Int16Builder)
+	xdbcColumnDefBuilder := tableColumnsItems.FieldBuilder(9).(*array.StringBuilder)
+	xdbcSqlDataTypeBuilder := tableColumnsItems.FieldBuilder(10).(*array.Int16Builder)
+	xdbcDatetimeSubBuilder := tableColumnsItems.FieldBuilder(11).(*array.Int16Builder)
+	xdbcCharOctetLengthBuilder := tableColumnsItems.FieldBuilder(12).(*array.Int32Builder)
+	xdbcIsNullableBuilder := tableColumnsItems.FieldBuilder(13).(*array.StringBuilder)
+	xdbcScopeCatalogBuilder := tableColumnsItems.FieldBuilder(14).(*array.StringBuilder)
+	xdbcScopeSchemaBuilder := tableColumnsItems.FieldBuilder(15).(*array.StringBuilder)
+	xdbcScopeTableBuilder := tableColumnsItems.FieldBuilder(16).(*array.StringBuilder)
+	xdbcIsAutoincrementBuilder := tableColumnsItems.FieldBuilder(17).(*array.BooleanBuilder)
+	xdbcIsGeneratedcolumnBuilder := tableColumnsItems.FieldBuilder(18).(*array.BooleanBuilder)
+	tableConstraintsBuilder := dbSchemaTablesItems.FieldBuilder(3).(*array.ListBuilder)

Review Comment:
   Yeah, and I can probably break up those loops a bit at that point



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow-adbc] zeroshade commented on a diff in pull request #383: feat(go/adbc/driver/flightsql): implement GetObjects

Posted by "zeroshade (via GitHub)" <gi...@apache.org>.
zeroshade commented on code in PR #383:
URL: https://github.com/apache/arrow-adbc/pull/383#discussion_r1088174363


##########
go/adbc/driver/flightsql/flightsql_adbc.go:
##########
@@ -564,10 +568,421 @@ func (c *cnxn) GetInfo(ctx context.Context, infoCodes []adbc.InfoCode) (array.Re
 // All non-empty, non-nil strings should be a search pattern (as described
 // earlier).
 func (c *cnxn) GetObjects(ctx context.Context, depth adbc.ObjectDepth, catalog *string, dbSchema *string, tableName *string, columnName *string, tableType []string) (array.RecordReader, error) {
-	return nil, adbc.Error{
-		Msg:  "Not implemented: GetObjects",
-		Code: adbc.StatusNotImplemented,
+	ctx = metadata.NewOutgoingContext(ctx, c.hdrs)
+	g := getObjects{ctx: ctx, depth: depth, catalog: catalog, dbSchema: dbSchema, tableName: tableName, columnName: columnName, tableType: tableType}
+	if err := g.init(c); err != nil {
+		return nil, err
+	}
+	defer g.release()
+
+	// To avoid an N+1 query problem, we assume result sets here will fit in memory and build up a single response.
+	info, err := c.cl.GetCatalogs(ctx)
+	if err != nil {
+		return nil, adbcFromFlightStatus(err)
+	}
+
+	rdr, err := c.readInfo(ctx, schema_ref.Catalogs, info)
+	if err != nil {
+		return nil, adbcFromFlightStatus(err)
+	}
+	defer rdr.Release()
+
+	for rdr.Next() {
+		arr := rdr.Record().Column(0).(*array.String)
+		for i := 0; i < arr.Len(); i++ {
+			catalogName := arr.Value(i)
+			g.appendCatalog(catalogName)
+		}
+	}
+
+	err = rdr.Err()
+	if err != nil {

Review Comment:
   make this a single line for convenience? 
   
   ```go
   if err = rdr.Err(); err != nil {
       return nil, adbcFromFlightStatus(err)
   }
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow-adbc] lidavidm commented on a diff in pull request #383: feat(go/adbc/driver/flightsql): implement GetObjects

Posted by "lidavidm (via GitHub)" <gi...@apache.org>.
lidavidm commented on code in PR #383:
URL: https://github.com/apache/arrow-adbc/pull/383#discussion_r1086001174


##########
go/adbc/driver/flightsql/flightsql_adbc.go:
##########
@@ -532,10 +536,339 @@ func (c *cnxn) GetInfo(ctx context.Context, infoCodes []adbc.InfoCode) (array.Re
 // All non-empty, non-nil strings should be a search pattern (as described
 // earlier).
 func (c *cnxn) GetObjects(ctx context.Context, depth adbc.ObjectDepth, catalog *string, dbSchema *string, tableName *string, columnName *string, tableType []string) (array.RecordReader, error) {
-	return nil, adbc.Error{
-		Msg:  "Not implemented: GetObjects",
-		Code: adbc.StatusNotImplemented,
+	builder := array.NewRecordBuilder(c.db.alloc, adbc.GetObjectsSchema)
+	defer builder.Release()
+
+	// To avoid an N+1 query problem, we assume result sets here will fit in memory and build up a single response.
+	info, err := c.cl.GetCatalogs(ctx)
+	if err != nil {
+		return nil, adbcFromFlightStatus(err)
+	}
+
+	rdr, err := c.readInfo(ctx, schema_ref.Catalogs, info)

Review Comment:
   readInfo uses the statement reader, so we don't need to make that assumption



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow-adbc] lidavidm merged pull request #383: feat(go/adbc/driver/flightsql): implement GetObjects

Posted by "lidavidm (via GitHub)" <gi...@apache.org>.
lidavidm merged PR #383:
URL: https://github.com/apache/arrow-adbc/pull/383


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow-adbc] lidavidm commented on a diff in pull request #383: feat(go/adbc/driver/flightsql): implement GetObjects

Posted by "lidavidm (via GitHub)" <gi...@apache.org>.
lidavidm commented on code in PR #383:
URL: https://github.com/apache/arrow-adbc/pull/383#discussion_r1087060780


##########
go/adbc/driver/flightsql/flightsql_adbc.go:
##########
@@ -532,10 +536,339 @@ func (c *cnxn) GetInfo(ctx context.Context, infoCodes []adbc.InfoCode) (array.Re
 // All non-empty, non-nil strings should be a search pattern (as described
 // earlier).
 func (c *cnxn) GetObjects(ctx context.Context, depth adbc.ObjectDepth, catalog *string, dbSchema *string, tableName *string, columnName *string, tableType []string) (array.RecordReader, error) {
-	return nil, adbc.Error{
-		Msg:  "Not implemented: GetObjects",
-		Code: adbc.StatusNotImplemented,
+	builder := array.NewRecordBuilder(c.db.alloc, adbc.GetObjectsSchema)
+	defer builder.Release()
+
+	// To avoid an N+1 query problem, we assume result sets here will fit in memory and build up a single response.
+	info, err := c.cl.GetCatalogs(ctx)
+	if err != nil {
+		return nil, adbcFromFlightStatus(err)
+	}
+
+	rdr, err := c.readInfo(ctx, schema_ref.Catalogs, info)
+	if err != nil {
+		return nil, adbcFromFlightStatus(err)
+	}
+	defer rdr.Release()
+
+	catalogToDbSchemas, err := c.getObjectsDbSchemas(ctx, depth, catalog, dbSchema)
+	if err != nil {
+		return nil, err
+	}
+
+	tableLookup, err := c.getObjectsTables(ctx, depth, catalog, dbSchema, tableName, columnName, tableType)
+	if err != nil {
+		return nil, err
+	}
+
+	catalogNameBuilder := builder.Field(0).(*array.StringBuilder)
+	catalogDbSchemasBuilder := builder.Field(1).(*array.ListBuilder)
+	catalogDbSchemasItems := catalogDbSchemasBuilder.ValueBuilder().(*array.StructBuilder)
+	dbSchemaNameBuilder := catalogDbSchemasItems.FieldBuilder(0).(*array.StringBuilder)
+	dbSchemaTablesBuilder := catalogDbSchemasItems.FieldBuilder(1).(*array.ListBuilder)
+	dbSchemaTablesItems := dbSchemaTablesBuilder.ValueBuilder().(*array.StructBuilder)
+	tableNameBuilder := dbSchemaTablesItems.FieldBuilder(0).(*array.StringBuilder)
+	tableTypeBuilder := dbSchemaTablesItems.FieldBuilder(1).(*array.StringBuilder)
+	tableColumnsBuilder := dbSchemaTablesItems.FieldBuilder(2).(*array.ListBuilder)
+	tableColumnsItems := tableColumnsBuilder.ValueBuilder().(*array.StructBuilder)
+	columnNameBuilder := tableColumnsItems.FieldBuilder(0).(*array.StringBuilder)
+	ordinalPositionBuilder := tableColumnsItems.FieldBuilder(1).(*array.Int32Builder)
+	remarksBuilder := tableColumnsItems.FieldBuilder(2).(*array.StringBuilder)
+	xdbcDataTypeBuilder := tableColumnsItems.FieldBuilder(3).(*array.Int16Builder)
+	xdbcTypeNameBuilder := tableColumnsItems.FieldBuilder(4).(*array.StringBuilder)
+	xdbcColumnSizeBuilder := tableColumnsItems.FieldBuilder(5).(*array.Int32Builder)
+	xdbcDecimalDigitsBuilder := tableColumnsItems.FieldBuilder(6).(*array.Int16Builder)
+	xdbcNumPrecRadixBuilder := tableColumnsItems.FieldBuilder(7).(*array.Int16Builder)
+	xdbcNullableBuilder := tableColumnsItems.FieldBuilder(8).(*array.Int16Builder)
+	xdbcColumnDefBuilder := tableColumnsItems.FieldBuilder(9).(*array.StringBuilder)
+	xdbcSqlDataTypeBuilder := tableColumnsItems.FieldBuilder(10).(*array.Int16Builder)
+	xdbcDatetimeSubBuilder := tableColumnsItems.FieldBuilder(11).(*array.Int16Builder)
+	xdbcCharOctetLengthBuilder := tableColumnsItems.FieldBuilder(12).(*array.Int32Builder)
+	xdbcIsNullableBuilder := tableColumnsItems.FieldBuilder(13).(*array.StringBuilder)
+	xdbcScopeCatalogBuilder := tableColumnsItems.FieldBuilder(14).(*array.StringBuilder)
+	xdbcScopeSchemaBuilder := tableColumnsItems.FieldBuilder(15).(*array.StringBuilder)
+	xdbcScopeTableBuilder := tableColumnsItems.FieldBuilder(16).(*array.StringBuilder)
+	xdbcIsAutoincrementBuilder := tableColumnsItems.FieldBuilder(17).(*array.BooleanBuilder)
+	xdbcIsGeneratedcolumnBuilder := tableColumnsItems.FieldBuilder(18).(*array.BooleanBuilder)
+	tableConstraintsBuilder := dbSchemaTablesItems.FieldBuilder(3).(*array.ListBuilder)

Review Comment:
   Refactored into a separate struct, with a few methods instead of one giant method, and rearranged things to unnest the loops



##########
go/adbc/driver/flightsql/flightsql_adbc.go:
##########
@@ -532,10 +536,339 @@ func (c *cnxn) GetInfo(ctx context.Context, infoCodes []adbc.InfoCode) (array.Re
 // All non-empty, non-nil strings should be a search pattern (as described
 // earlier).
 func (c *cnxn) GetObjects(ctx context.Context, depth adbc.ObjectDepth, catalog *string, dbSchema *string, tableName *string, columnName *string, tableType []string) (array.RecordReader, error) {
-	return nil, adbc.Error{
-		Msg:  "Not implemented: GetObjects",
-		Code: adbc.StatusNotImplemented,
+	builder := array.NewRecordBuilder(c.db.alloc, adbc.GetObjectsSchema)
+	defer builder.Release()
+
+	// To avoid an N+1 query problem, we assume result sets here will fit in memory and build up a single response.
+	info, err := c.cl.GetCatalogs(ctx)
+	if err != nil {
+		return nil, adbcFromFlightStatus(err)
+	}
+
+	rdr, err := c.readInfo(ctx, schema_ref.Catalogs, info)
+	if err != nil {
+		return nil, adbcFromFlightStatus(err)
+	}
+	defer rdr.Release()
+
+	catalogToDbSchemas, err := c.getObjectsDbSchemas(ctx, depth, catalog, dbSchema)
+	if err != nil {
+		return nil, err
+	}
+
+	tableLookup, err := c.getObjectsTables(ctx, depth, catalog, dbSchema, tableName, columnName, tableType)
+	if err != nil {
+		return nil, err
+	}
+
+	catalogNameBuilder := builder.Field(0).(*array.StringBuilder)
+	catalogDbSchemasBuilder := builder.Field(1).(*array.ListBuilder)
+	catalogDbSchemasItems := catalogDbSchemasBuilder.ValueBuilder().(*array.StructBuilder)
+	dbSchemaNameBuilder := catalogDbSchemasItems.FieldBuilder(0).(*array.StringBuilder)
+	dbSchemaTablesBuilder := catalogDbSchemasItems.FieldBuilder(1).(*array.ListBuilder)
+	dbSchemaTablesItems := dbSchemaTablesBuilder.ValueBuilder().(*array.StructBuilder)
+	tableNameBuilder := dbSchemaTablesItems.FieldBuilder(0).(*array.StringBuilder)
+	tableTypeBuilder := dbSchemaTablesItems.FieldBuilder(1).(*array.StringBuilder)
+	tableColumnsBuilder := dbSchemaTablesItems.FieldBuilder(2).(*array.ListBuilder)
+	tableColumnsItems := tableColumnsBuilder.ValueBuilder().(*array.StructBuilder)
+	columnNameBuilder := tableColumnsItems.FieldBuilder(0).(*array.StringBuilder)
+	ordinalPositionBuilder := tableColumnsItems.FieldBuilder(1).(*array.Int32Builder)
+	remarksBuilder := tableColumnsItems.FieldBuilder(2).(*array.StringBuilder)
+	xdbcDataTypeBuilder := tableColumnsItems.FieldBuilder(3).(*array.Int16Builder)
+	xdbcTypeNameBuilder := tableColumnsItems.FieldBuilder(4).(*array.StringBuilder)
+	xdbcColumnSizeBuilder := tableColumnsItems.FieldBuilder(5).(*array.Int32Builder)
+	xdbcDecimalDigitsBuilder := tableColumnsItems.FieldBuilder(6).(*array.Int16Builder)
+	xdbcNumPrecRadixBuilder := tableColumnsItems.FieldBuilder(7).(*array.Int16Builder)
+	xdbcNullableBuilder := tableColumnsItems.FieldBuilder(8).(*array.Int16Builder)
+	xdbcColumnDefBuilder := tableColumnsItems.FieldBuilder(9).(*array.StringBuilder)
+	xdbcSqlDataTypeBuilder := tableColumnsItems.FieldBuilder(10).(*array.Int16Builder)
+	xdbcDatetimeSubBuilder := tableColumnsItems.FieldBuilder(11).(*array.Int16Builder)
+	xdbcCharOctetLengthBuilder := tableColumnsItems.FieldBuilder(12).(*array.Int32Builder)
+	xdbcIsNullableBuilder := tableColumnsItems.FieldBuilder(13).(*array.StringBuilder)
+	xdbcScopeCatalogBuilder := tableColumnsItems.FieldBuilder(14).(*array.StringBuilder)
+	xdbcScopeSchemaBuilder := tableColumnsItems.FieldBuilder(15).(*array.StringBuilder)
+	xdbcScopeTableBuilder := tableColumnsItems.FieldBuilder(16).(*array.StringBuilder)
+	xdbcIsAutoincrementBuilder := tableColumnsItems.FieldBuilder(17).(*array.BooleanBuilder)
+	xdbcIsGeneratedcolumnBuilder := tableColumnsItems.FieldBuilder(18).(*array.BooleanBuilder)
+	tableConstraintsBuilder := dbSchemaTablesItems.FieldBuilder(3).(*array.ListBuilder)

Review Comment:
   Refactored into a separate struct, with a few methods instead of one giant method, and rearranged things to unnest the indentation a bit



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow-adbc] lidavidm commented on pull request #383: feat(go/adbc/driver/flightsql): implement GetObjects

Posted by "lidavidm (via GitHub)" <gi...@apache.org>.
lidavidm commented on PR #383:
URL: https://github.com/apache/arrow-adbc/pull/383#issuecomment-1404180035

   Rebased, fixed compile error after rebase


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org