You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pig.apache.org by xu...@apache.org on 2011/04/20 21:02:31 UTC

svn commit: r1095484 - in /pig/trunk: CHANGES.txt src/org/apache/pig/newplan/logical/expression/CastExpression.java test/org/apache/pig/parser/TestLogicalPlanGenerator.java

Author: xuefu
Date: Wed Apr 20 19:02:30 2011
New Revision: 1095484

URL: http://svn.apache.org/viewvc?rev=1095484&view=rev
Log:
PIG-2002: Regression: Pig gives error <Projection with nothing to reference> for a valid query

Modified:
    pig/trunk/CHANGES.txt
    pig/trunk/src/org/apache/pig/newplan/logical/expression/CastExpression.java
    pig/trunk/test/org/apache/pig/parser/TestLogicalPlanGenerator.java

Modified: pig/trunk/CHANGES.txt
URL: http://svn.apache.org/viewvc/pig/trunk/CHANGES.txt?rev=1095484&r1=1095483&r2=1095484&view=diff
==============================================================================
--- pig/trunk/CHANGES.txt (original)
+++ pig/trunk/CHANGES.txt Wed Apr 20 19:02:30 2011
@@ -42,6 +42,8 @@ PIG-1876: Typed map for Pig (daijy)
 
 IMPROVEMENTS
 
+PIG-2002: Regression: Pig gives error "Projection with nothing to reference!" for a valid query (xuefu)
+
 PIG-1921: Improve error messages in new parser (xuefu)
 
 PIG-1996: Pig new parser fails to recognize PARALLEL keywords in a case (xuefu)

Modified: pig/trunk/src/org/apache/pig/newplan/logical/expression/CastExpression.java
URL: http://svn.apache.org/viewvc/pig/trunk/src/org/apache/pig/newplan/logical/expression/CastExpression.java?rev=1095484&r1=1095483&r2=1095484&view=diff
==============================================================================
--- pig/trunk/src/org/apache/pig/newplan/logical/expression/CastExpression.java (original)
+++ pig/trunk/src/org/apache/pig/newplan/logical/expression/CastExpression.java Wed Apr 20 19:02:30 2011
@@ -89,7 +89,7 @@ public class CastExpression extends Unar
         LogicalExpression copy = new CastExpression(
                 lgExpPlan,
                 this.getExpression().deepCopy(lgExpPlan),
-                this.getFieldSchema().deepCopy());
+                castSchema.deepCopy());
         try {
             FuncSpec origFuncSpec = this.getFuncSpec();
             if (origFuncSpec != null ) {

Modified: pig/trunk/test/org/apache/pig/parser/TestLogicalPlanGenerator.java
URL: http://svn.apache.org/viewvc/pig/trunk/test/org/apache/pig/parser/TestLogicalPlanGenerator.java?rev=1095484&r1=1095483&r2=1095484&view=diff
==============================================================================
--- pig/trunk/test/org/apache/pig/parser/TestLogicalPlanGenerator.java (original)
+++ pig/trunk/test/org/apache/pig/parser/TestLogicalPlanGenerator.java Wed Apr 20 19:02:30 2011
@@ -46,6 +46,7 @@ public class TestLogicalPlanGenerator {
                          };
         command = Util.createInputFile("script", "pl", script);
     }
+    
     @Test
     public void test1() {
         String query = "A = load 'x' as ( u:int, v:long, w:bytearray); " + 
@@ -230,9 +231,17 @@ public class TestLogicalPlanGenerator {
     }
 
     @Test
+    public void test19() {
+        String query = "A = load 'x' as (u:map[], v);\n" +
+                       "B = foreach A { T = (chararray)u#'hello'#'world'; generate T; };";
+        generateLogicalPlan( query );
+    }
+    
+    @Test
     public void testFilter() {
         String query = "A = load 'x' as ( u:int, v:long, w:bytearray); " + 
-                       "B = filter A by 2 > 1; ";
+                       "B = filter A by 2 > 1;\n" +
+                       "store B into 'y';";
         generateLogicalPlan( query );
     }