You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by ch...@apache.org on 2017/03/04 00:59:27 UTC
[02/50] [abbrv] [text] TEXT-63 Mutable fields should be private
TEXT-63 Mutable fields should be private
Project: http://git-wip-us.apache.org/repos/asf/commons-text/repo
Commit: http://git-wip-us.apache.org/repos/asf/commons-text/commit/5066ac6f
Tree: http://git-wip-us.apache.org/repos/asf/commons-text/tree/5066ac6f
Diff: http://git-wip-us.apache.org/repos/asf/commons-text/diff/5066ac6f
Branch: refs/heads/release
Commit: 5066ac6f1ce5dfd729e8269d10680f23103e404a
Parents: 7a96b50
Author: Sebb <se...@apache.org>
Authored: Wed Feb 8 10:40:43 2017 +0000
Committer: Sebb <se...@apache.org>
Committed: Wed Feb 8 10:40:43 2017 +0000
----------------------------------------------------------------------
src/changes/changes.xml | 4 ++++
src/main/java/org/apache/commons/text/beta/StrBuilder.java | 4 ++--
2 files changed, 6 insertions(+), 2 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/commons-text/blob/5066ac6f/src/changes/changes.xml
----------------------------------------------------------------------
diff --git a/src/changes/changes.xml b/src/changes/changes.xml
index 88e9c52..6a567ec 100644
--- a/src/changes/changes.xml
+++ b/src/changes/changes.xml
@@ -45,6 +45,10 @@ The <action> type attribute can be add,update,fix,remove.
</properties>
<body>
+ <release version="TBA" date="TBA" description="TBA">
+ <action issue="TEXT-63" type="fix" dev="sebb">Mutable fields should be private</action>
+ </release>
+
<release version="1.0-beta-1" date="2017-01-30" description="First release (beta) of Commons Text">
<action issue="TEXT-62" type="fix" dev="chtompki">Incorporate suggestions from RC2 into 1.0 release</action>
<action issue="TEXT-61" type="update" dev="chtompki" due-to="Lee Adcock">Naming packages org.apache.commons.text.beta</action>
http://git-wip-us.apache.org/repos/asf/commons-text/blob/5066ac6f/src/main/java/org/apache/commons/text/beta/StrBuilder.java
----------------------------------------------------------------------
diff --git a/src/main/java/org/apache/commons/text/beta/StrBuilder.java b/src/main/java/org/apache/commons/text/beta/StrBuilder.java
index 260055a..5043fd6 100644
--- a/src/main/java/org/apache/commons/text/beta/StrBuilder.java
+++ b/src/main/java/org/apache/commons/text/beta/StrBuilder.java
@@ -82,9 +82,9 @@ public class StrBuilder implements CharSequence, Appendable, Serializable, Build
private static final long serialVersionUID = 7628716375283629643L;
/** Internal data storage. */
- protected char[] buffer; // TODO make private?
+ char[] buffer; // package-protected for test code use only
/** Current size of the buffer. */
- protected int size; // TODO make private?
+ private int size;
/** The new line. */
private String newLine;
/** The null text. */