You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@forrest.apache.org by "Gavin (JIRA)" <ji...@apache.org> on 2007/03/04 07:40:50 UTC
[jira] Commented: (FOR-811) shine and polish the pelt theme so that
it closely resembles the pelt skin
[ https://issues.apache.org/jira/browse/FOR-811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12477744 ]
Gavin commented on FOR-811:
---------------------------
More enhancements committed, mainly the nav & tab menu font colors etc, added in an optional <div> area below the navigation.
The Table problem I described seems to have gone.
More to do, which I'll describe on list.
Gav...
> shine and polish the pelt theme so that it closely resembles the pelt skin
> --------------------------------------------------------------------------
>
> Key: FOR-811
> URL: https://issues.apache.org/jira/browse/FOR-811
> Project: Forrest
> Issue Type: Sub-task
> Components: Dispatcher (aka views), Skins (general issues)
> Reporter: David Crossley
> Attachments: pelt.fv.diff, pelt.screen.css.diff, siteinfo-credits.ft.diff
>
>
> So that they can just switch from "pelt skin" to "pelt theme" and not get any surprises, e.g. "pelt skin' has no "xml doc" link.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
RE: [jira] Commented: (FOR-811) shine and polish the pelt theme sothat it closely resembles the pelt skin
Posted by "Gav...." <br...@brightontown.com.au>.
Excellent thanks, got it working from that.
Just need to tidy it up and get it in the correct location then
Will commit it later.
Cheers
Gav...
> -----Original Message-----
> From: Thorsten Scherler [mailto:thorsten@apache.org]
> Sent: Monday, 5 March 2007 7:10 AM
> To: dev@forrest.apache.org
> Subject: RE: [jira] Commented: (FOR-811) shine and polish the pelt theme
> sothat it closely resembles the pelt skin
>
> On Sun, 2007-03-04 at 19:51 +0900, Gav.... wrote:
> ...
> >
> > I have :-
> >
> > <xsl:param name="defaultVariables" select="'test.html'"/>
> > <xsl:variable name="root"
> > select="$defaultVariables/*/*[@name='root']/@value"/>
> > <xsl:template name="branding-fontsize-head">
> > <script type="text/javascript"
> >
> > src="{$root}themes/fontsize.js"> </script>
> >
>
> That looks fine to me.
>
> http://localhost:8888/themes/fontsize.js
>
>
> > I may be going the wrong way about this, but I'm looking at other files
> for
> > clues.
> >
> > Can someone talk me through this.
>
> http://svn.apache.org/viewvc/forrest/trunk/whiteboard/plugins/org.apache.f
> orrest.themes.core/themes/common/html/master.ft?view=markup
>
> >
> > <xsl:param name="defaultVariables" select="'test.html'"/>
> >
> > Why 'test.html' , and where is this file, I found a 'test1.html' in
> > src/documentation.
>
> It is not a file that is why it is in '' it is a string variable as
> default.
>
> You can change this to
> <xsl:param name="defaultVariables"/> if you want.
>
> The defaultVariables are:
> String propertyURI = "cocoon://" + requestId + ".props";
>
> try:
>
> http://localhost:8888/index.props
>
> >
> > select="$defaultVariables/*/*[@name='root']/@value"/>
> >
> > How and what does this resolve to.
>
>
> the xpath of <property value="" name="root"/>
>
> >
> > The above answers may explain but
> >
> > src="{$root}themes/fontsize.js"> </script>
> >
> > how does that end up being /themes/pelt/js/fontsize.js
>
> It is in
> http://svn.apache.org/viewvc/forrest/trunk/whiteboard/plugins/org.apache.f
> orrest.themes.core/themes/common/js/
>
> http://svn.apache.org/viewvc/forrest/trunk/whiteboard/plugins/org.apache.f
> orrest.plugin.internal.dispatcher/themes.xmap?view=markup
> <map:match pattern="themes/**.js">
> <map:read mime-type="application/x-javascript"
> src="{lm:themes/{1}.js}"
> />
> </map:match>
>
> http://svn.apache.org/viewvc/forrest/trunk/whiteboard/plugins/org.apache.f
> orrest.plugin.internal.dispatcher/locationmap.xml?view=markup
> <!-- generic match for theme resources like css and js. -->
> <!--
> {1} name
> {2} extension (note we assume e.g. PATH/css/{1}.css)
> -->
> <match pattern="themes/**.*">
> <select type="exists">
> <location
>
> src="{lm:themer.project.dir}/{properties:dispatcher.theme}/{2}/{1}.{2}" />
> <location
>
> src="{lm:themer.project.dir}/{properties:dispatcher.fallback.theme}/{2}/{1
> }.{2}"
> />
> <!-- plugin provided contracts -->
> <location src="{lm:resolvePluginThemes.{2}.{1}}" />
> <location
>
> src="{lm:dispatcher.themer}/themes/{properties:dispatcher.theme}/{2}/{1}.{
> 2}"
> />
> <location
>
> src="{lm:dispatcher.themer}/themes/{properties:dispatcher.fallback.theme}/
> {2}/{1}.{2}"
> />
> </select>
> </match>
>
> >
> > Thanks
>
> To you and HTH.
>
> salu2
> --
> Thorsten Scherler thorsten.at.apache.org
> Open Source Java & XML consulting, training and solutions
RE: [jira] Commented: (FOR-811) shine and polish the pelt theme so
that it closely resembles the pelt skin
Posted by Thorsten Scherler <th...@apache.org>.
On Sun, 2007-03-04 at 19:51 +0900, Gav.... wrote:
...
>
> I have :-
>
> <xsl:param name="defaultVariables" select="'test.html'"/>
> <xsl:variable name="root"
> select="$defaultVariables/*/*[@name='root']/@value"/>
> <xsl:template name="branding-fontsize-head">
> <script type="text/javascript"
>
> src="{$root}themes/fontsize.js"> </script>
>
That looks fine to me.
http://localhost:8888/themes/fontsize.js
> I may be going the wrong way about this, but I'm looking at other files for
> clues.
>
> Can someone talk me through this.
http://svn.apache.org/viewvc/forrest/trunk/whiteboard/plugins/org.apache.forrest.themes.core/themes/common/html/master.ft?view=markup
>
> <xsl:param name="defaultVariables" select="'test.html'"/>
>
> Why 'test.html' , and where is this file, I found a 'test1.html' in
> src/documentation.
It is not a file that is why it is in '' it is a string variable as
default.
You can change this to
<xsl:param name="defaultVariables"/> if you want.
The defaultVariables are:
String propertyURI = "cocoon://" + requestId + ".props";
try:
http://localhost:8888/index.props
>
> select="$defaultVariables/*/*[@name='root']/@value"/>
>
> How and what does this resolve to.
the xpath of <property value="" name="root"/>
>
> The above answers may explain but
>
> src="{$root}themes/fontsize.js"> </script>
>
> how does that end up being /themes/pelt/js/fontsize.js
It is in
http://svn.apache.org/viewvc/forrest/trunk/whiteboard/plugins/org.apache.forrest.themes.core/themes/common/js/
http://svn.apache.org/viewvc/forrest/trunk/whiteboard/plugins/org.apache.forrest.plugin.internal.dispatcher/themes.xmap?view=markup
<map:match pattern="themes/**.js">
<map:read mime-type="application/x-javascript" src="{lm:themes/{1}.js}"
/>
</map:match>
http://svn.apache.org/viewvc/forrest/trunk/whiteboard/plugins/org.apache.forrest.plugin.internal.dispatcher/locationmap.xml?view=markup
<!-- generic match for theme resources like css and js. -->
<!--
{1} name
{2} extension (note we assume e.g. PATH/css/{1}.css)
-->
<match pattern="themes/**.*">
<select type="exists">
<location
src="{lm:themer.project.dir}/{properties:dispatcher.theme}/{2}/{1}.{2}" />
<location
src="{lm:themer.project.dir}/{properties:dispatcher.fallback.theme}/{2}/{1}.{2}"
/>
<!-- plugin provided contracts -->
<location src="{lm:resolvePluginThemes.{2}.{1}}" />
<location
src="{lm:dispatcher.themer}/themes/{properties:dispatcher.theme}/{2}/{1}.{2}"
/>
<location
src="{lm:dispatcher.themer}/themes/{properties:dispatcher.fallback.theme}/{2}/{1}.{2}"
/>
</select>
</match>
>
> Thanks
To you and HTH.
salu2
--
Thorsten Scherler thorsten.at.apache.org
Open Source Java & XML consulting, training and solutions
RE: [jira] Commented: (FOR-811) shine and polish the pelt theme so that it closely resembles the pelt skin
Posted by "Gav...." <br...@brightontown.com.au>.
> -----Original Message-----
> From: Gav.... [mailto:brightoncomputers@brightontown.com.au]
> Sent: Sunday, 4 March 2007 4:56 PM
> To: dev@forrest.apache.org
> Subject: RE: [jira] Commented: (FOR-811) shine and polish the pelt theme
> so that it closely resembles the pelt skin
>
>
>
> > -----Original Message-----
> > From: Gav.... [mailto:brightoncomputers@brightontown.com.au]
> > Sent: Sunday, 4 March 2007 3:59 PM
> > To: dev@forrest.apache.org
> > Subject: RE: [jira] Commented: (FOR-811) shine and polish the pelt theme
> > so that it closely resembles the pelt skin
> >
> <snip>
> >
> > 2. Font resize facility is missing from Pelt Theme, there is an inline
> > comment about it not working with Pelt Theme, so need to look at it.
> >
>
> Cocoon is complaining about not being able to find the variable 'root'
>
> In the branding-fontsize.ft we have :-
>
> <script type="text/javascript"
> src="{$root}themes/fontsize.js"> </script>
>
> But '$root' is not declared anywhere in the file, where is it supposed to
> be
> Getting it from?
>
> (I notice other files declare it earlier on like
> <xsl:variable name="root"
> select="$defaultVariables/*/*[@name='root']/@value"/>
> Which I tried without success)
>
> Gav...
I have :-
<xsl:param name="defaultVariables" select="'test.html'"/>
<xsl:variable name="root"
select="$defaultVariables/*/*[@name='root']/@value"/>
<xsl:template name="branding-fontsize-head">
<script type="text/javascript"
src="{$root}themes/fontsize.js"> </script>
I may be going the wrong way about this, but I'm looking at other files for
clues.
Can someone talk me through this.
<xsl:param name="defaultVariables" select="'test.html'"/>
Why 'test.html' , and where is this file, I found a 'test1.html' in
src/documentation.
select="$defaultVariables/*/*[@name='root']/@value"/>
How and what does this resolve to.
The above answers may explain but
src="{$root}themes/fontsize.js"> </script>
how does that end up being /themes/pelt/js/fontsize.js
Thanks
Gav...
RE: [jira] Commented: (FOR-811) shine and polish the pelt theme so that it closely resembles the pelt skin
Posted by "Gav...." <br...@brightontown.com.au>.
> -----Original Message-----
> From: Gav.... [mailto:brightoncomputers@brightontown.com.au]
> Sent: Sunday, 4 March 2007 3:59 PM
> To: dev@forrest.apache.org
> Subject: RE: [jira] Commented: (FOR-811) shine and polish the pelt theme
> so that it closely resembles the pelt skin
>
<snip>
>
> 2. Font resize facility is missing from Pelt Theme, there is an inline
> comment about it not working with Pelt Theme, so need to look at it.
>
Cocoon is complaining about not being able to find the variable 'root'
In the branding-fontsize.ft we have :-
<script type="text/javascript"
src="{$root}themes/fontsize.js"> </script>
But '$root' is not declared anywhere in the file, where is it supposed to be
Getting it from?
(I notice other files declare it earlier on like
<xsl:variable name="root"
select="$defaultVariables/*/*[@name='root']/@value"/>
Which I tried without success)
Gav...
RE: [jira] Commented: (FOR-811) shine and polish the pelt theme so that it closely resembles the pelt skin
Posted by "Gav...." <br...@brightontown.com.au>.
> -----Original Message-----
> From: Gav.... [mailto:brightoncomputers@brightontown.com.au]
> Sent: Sunday, 4 March 2007 3:59 PM
> To: dev@forrest.apache.org
> Subject: RE: [jira] Commented: (FOR-811) shine and polish the pelt theme
> so that it closely resembles the pelt skin
>
>
>
> > -----Original Message-----
> > From: Gavin (JIRA) [mailto:jira@apache.org]
> > Sent: Sunday, 4 March 2007 3:41 PM
> > To: dev@forrest.apache.org
> > Subject: [jira] Commented: (FOR-811) shine and polish the pelt theme so
> > that it closely resembles the pelt skin
> >
> >
> > [ https://issues.apache.org/jira/browse/FOR-
> > 811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-
> > tabpanel#action_12477744 ]
> >
> > Gavin commented on FOR-811:
> > ---------------------------
> >
> > More enhancements committed, mainly the nav & tab menu font colors etc,
> > added in an optional <div> area below the navigation.
> > The Table problem I described seems to have gone.
> >
> > More to do, which I'll describe on list.
>
> Ok, I can see:-
>
> 1. XML & PDF etc images are different to that of pelt skin, I don't mind
> the
> new ones in pelt theme currently. Do we keep what we have or do you want
> the
> Ones in pelt skin used instead ?
I'll leave these unless otherwise mentioned.
>
> 2. Font resize facility is missing from Pelt Theme, there is an inline
> comment about it not working with Pelt Theme, so need to look at it.
This now works.
>
> 3. Pelt Skin has a thin white line beneath tabs, need to find that and
> change it in Pelt Theme.
This now works.
>
> 4. Top Breadtrail is a different color and font-size.
This is now the same.
>
> 5. current.gif is different(yellow) in pelt theme, it is not used at all
> in
> Pelt skin. Thoughts? Keep/lose.
I'll leave these unless otherwise mentioned.
>
> 6. Pelt Skin main blue is very slightly darker than pelt theme on main
> strip
> and navigation area.
Deceptive when checking visually, but no, they are the same.
>
> 7. I have changed sub-tabs but needs more of an example than what is in
> seed-sample to test it properly.
I'll expand the sample to show it off better, current sub-tab example tabs
Point to the same place, hence both are always selected.
In addition, the sub-tabs are not fully visible in IE6, so need to check
this out.
Gav...
>
> Anything I have missed, lets have it here :)
>
> Gav...
>
> >
> > Gav...
> >
> > > shine and polish the pelt theme so that it closely resembles the pelt
> > skin
> > > ----------------------------------------------------------------------
> --
> > --
> > >
> > > Key: FOR-811
> > > URL: https://issues.apache.org/jira/browse/FOR-811
> > > Project: Forrest
> > > Issue Type: Sub-task
> > > Components: Dispatcher (aka views), Skins (general issues)
> > > Reporter: David Crossley
> > > Attachments: pelt.fv.diff, pelt.screen.css.diff, siteinfo-
> > credits.ft.diff
> > >
> > >
> > > So that they can just switch from "pelt skin" to "pelt theme" and not
> > get any surprises, e.g. "pelt skin' has no "xml doc" link.
> >
> > --
> > This message is automatically generated by JIRA.
> > -
> > You can reply to this email to add a comment to the issue online.
RE: [jira] Commented: (FOR-811) shine and polish the pelt theme so that it closely resembles the pelt skin
Posted by "Gav...." <br...@brightontown.com.au>.
> -----Original Message-----
> From: Gavin (JIRA) [mailto:jira@apache.org]
> Sent: Sunday, 4 March 2007 3:41 PM
> To: dev@forrest.apache.org
> Subject: [jira] Commented: (FOR-811) shine and polish the pelt theme so
> that it closely resembles the pelt skin
>
>
> [ https://issues.apache.org/jira/browse/FOR-
> 811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-
> tabpanel#action_12477744 ]
>
> Gavin commented on FOR-811:
> ---------------------------
>
> More enhancements committed, mainly the nav & tab menu font colors etc,
> added in an optional <div> area below the navigation.
> The Table problem I described seems to have gone.
>
> More to do, which I'll describe on list.
Ok, I can see:-
1. XML & PDF etc images are different to that of pelt skin, I don't mind the
new ones in pelt theme currently. Do we keep what we have or do you want the
Ones in pelt skin used instead ?
2. Font resize facility is missing from Pelt Theme, there is an inline
comment about it not working with Pelt Theme, so need to look at it.
3. Pelt Skin has a thin white line beneath tabs, need to find that and
change it in Pelt Theme.
4. Top Breadtrail is a different color and font-size.
5. current.gif is different(yellow) in pelt theme, it is not used at all in
Pelt skin. Thoughts? Keep/lose.
6. Pelt Skin main blue is very slightly darker than pelt theme on main strip
and navigation area.
7. I have changed sub-tabs but needs more of an example than what is in
seed-sample to test it properly.
Anything I have missed, lets have it here :)
Gav...
>
> Gav...
>
> > shine and polish the pelt theme so that it closely resembles the pelt
> skin
> > ------------------------------------------------------------------------
> --
> >
> > Key: FOR-811
> > URL: https://issues.apache.org/jira/browse/FOR-811
> > Project: Forrest
> > Issue Type: Sub-task
> > Components: Dispatcher (aka views), Skins (general issues)
> > Reporter: David Crossley
> > Attachments: pelt.fv.diff, pelt.screen.css.diff, siteinfo-
> credits.ft.diff
> >
> >
> > So that they can just switch from "pelt skin" to "pelt theme" and not
> get any surprises, e.g. "pelt skin' has no "xml doc" link.
>
> --
> This message is automatically generated by JIRA.
> -
> You can reply to this email to add a comment to the issue online.