You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@hbase.apache.org by GitBox <gi...@apache.org> on 2021/05/14 13:09:17 UTC

[GitHub] [hbase] virajjasani edited a comment on pull request #3264: HBASE-25887 Wait for appendExecutor to shutdown running tasks

virajjasani edited a comment on pull request #3264:
URL: https://github.com/apache/hbase/pull/3264#issuecomment-841232549


   @apurtell @bharathv @shahrs87 
   As we had a little chat over Disruptor's constructor (as per 3.4.2 version) when I mentioned about ExecutorService being deprecated from it's constructor argument, on the same front, I just realized that HBase 2 is using recommended (non-deprecated) constructor and not passing ExecutorService and rather just providing ThreadFactory [here](https://github.com/apache/hbase/blob/branch-2/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/FSHLog.java#L258-L261)
   
   Wondering how we can ensure that Disruptor's own custom Executor is going to be properly shutdown and not leave any tasks in hanging state when we are just about to close OutputSteam in HBase 2 (HBase 1 is taken care of by @shahrs87's this PR fix)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org