You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jmeter-dev@jakarta.apache.org by se...@apache.org on 2007/10/19 14:08:39 UTC

svn commit: r586392 - /jakarta/jmeter/trunk/src/core/org/apache/jmeter/gui/tree/JMeterTreeModel.java

Author: sebb
Date: Fri Oct 19 05:08:39 2007
New Revision: 586392

URL: http://svn.apache.org/viewvc?rev=586392&view=rev
Log:
Tidy up:
- eliminate repetitive casting
- use specific get() methods instead of getProperty()

Modified:
    jakarta/jmeter/trunk/src/core/org/apache/jmeter/gui/tree/JMeterTreeModel.java

Modified: jakarta/jmeter/trunk/src/core/org/apache/jmeter/gui/tree/JMeterTreeModel.java
URL: http://svn.apache.org/viewvc/jakarta/jmeter/trunk/src/core/org/apache/jmeter/gui/tree/JMeterTreeModel.java?rev=586392&r1=586391&r2=586392&view=diff
==============================================================================
--- jakarta/jmeter/trunk/src/core/org/apache/jmeter/gui/tree/JMeterTreeModel.java (original)
+++ jakarta/jmeter/trunk/src/core/org/apache/jmeter/gui/tree/JMeterTreeModel.java Fri Oct 19 05:08:39 2007
@@ -92,18 +92,19 @@
 		while (iter.hasNext()) {
 			TestElement item = (TestElement) iter.next();
 			if (item instanceof TestPlan) {
+				TestPlan tp = (TestPlan) item;
 				current = (JMeterTreeNode) ((JMeterTreeNode) getRoot()).getChildAt(0);
-				((TestElement) current.getUserObject()).addTestElement(item);
-				((TestPlan) current.getUserObject()).setName(item.getPropertyAsString(TestElement.NAME));
-				((TestPlan) current.getUserObject()).setFunctionalMode(item
-						.getPropertyAsBoolean(TestPlan.FUNCTIONAL_MODE));
-				((TestPlan) current.getUserObject()).setSerialized(item
-						.getPropertyAsBoolean(TestPlan.SERIALIZE_THREADGROUPS));
+				final TestPlan userObject = (TestPlan) current.getUserObject();
+				userObject.addTestElement(item);
+				userObject.setName(item.getName());
+				userObject.setFunctionalMode(tp.isFunctionalMode());
+				userObject.setSerialized(tp.isSerialized());
 				addSubTree(subTree.getTree(item), current);
 			} else if (item instanceof WorkBench) {
 				current = (JMeterTreeNode) ((JMeterTreeNode) getRoot()).getChildAt(1);
-				((TestElement) current.getUserObject()).addTestElement(item);
-				((WorkBench) current.getUserObject()).setName(item.getPropertyAsString(TestElement.NAME));
+				final TestElement testElement = ((TestElement) current.getUserObject());
+				testElement.addTestElement(item);
+				testElement.setName(item.getName());
 				addSubTree(subTree.getTree(item), current);
 			} else {
 				addSubTree(subTree.getTree(item), addComponent(item, current));



---------------------------------------------------------------------
To unsubscribe, e-mail: jmeter-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: jmeter-dev-help@jakarta.apache.org