[GitHub] [netbeans] JaroslavTulach commented on a change in pull request #3843: Invoke arbitrary action from vscode

[GitBox <gi...@apache.org>]

JaroslavTulach commented on a change in pull request #3843:
URL: https://github.com/apache/netbeans/pull/3843#discussion_r834031100



##########
File path: java/java.lsp.server/src/org/netbeans/modules/java/lsp/server/explorer/NodeActionsProvider.java
##########
@@ -161,4 +166,40 @@ public static NodeActionsProvider forFile(FileObject f) {
         return CompletableFuture.completedFuture(true);
     }
     
+    private CompletableFuture<Object> invokeAction(NbCodeLanguageClient client, String category, String aid, List<Object> arguments) {
+        String path = "Actions/" + category + "/" + aid.replace('.', '-') + ".instance"; //NOI18N
+        FileObject config = FileUtil.getConfigFile(path);
+        String contextType = (String) config.getAttribute("type"); //NOI18N

Review comment:
       Please write a test for this new API/behavior.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists