You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2019/10/19 14:45:56 UTC

[GitHub] [skywalking] wu-sheng commented on a change in pull request #3657: [CI] Make E2E tests run in multiple JDK versions

wu-sheng commented on a change in pull request #3657: [CI] Make E2E tests run in multiple JDK versions
URL: https://github.com/apache/skywalking/pull/3657#discussion_r336740103
 
 

 ##########
 File path: apm-webapp/pom.xml
 ##########
 @@ -70,11 +70,6 @@
             <artifactId>spring-boot-configuration-processor</artifactId>
             <version>${spring.boot.version}</version>
         </dependency>
-        <dependency>
-            <groupId>org.springframework.boot</groupId>
-            <artifactId>spring-boot-devtools</artifactId>
-            <version>${spring.boot.version}</version>
-        </dependency>
 
 Review comment:
   Yes, this should be safe to be removed. This is byte code manipulated tech :) So it needs to do many things to be compatible with various JDKs :P

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services