[GitHub] [thrift] fishy opened a new pull request #2209: THRIFT-5257: Fix Go THeaderTransport endOfFrame handling

[GitBox <gi...@apache.org>]

fishy opened a new pull request #2209:
URL: https://github.com/apache/thrift/pull/2209


   Client: go
   
   In the current implementation, we only call endOfFrame when we hit EOF
   when reading from the frameReader. The problem is in go stdlib the Read
   call finished reading the remaining data from frameReader will not
   return EOF, the next Read will. This caused us in most cases only call
   endOfFrame at the beginning of the next frame, which could cause
   troubles because we didn't read the beginning of the frame properly.
   
   <!-- Explain the changes in the pull request below: -->
     
   
   <!-- We recommend you review the checklist/tips before submitting a pull request. -->
   
   - [x] Did you create an [Apache Jira](https://issues.apache.org/jira/projects/THRIFT/issues/) ticket?  (not required for trivial changes)
   - [x] If a ticket exists: Does your pull request title follow the pattern "THRIFT-NNNN: describe my issue"?
   - [x] Did you squash your changes to a single commit?  (not required, but preferred)
   - [x] Did you do your best to avoid breaking changes?  If one was needed, did you label the Jira ticket with "Breaking-Change"?
   - [ ] If your change does not involve any code, include `[skip ci]` anywhere in the commit message to free up build resources.
   
   <!--
     The Contributing Guide at:
     https://github.com/apache/thrift/blob/master/CONTRIBUTING.md
     has more details and tips for committing properly.
   -->
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [thrift] fishy merged pull request #2209: THRIFT-5257: Fix Go THeaderTransport endOfFrame handling

[GitBox <gi...@apache.org>]

fishy merged pull request #2209:
URL: https://github.com/apache/thrift/pull/2209


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org