You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/04/18 17:19:16 UTC
[GitHub] [airflow] danfrankj opened a new pull request #8435: Fix
performance degradation when updating dagrun state
danfrankj opened a new pull request #8435: Fix performance degradation when updating dagrun state
URL: https://github.com/apache/airflow/pull/8435
The set comprehension `{t.task_id for t in dag.leaves}` in the conditional is re-evaluated every for each loop in the outer list comprehension resulting in an O(n^2) computation and significant slowdowns on large dags.
Introduced here: https://github.com/apache/airflow/commit/8f6ca5305d8f1ae068903972bc6ad8893693514c#diff-32aa8dbb910719ef24a39cab5d0f2a97R302
---
Make sure to mark the boxes below before creating PR: [x]
- [x ] Description above provides context of the change
- [not sure - please advise ] Unit tests coverage for changes (not needed for documentation changes)
- [x ] Commits follow "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)"
- [not sure - please advise ] Relevant documentation is updated including usage instructions.
- [ ] I will engage committers as explained in [Contribution Workflow Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
---
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
Read the [Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines) for more information.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] BasPH commented on issue #8435: Fix performance
degradation when updating dagrun state
Posted by GitBox <gi...@apache.org>.
BasPH commented on issue #8435: Fix performance degradation when updating dagrun state
URL: https://github.com/apache/airflow/pull/8435#issuecomment-615921944
@danfrankj out of interest: how big is your DAG?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] danfrankj commented on issue #8435: Fix performance
degradation when updating dagrun state
Posted by GitBox <gi...@apache.org>.
danfrankj commented on issue #8435: Fix performance degradation when updating dagrun state
URL: https://github.com/apache/airflow/pull/8435#issuecomment-615923750
@BasPH we're at ~5000 tasks so when we upgraded recently, it ground to a halt.
Also, pretty sure the CI failure here is unrelated?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] kaxil merged pull request #8435: Fix performance
degradation when updating dagrun state
Posted by GitBox <gi...@apache.org>.
kaxil merged pull request #8435: Fix performance degradation when updating dagrun state
URL: https://github.com/apache/airflow/pull/8435
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] danfrankj commented on issue #8435: Fix performance
degradation when updating dagrun state
Posted by GitBox <gi...@apache.org>.
danfrankj commented on issue #8435: Fix performance degradation when updating dagrun state
URL: https://github.com/apache/airflow/pull/8435#issuecomment-615923853
> Whoops, good catch
Catch credit goes to @cmlad :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services