You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@ratis.apache.org by GitBox <gi...@apache.org> on 2021/11/08 08:25:36 UTC

[GitHub] [ratis] guohao-rosicky opened a new pull request #527: RATIS-1424. NettyClientStreamRpc#workerGroup Can cause too much nioEv…

guohao-rosicky opened a new pull request #527:
URL: https://github.com/apache/ratis/pull/527


   Now, the setup of NettyClientStreamRpc#workerGroup causes too many nioEventLoopGroup threads.
   
   jira: https://issues.apache.org/jira/browse/RATIS-1424


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [ratis] szetszwo commented on pull request #527: RATIS-1424. NettyClientStreamRpc#workerGroup Can cause too much nioEv…

Posted by GitBox <gi...@apache.org>.

szetszwo commented on pull request #527:
URL: https://github.com/apache/ratis/pull/527#issuecomment-963798239


   BTW, as shown in https://issues.apache.org/jira/secure/attachment/13035853/WorkerGroupGetter.patch , I suggest changing the name of the new conf (raft.netty.dataStream.client.eventLoopThreads) added by https://issues.apache.org/jira/browse/RATIS-1421 in order to make the conf names consistent.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [ratis] szetszwo commented on a change in pull request #527: RATIS-1424. NettyClientStreamRpc#workerGroup Can cause too much nioEv…

Posted by GitBox <gi...@apache.org>.

szetszwo commented on a change in pull request #527:
URL: https://github.com/apache/ratis/pull/527#discussion_r745269032



##########
File path: ratis-client/src/main/java/org/apache/ratis/client/impl/RaftClientImpl.java
##########
@@ -40,6 +40,8 @@
 import org.apache.ratis.retry.RetryPolicy;
 import org.apache.ratis.thirdparty.com.google.common.cache.Cache;
 import org.apache.ratis.thirdparty.com.google.common.cache.CacheBuilder;
+import org.apache.ratis.thirdparty.io.netty.channel.EventLoopGroup;
+import org.apache.ratis.thirdparty.io.netty.channel.nio.NioEventLoopGroup;

Review comment:
       RaftClientImpl must not be specific to Netty so that we cannot import Netty here.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [ratis] guohao-rosicky commented on pull request #527: RATIS-1424. NettyClientStreamRpc#workerGroup Can cause too much nioEv…

Posted by GitBox <gi...@apache.org>.

guohao-rosicky commented on pull request #527:
URL: https://github.com/apache/ratis/pull/527#issuecomment-962991143


   hi @szetszwo @bshashikant , can you help review this patch?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [ratis] maobaolong commented on pull request #527: RATIS-1424. NettyClientStreamRpc#workerGroup Can cause too much nioEv…

Posted by GitBox <gi...@apache.org>.

maobaolong commented on pull request #527:
URL: https://github.com/apache/ratis/pull/527#issuecomment-964729485


   @szetszwo @guohao-rosicky Sorry for introduced style issue in #525 , the style issue was corrected in #528 , please take a look. Thanks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [ratis] guohao-rosicky commented on pull request #527: RATIS-1424. NettyClientStreamRpc#workerGroup Can cause too much nioEv…

Posted by GitBox <gi...@apache.org>.

guohao-rosicky commented on pull request #527:
URL: https://github.com/apache/ratis/pull/527#issuecomment-964710470


   @maobaolong ,there is a ratis shell checkstyle problem.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [ratis] guohao-rosicky commented on pull request #527: RATIS-1424. NettyClientStreamRpc#workerGroup Can cause too much nioEv…

Posted by GitBox <gi...@apache.org>.

guohao-rosicky commented on pull request #527:
URL: https://github.com/apache/ratis/pull/527#issuecomment-963861217


   Thanks @szetszwo ,let me modify that.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [ratis] szetszwo commented on pull request #527: RATIS-1424. NettyClientStreamRpc#workerGroup Can cause too much nioEv…

Posted by GitBox <gi...@apache.org>.

szetszwo commented on pull request #527:
URL: https://github.com/apache/ratis/pull/527#issuecomment-964722103


   > @maobaolong ,there is a ratis shell checkstyle problem.
   
   @guohao-rosicky , it was introduced by #525 .  Sorry that I merged the checkstyle warning.   I did not realize it would affect other builds.  Please ignore it for the moment.  #528 will fix it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [ratis] szetszwo merged pull request #527: RATIS-1424. NettyClientStreamRpc#workerGroup Can cause too much nioEv…

Posted by GitBox <gi...@apache.org>.

szetszwo merged pull request #527:
URL: https://github.com/apache/ratis/pull/527


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org