[GitHub] [spark] gatorsmile commented on a change in pull request #24742: [SPARK-27881][SQL] Support CAST (... FORMAT ) expression

[GitBox <gi...@apache.org>]

gatorsmile commented on a change in pull request #24742: [SPARK-27881][SQL] Support CAST (... FORMAT <pattern>) expression
URL: https://github.com/apache/spark/pull/24742#discussion_r289704417
 
 

 ##########
 File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Cast.scala
 ##########
 @@ -204,12 +206,17 @@ object Cast {
       > SELECT _FUNC_('10' as int);
        10
   """)
-case class Cast(child: Expression, dataType: DataType, timeZoneId: Option[String] = None)
+case class Cast(
+    child: Expression,
+    dataType: DataType,
+    timeZoneId: Option[String] = None,
+    format: Option[String] = None)
 
 Review comment:
   Based on this PR, it sounds like format is only applicable to datetime columns. Could you show us the full spec of this syntax? Is it applicable to numeric columns?
   
   This is a useful feature, but any mainstream SQL system supports this syntax?  
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org