svn_fs_commit_txn

[Ben Collins-Sussman <su...@newton.ch.collab.net>]

To Do:  svn_fs_commit_txn() probably needs to take a "log message"
argument.

If the system crashes after the commit succeeds, but before we call
svn_fs_revision_prop (log_msg), then we'd end up with a new revision
sans log message.  We need to make the "setting the log message" part
of the *same* db txn that executes within svn_fs_commit_txn --
probably by passing it right in.

Re: svn_fs_commit_txn

[Jim Blandy <ji...@zwingli.cygnus.com>]

Ben Collins-Sussman <su...@newton.ch.collab.net> writes:
> To Do:  svn_fs_commit_txn() probably needs to take a "log message"
> argument.
> 
> If the system crashes after the commit succeeds, but before we call
> svn_fs_revision_prop (log_msg), then we'd end up with a new revision
> sans log message.  We need to make the "setting the log message" part
> of the *same* db txn that executes within svn_fs_commit_txn --
> probably by passing it right in.

It would be more graceful, I think, to add properties to transactions,
just as we have properties for revisions.  When a transaction is
successfully committed, its properties would become the revision's
properties.