You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@kyuubi.apache.org by "dev-lpq (via GitHub)" <gi...@apache.org> on 2023/11/16 06:05:39 UTC
[PR] Avoid exposing client keystore and truststore passwords in the JDBC URL [kyuubi]
dev-lpq opened a new pull request, #5710:
URL: https://github.com/apache/kyuubi/pull/5710
# :mag: Description
## Issue References ๐
<!-- Append the issue number after #. If there is no issue for you to link create one or -->
<!-- If there are no issues to link, please provide details here. -->
This pull request fixes #5709
## Describe Your Solution ๐ง
Add a new JDBC URL property, storePasswordPath, which points to a local JCE keystore file storing password aliases.If the password exists, use password. If it does not exist, try to use storePasswordPath. All these passwords can be hidden from the JDBC URL when you protect them in a local JCEKS keystore file and pass the JCEKS file path to the URL.
Hadoop credential command with trustStorePassword and keyStorePassword aliases like below
hadoop credential create ssl.kyuubi.trustStorePassword -value mytruststorepassword -provider localjceks://file/client_trust_creds.jceks
more info: https://cwiki.apache.org/confluence/display/Hive/HiveServer2+Clients
## Types of changes :bookmark:
<!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->
- [ ] Bugfix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
## Test Plan ๐งช
#### Behavior Without This Pull Request :coffin:
#### Behavior With This Pull Request :tada:
#### Related Unit Tests
Local test passed
<img width="1093" alt="Screenshot 2023-11-16 at 10 43 03" src="https://github.com/apache/kyuubi/assets/43336508/3be87238-dfd7-4484-8945-e62780c43d9a">
---
# Checklists
## ๐ Author Self Checklist
<!--- Go over all the following points, and put an `x` in all the boxes that apply. -->
<!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! -->
- [ ] My code follows the [style guidelines](https://kyuubi.readthedocs.io/en/master/contributing/code/style.html) of this project
- [ ] I have performed a self-review
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my feature works
- [ ] New and existing unit tests pass locally with my changes
- [ ] This patch was not authored or co-authored using [Generative Tooling](https://www.apache.org/legal/generative-tooling.html)
## ๐ Committer Pre-Merge Checklist
- [ ] Pull request title is okay.
- [ ] No license issues.
- [ ] Milestone correctly set?
- [ ] Test coverage is ok
- [ ] Assignees are selected.
- [ ] Minimum number of approvals
- [ ] No changes are requested
**Be nice. Be informative.**
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
Re: [PR] Avoid exposing client keystore and truststore passwords in the JDBC URL [kyuubi]
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on code in PR #5710:
URL: https://github.com/apache/kyuubi/pull/5710#discussion_r1395851871
##########
kyuubi-hive-jdbc/pom.xml:
##########
@@ -86,6 +86,11 @@
<artifactId>hive-service-rpc</artifactId>
</dependency>
+ <dependency>
+ <groupId>org.apache.hadoop</groupId>
+ <artifactId>hadoop-common</artifactId>
Review Comment:
we spent significant efforts to make the Kyuubi JDBC driver become a Hadoop-free component, so that the consumers won't pull bunches of Hadoop transitive deps.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
Re: [PR] Avoid exposing client keystore and truststore passwords in the JDBC URL [kyuubi]
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on code in PR #5710:
URL: https://github.com/apache/kyuubi/pull/5710#discussion_r1395923056
##########
kyuubi-hive-jdbc/src/main/java/org/apache/kyuubi/jdbc/hive/Utils.java:
##########
@@ -570,4 +572,45 @@ public static synchronized String getVersion() {
}
return KYUUBI_CLIENT_VERSION;
}
+
+ /**
+ * Method to get the password from the credential provider
+ *
+ * @param providerPath provider path
+ * @param key alias name
+ * @return password
+ */
+ private static String getPasswordFromCredentialProvider(String providerPath, String key) {
+ try {
+ if (providerPath != null) {
+ Configuration conf = new Configuration();
+ conf.set("hadoop.security.credential.provider.path", providerPath);
+ char[] password = conf.getPassword(key);
+ if (password != null) {
+ return new String(password);
+ }
+ }
+ } catch (IOException exception) {
+ LOG.warn("Could not retrieve password for " + key, exception);
+ }
+ return null;
+ }
+
+ /**
+ * Method to get the password from the configuration map if available. Otherwise, get it from the
+ * credential provider
+ *
+ * @param confMap configuration map
+ * @param key param
+ * @return password
+ */
+ public static String getPassword(Map<String, String> confMap, String key) {
+ String password = confMap.get(key);
+ if (password == null) {
Review Comment:
Use reflection to check if CredentialProvider class present
```suggestion
if (password == null && hadoopCredentialProviderAvailable) {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
Re: [PR] [KYUUBI #5709] Avoid exposing client keystore and truststore passwords in the JDBC URL [kyuubi]
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 closed pull request #5710: [KYUUBI #5709] Avoid exposing client keystore and truststore passwords in the JDBC URL
URL: https://github.com/apache/kyuubi/pull/5710
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
Re: [PR] Avoid exposing client keystore and truststore passwords in the JDBC URL [kyuubi]
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on code in PR #5710:
URL: https://github.com/apache/kyuubi/pull/5710#discussion_r1395856156
##########
kyuubi-hive-jdbc/pom.xml:
##########
@@ -86,6 +86,11 @@
<artifactId>hive-service-rpc</artifactId>
</dependency>
+ <dependency>
+ <groupId>org.apache.hadoop</groupId>
+ <artifactId>hadoop-common</artifactId>
Review Comment:
to keep behavior with Hive JDBC, e.g. support Hadoop UGI authentication, we use reflection to check Hadoop classes available and for sequential method invocations
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
Re: [PR] Avoid exposing client keystore and truststore passwords in the JDBC URL [kyuubi]
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on code in PR #5710:
URL: https://github.com/apache/kyuubi/pull/5710#discussion_r1395917553
##########
kyuubi-hive-jdbc/src/main/java/org/apache/kyuubi/jdbc/hive/Utils.java:
##########
@@ -570,4 +572,45 @@ public static synchronized String getVersion() {
}
return KYUUBI_CLIENT_VERSION;
}
+
+ /**
+ * Method to get the password from the credential provider
+ *
+ * @param providerPath provider path
+ * @param key alias name
+ * @return password
+ */
+ private static String getPasswordFromCredentialProvider(String providerPath, String key) {
+ try {
+ if (providerPath != null) {
+ Configuration conf = new Configuration();
+ conf.set("hadoop.security.credential.provider.path", providerPath);
+ char[] password = conf.getPassword(key);
+ if (password != null) {
+ return new String(password);
+ }
+ }
+ } catch (IOException exception) {
+ LOG.warn("Could not retrieve password for " + key, exception);
+ }
+ return null;
+ }
+
+ /**
+ * Method to get the password from the configuration map if available. Otherwise, get it from the
+ * credential provider
Review Comment:
```suggestion
* Hadoop CredentialProvider if Hadoop classes are available
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
Re: [PR] Avoid exposing client keystore and truststore passwords in the JDBC URL [kyuubi]
Posted by "dev-lpq (via GitHub)" <gi...@apache.org>.
dev-lpq commented on code in PR #5710:
URL: https://github.com/apache/kyuubi/pull/5710#discussion_r1398106463
##########
kyuubi-hive-jdbc/pom.xml:
##########
@@ -86,6 +86,11 @@
<artifactId>hive-service-rpc</artifactId>
</dependency>
+ <dependency>
+ <groupId>org.apache.hadoop</groupId>
+ <artifactId>hadoop-common</artifactId>
Review Comment:
remove hadoop dependency, and use reflection to check Hadoop classes. Help review the PR, thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
Re: [PR] Avoid exposing client keystore and truststore passwords in the JDBC URL [kyuubi]
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on code in PR #5710:
URL: https://github.com/apache/kyuubi/pull/5710#discussion_r1395917553
##########
kyuubi-hive-jdbc/src/main/java/org/apache/kyuubi/jdbc/hive/Utils.java:
##########
@@ -570,4 +572,45 @@ public static synchronized String getVersion() {
}
return KYUUBI_CLIENT_VERSION;
}
+
+ /**
+ * Method to get the password from the credential provider
+ *
+ * @param providerPath provider path
+ * @param key alias name
+ * @return password
+ */
+ private static String getPasswordFromCredentialProvider(String providerPath, String key) {
+ try {
+ if (providerPath != null) {
+ Configuration conf = new Configuration();
+ conf.set("hadoop.security.credential.provider.path", providerPath);
+ char[] password = conf.getPassword(key);
+ if (password != null) {
+ return new String(password);
+ }
+ }
+ } catch (IOException exception) {
+ LOG.warn("Could not retrieve password for " + key, exception);
+ }
+ return null;
+ }
+
+ /**
+ * Method to get the password from the configuration map if available. Otherwise, get it from the
+ * credential provider
Review Comment:
```suggestion
* Hadoop CredentialProvider
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
Re: [PR] Avoid exposing client keystore and truststore passwords in the JDBC URL [kyuubi]
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on code in PR #5710:
URL: https://github.com/apache/kyuubi/pull/5710#discussion_r1395851871
##########
kyuubi-hive-jdbc/pom.xml:
##########
@@ -86,6 +86,11 @@
<artifactId>hive-service-rpc</artifactId>
</dependency>
+ <dependency>
+ <groupId>org.apache.hadoop</groupId>
+ <artifactId>hadoop-common</artifactId>
Review Comment:
we have spent significant efforts to make the Kyuubi JDBC driver become a Hadoop-free component, so that the downstream projects won't pull bunches of Hadoop transitive deps.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
Re: [PR] Avoid exposing client keystore and truststore passwords in the JDBC URL [kyuubi]
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on code in PR #5710:
URL: https://github.com/apache/kyuubi/pull/5710#discussion_r1395906519
##########
kyuubi-hive-jdbc/src/main/java/org/apache/kyuubi/jdbc/hive/JdbcConnectionParams.java:
##########
@@ -115,6 +115,7 @@ public class JdbcConnectionParams {
// Non-configurable params:
// Currently supports JKS keystore format
static final String SSL_TRUST_STORE_TYPE = "JKS";
+ static final String SSL_STORE_PASSWORD_PATH = "storePasswordPath";
Review Comment:
add an additional blank line before this variable definition
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
Re: [PR] Avoid exposing client keystore and truststore passwords in the JDBC URL [kyuubi]
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on code in PR #5710:
URL: https://github.com/apache/kyuubi/pull/5710#discussion_r1395895680
##########
kyuubi-hive-jdbc/src/main/java/org/apache/kyuubi/jdbc/hive/JdbcConnectionParams.java:
##########
@@ -115,6 +115,7 @@ public class JdbcConnectionParams {
// Non-configurable params:
// Currently supports JKS keystore format
static final String SSL_TRUST_STORE_TYPE = "JKS";
+ static final String SSL_STORE_PASSWORD_PATH = "storePasswordPath";
Review Comment:
I think it should be classified to the previous param group? just at the next line of SSL_KEY_STORE_PASSWORD
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
Re: [PR] [KYUUBI #5709] Avoid exposing client keystore and truststore passwords in the JDBC URL [kyuubi]
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on PR #5710:
URL: https://github.com/apache/kyuubi/pull/5710#issuecomment-1849004227
Thanks, merged to master
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
Re: [PR] Avoid exposing client keystore and truststore passwords in the JDBC URL [kyuubi]
Posted by "dev-lpq (via GitHub)" <gi...@apache.org>.
dev-lpq commented on code in PR #5710:
URL: https://github.com/apache/kyuubi/pull/5710#discussion_r1398106847
##########
kyuubi-hive-jdbc/src/main/java/org/apache/kyuubi/jdbc/hive/Utils.java:
##########
@@ -570,4 +572,45 @@ public static synchronized String getVersion() {
}
return KYUUBI_CLIENT_VERSION;
}
+
+ /**
+ * Method to get the password from the credential provider
+ *
+ * @param providerPath provider path
+ * @param key alias name
+ * @return password
+ */
+ private static String getPasswordFromCredentialProvider(String providerPath, String key) {
+ try {
+ if (providerPath != null) {
+ Configuration conf = new Configuration();
+ conf.set("hadoop.security.credential.provider.path", providerPath);
+ char[] password = conf.getPassword(key);
+ if (password != null) {
+ return new String(password);
+ }
+ }
+ } catch (IOException exception) {
+ LOG.warn("Could not retrieve password for " + key, exception);
+ }
+ return null;
+ }
+
+ /**
+ * Method to get the password from the configuration map if available. Otherwise, get it from the
+ * credential provider
+ *
+ * @param confMap configuration map
+ * @param key param
+ * @return password
+ */
+ public static String getPassword(Map<String, String> confMap, String key) {
+ String password = confMap.get(key);
+ if (password == null) {
Review Comment:
Added hadoopCredentialProviderAvailable check.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
Re: [PR] Avoid exposing client keystore and truststore passwords in the JDBC URL [kyuubi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #5710:
URL: https://github.com/apache/kyuubi/pull/5710#issuecomment-1817426251
## [Codecov](https://app.codecov.io/gh/apache/kyuubi/pull/5710?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
Attention: `42 lines` in your changes are missing coverage. Please review.
> Comparison is base [(`23f32cf`)](https://app.codecov.io/gh/apache/kyuubi/commit/23f32cf1512fe28839e2af450a5f733fa257cbeb?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 61.43% compared to head [(`1055dcc`)](https://app.codecov.io/gh/apache/kyuubi/pull/5710?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 61.23%.
> Report is 7 commits behind head on master.
| [Files](https://app.codecov.io/gh/apache/kyuubi/pull/5710?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...c/main/java/org/apache/kyuubi/jdbc/hive/Utils.java](https://app.codecov.io/gh/apache/kyuubi/pull/5710?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-a3l1dWJpLWhpdmUtamRiYy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3l1dWJpL2pkYmMvaGl2ZS9VdGlscy5qYXZh) | 0.00% | [34 Missing :warning: ](https://app.codecov.io/gh/apache/kyuubi/pull/5710?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../org/apache/kyuubi/jdbc/hive/KyuubiConnection.java](https://app.codecov.io/gh/apache/kyuubi/pull/5710?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-a3l1dWJpLWhpdmUtamRiYy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3l1dWJpL2pkYmMvaGl2ZS9LeXV1YmlDb25uZWN0aW9uLmphdmE=) | 0.00% | [8 Missing :warning: ](https://app.codecov.io/gh/apache/kyuubi/pull/5710?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #5710 +/- ##
============================================
- Coverage 61.43% 61.23% -0.21%
Complexity 23 23
============================================
Files 607 607
Lines 35735 35858 +123
Branches 4896 4917 +21
============================================
+ Hits 21955 21957 +2
- Misses 11402 11511 +109
- Partials 2378 2390 +12
```
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/kyuubi/pull/5710?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
Re: [PR] Avoid exposing client keystore and truststore passwords in the JDBC URL [kyuubi]
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on code in PR #5710:
URL: https://github.com/apache/kyuubi/pull/5710#discussion_r1395895680
##########
kyuubi-hive-jdbc/src/main/java/org/apache/kyuubi/jdbc/hive/JdbcConnectionParams.java:
##########
@@ -115,6 +115,7 @@ public class JdbcConnectionParams {
// Non-configurable params:
// Currently supports JKS keystore format
static final String SSL_TRUST_STORE_TYPE = "JKS";
+ static final String SSL_STORE_PASSWORD_PATH = "storePasswordPath";
Review Comment:
~~I think it should be classified to the previous param group? just at the next line of SSL_KEY_STORE_PASSWORD~~
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org