You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by "Todd Lipcon (JIRA)" <ji...@apache.org> on 2010/02/19 23:26:27 UTC
[jira] Created: (HADOOP-6578) Configuration should trim whitespace
around class name values
Configuration should trim whitespace around class name values
-------------------------------------------------------------
Key: HADOOP-6578
URL: https://issues.apache.org/jira/browse/HADOOP-6578
Project: Hadoop Common
Issue Type: Improvement
Components: conf
Affects Versions: 0.22.0
Reporter: Todd Lipcon
Priority: Minor
I've seen multiple users make an error where they've listed some whitespace around a class name (eg for configuring a scheduler). This results in a ClassNotFoundException which is very hard to debug, as you don't notice the whitespace in the exception! We should simply trim the whitespace in Configuration.getClass and Configuration.getClasses to avoid this class of user error.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-6578) Configuration should trim
whitespace around a lot of value types
Posted by "Todd Lipcon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12841610#action_12841610 ]
Todd Lipcon commented on HADOOP-6578:
-------------------------------------
- In getTrimmed(String), why not have this function just wrap the existing get() and trim the result, rather than duplicating its functionality?
- I'm not sure it makes sense to modify getClassByName. For external users calling this function directly, I don't think we should trim for them. For internal users, you've already covered those cases in .getClass() and .getClasses().
- Since it's easy to test, might as well throw a few more test cases in the existing TestConfiguration.
> Configuration should trim whitespace around a lot of value types
> ----------------------------------------------------------------
>
> Key: HADOOP-6578
> URL: https://issues.apache.org/jira/browse/HADOOP-6578
> Project: Hadoop Common
> Issue Type: Improvement
> Components: conf
> Affects Versions: 0.22.0
> Reporter: Todd Lipcon
> Assignee: Michele (@pirroh) Catasta
> Priority: Minor
> Attachments: HADOOP-6578.patch
>
>
> I've seen multiple users make an error where they've listed some whitespace around a class name (eg for configuring a scheduler). This results in a ClassNotFoundException which is very hard to debug, as you don't notice the whitespace in the exception! We should simply trim the whitespace in Configuration.getClass and Configuration.getClasses to avoid this class of user error.
> Similarly, we should trim in getInt, getLong, etc - anywhere that whitespace doesn't have semantic meaning we should be a little less strict on input.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-6578) Configuration should trim whitespace
around a lot of value types
Posted by "Michele (@pirroh) Catasta (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6578?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Michele (@pirroh) Catasta updated HADOOP-6578:
----------------------------------------------
Attachment: HADOOP-6578.patch
Fixed also the getters mentioned in the previous comment.
Slight refactoring - now in tune with getStrings() vs getTrimmedStrings().
> Configuration should trim whitespace around a lot of value types
> ----------------------------------------------------------------
>
> Key: HADOOP-6578
> URL: https://issues.apache.org/jira/browse/HADOOP-6578
> Project: Hadoop Common
> Issue Type: Improvement
> Components: conf
> Affects Versions: 0.22.0
> Reporter: Todd Lipcon
> Priority: Minor
> Attachments: HADOOP-6578.patch, HADOOP-6578.patch
>
>
> I've seen multiple users make an error where they've listed some whitespace around a class name (eg for configuring a scheduler). This results in a ClassNotFoundException which is very hard to debug, as you don't notice the whitespace in the exception! We should simply trim the whitespace in Configuration.getClass and Configuration.getClasses to avoid this class of user error.
> Similarly, we should trim in getInt, getLong, etc - anywhere that whitespace doesn't have semantic meaning we should be a little less strict on input.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-6578) Configuration should trim
whitespace around a lot of value types
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12844333#action_12844333 ]
Hadoop QA commented on HADOOP-6578:
-----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12438282/HADOOP-6578.patch
against trunk revision 921980.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 3 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/417/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/417/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/417/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/417/console
This message is automatically generated.
> Configuration should trim whitespace around a lot of value types
> ----------------------------------------------------------------
>
> Key: HADOOP-6578
> URL: https://issues.apache.org/jira/browse/HADOOP-6578
> Project: Hadoop Common
> Issue Type: Improvement
> Components: conf
> Affects Versions: 0.22.0
> Reporter: Todd Lipcon
> Assignee: Michele (@pirroh) Catasta
> Priority: Minor
> Attachments: HADOOP-6578.patch
>
>
> I've seen multiple users make an error where they've listed some whitespace around a class name (eg for configuring a scheduler). This results in a ClassNotFoundException which is very hard to debug, as you don't notice the whitespace in the exception! We should simply trim the whitespace in Configuration.getClass and Configuration.getClasses to avoid this class of user error.
> Similarly, we should trim in getInt, getLong, etc - anywhere that whitespace doesn't have semantic meaning we should be a little less strict on input.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (HADOOP-6578) Configuration should trim whitespace
around a lot of value types
Posted by "Michele (@pirroh) Catasta (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6578?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Michele (@pirroh) Catasta reassigned HADOOP-6578:
-------------------------------------------------
Assignee: Michele (@pirroh) Catasta
> Configuration should trim whitespace around a lot of value types
> ----------------------------------------------------------------
>
> Key: HADOOP-6578
> URL: https://issues.apache.org/jira/browse/HADOOP-6578
> Project: Hadoop Common
> Issue Type: Improvement
> Components: conf
> Affects Versions: 0.22.0
> Reporter: Todd Lipcon
> Assignee: Michele (@pirroh) Catasta
> Priority: Minor
> Attachments: HADOOP-6578.patch
>
>
> I've seen multiple users make an error where they've listed some whitespace around a class name (eg for configuring a scheduler). This results in a ClassNotFoundException which is very hard to debug, as you don't notice the whitespace in the exception! We should simply trim the whitespace in Configuration.getClass and Configuration.getClasses to avoid this class of user error.
> Similarly, we should trim in getInt, getLong, etc - anywhere that whitespace doesn't have semantic meaning we should be a little less strict on input.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-6578) Configuration should trim whitespace
around a lot of value types
Posted by "Todd Lipcon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6578?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Todd Lipcon updated HADOOP-6578:
--------------------------------
Status: Patch Available (was: Open)
Patch looks good for me. Submitting patch for Hudson to check
> Configuration should trim whitespace around a lot of value types
> ----------------------------------------------------------------
>
> Key: HADOOP-6578
> URL: https://issues.apache.org/jira/browse/HADOOP-6578
> Project: Hadoop Common
> Issue Type: Improvement
> Components: conf
> Affects Versions: 0.22.0
> Reporter: Todd Lipcon
> Assignee: Michele (@pirroh) Catasta
> Priority: Minor
> Attachments: HADOOP-6578.patch
>
>
> I've seen multiple users make an error where they've listed some whitespace around a class name (eg for configuring a scheduler). This results in a ClassNotFoundException which is very hard to debug, as you don't notice the whitespace in the exception! We should simply trim the whitespace in Configuration.getClass and Configuration.getClasses to avoid this class of user error.
> Similarly, we should trim in getInt, getLong, etc - anywhere that whitespace doesn't have semantic meaning we should be a little less strict on input.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-6578) Configuration should trim whitespace
around a lot of value types
Posted by "Michele (@pirroh) Catasta (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6578?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Michele (@pirroh) Catasta updated HADOOP-6578:
----------------------------------------------
Attachment: HADOOP-6578.patch
Tests were failing because of a missing null check in getTrimmed(). Attached a new patch and re-submitted to Hudson.
> Configuration should trim whitespace around a lot of value types
> ----------------------------------------------------------------
>
> Key: HADOOP-6578
> URL: https://issues.apache.org/jira/browse/HADOOP-6578
> Project: Hadoop Common
> Issue Type: Improvement
> Components: conf
> Affects Versions: 0.22.0
> Reporter: Todd Lipcon
> Assignee: Michele (@pirroh) Catasta
> Priority: Minor
> Attachments: HADOOP-6578.patch
>
>
> I've seen multiple users make an error where they've listed some whitespace around a class name (eg for configuring a scheduler). This results in a ClassNotFoundException which is very hard to debug, as you don't notice the whitespace in the exception! We should simply trim the whitespace in Configuration.getClass and Configuration.getClasses to avoid this class of user error.
> Similarly, we should trim in getInt, getLong, etc - anywhere that whitespace doesn't have semantic meaning we should be a little less strict on input.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-6578) Configuration should trim whitespace
around a lot of value types
Posted by "Michele (@pirroh) Catasta (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6578?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Michele (@pirroh) Catasta updated HADOOP-6578:
----------------------------------------------
Attachment: HADOOP-6578.patch
* done
* reverted to trunk
* added some tests - they should cover all the modified methods
> Configuration should trim whitespace around a lot of value types
> ----------------------------------------------------------------
>
> Key: HADOOP-6578
> URL: https://issues.apache.org/jira/browse/HADOOP-6578
> Project: Hadoop Common
> Issue Type: Improvement
> Components: conf
> Affects Versions: 0.22.0
> Reporter: Todd Lipcon
> Assignee: Michele (@pirroh) Catasta
> Priority: Minor
> Attachments: HADOOP-6578.patch
>
>
> I've seen multiple users make an error where they've listed some whitespace around a class name (eg for configuring a scheduler). This results in a ClassNotFoundException which is very hard to debug, as you don't notice the whitespace in the exception! We should simply trim the whitespace in Configuration.getClass and Configuration.getClasses to avoid this class of user error.
> Similarly, we should trim in getInt, getLong, etc - anywhere that whitespace doesn't have semantic meaning we should be a little less strict on input.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-6578) Configuration should trim whitespace
around a lot of value types
Posted by "Michele (@pirroh) Catasta (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6578?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Michele (@pirroh) Catasta updated HADOOP-6578:
----------------------------------------------
Attachment: (was: HADOOP-6578.patch)
> Configuration should trim whitespace around a lot of value types
> ----------------------------------------------------------------
>
> Key: HADOOP-6578
> URL: https://issues.apache.org/jira/browse/HADOOP-6578
> Project: Hadoop Common
> Issue Type: Improvement
> Components: conf
> Affects Versions: 0.22.0
> Reporter: Todd Lipcon
> Priority: Minor
> Attachments: HADOOP-6578.patch
>
>
> I've seen multiple users make an error where they've listed some whitespace around a class name (eg for configuring a scheduler). This results in a ClassNotFoundException which is very hard to debug, as you don't notice the whitespace in the exception! We should simply trim the whitespace in Configuration.getClass and Configuration.getClasses to avoid this class of user error.
> Similarly, we should trim in getInt, getLong, etc - anywhere that whitespace doesn't have semantic meaning we should be a little less strict on input.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-6578) Configuration should trim whitespace
around a lot of value types
Posted by "Michele (@pirroh) Catasta (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6578?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Michele (@pirroh) Catasta updated HADOOP-6578:
----------------------------------------------
Attachment: HADOOP-6578.patch
Attaching a trivial patch that takes care only of getClass* methods.
I took a look at all the getters in Configuration, and I think we can safely trim property name also for:
getBoolean(), getFloat(), getInt(), getLong(). Let me know if I should extend the patch to those (and even other) methods.
As per HADOOP-6133, I didn't add any test because: "No additional tests required - this code path is exercised widely by all parts of Hadoop".
> Configuration should trim whitespace around a lot of value types
> ----------------------------------------------------------------
>
> Key: HADOOP-6578
> URL: https://issues.apache.org/jira/browse/HADOOP-6578
> Project: Hadoop Common
> Issue Type: Improvement
> Components: conf
> Affects Versions: 0.22.0
> Reporter: Todd Lipcon
> Priority: Minor
> Attachments: HADOOP-6578.patch
>
>
> I've seen multiple users make an error where they've listed some whitespace around a class name (eg for configuring a scheduler). This results in a ClassNotFoundException which is very hard to debug, as you don't notice the whitespace in the exception! We should simply trim the whitespace in Configuration.getClass and Configuration.getClasses to avoid this class of user error.
> Similarly, we should trim in getInt, getLong, etc - anywhere that whitespace doesn't have semantic meaning we should be a little less strict on input.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-6578) Configuration should trim whitespace
around a lot of value types
Posted by "Michele (@pirroh) Catasta (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6578?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Michele (@pirroh) Catasta updated HADOOP-6578:
----------------------------------------------
Attachment: (was: HADOOP-6578.patch)
> Configuration should trim whitespace around a lot of value types
> ----------------------------------------------------------------
>
> Key: HADOOP-6578
> URL: https://issues.apache.org/jira/browse/HADOOP-6578
> Project: Hadoop Common
> Issue Type: Improvement
> Components: conf
> Affects Versions: 0.22.0
> Reporter: Todd Lipcon
> Assignee: Michele (@pirroh) Catasta
> Priority: Minor
> Attachments: HADOOP-6578.patch
>
>
> I've seen multiple users make an error where they've listed some whitespace around a class name (eg for configuring a scheduler). This results in a ClassNotFoundException which is very hard to debug, as you don't notice the whitespace in the exception! We should simply trim the whitespace in Configuration.getClass and Configuration.getClasses to avoid this class of user error.
> Similarly, we should trim in getInt, getLong, etc - anywhere that whitespace doesn't have semantic meaning we should be a little less strict on input.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-6578) Configuration should trim whitespace
around a lot of value types
Posted by "Todd Lipcon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6578?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Todd Lipcon updated HADOOP-6578:
--------------------------------
Description:
I've seen multiple users make an error where they've listed some whitespace around a class name (eg for configuring a scheduler). This results in a ClassNotFoundException which is very hard to debug, as you don't notice the whitespace in the exception! We should simply trim the whitespace in Configuration.getClass and Configuration.getClasses to avoid this class of user error.
Similarly, we should trim in getInt, getLong, etc - anywhere that whitespace doesn't have semantic meaning we should be a little less strict on input.
was:I've seen multiple users make an error where they've listed some whitespace around a class name (eg for configuring a scheduler). This results in a ClassNotFoundException which is very hard to debug, as you don't notice the whitespace in the exception! We should simply trim the whitespace in Configuration.getClass and Configuration.getClasses to avoid this class of user error.
Summary: Configuration should trim whitespace around a lot of value types (was: Configuration should trim whitespace around class name values)
> Configuration should trim whitespace around a lot of value types
> ----------------------------------------------------------------
>
> Key: HADOOP-6578
> URL: https://issues.apache.org/jira/browse/HADOOP-6578
> Project: Hadoop Common
> Issue Type: Improvement
> Components: conf
> Affects Versions: 0.22.0
> Reporter: Todd Lipcon
> Priority: Minor
>
> I've seen multiple users make an error where they've listed some whitespace around a class name (eg for configuring a scheduler). This results in a ClassNotFoundException which is very hard to debug, as you don't notice the whitespace in the exception! We should simply trim the whitespace in Configuration.getClass and Configuration.getClasses to avoid this class of user error.
> Similarly, we should trim in getInt, getLong, etc - anywhere that whitespace doesn't have semantic meaning we should be a little less strict on input.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-6578) Configuration should trim
whitespace around a lot of value types
Posted by "Michele Catasta (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12928724#action_12928724 ]
Michele Catasta commented on HADOOP-6578:
-----------------------------------------
Javadoc warnings are coming from the hadoop.security package.
ORing with the previous Hudson run in March, it should be a +1 overall.
> Configuration should trim whitespace around a lot of value types
> ----------------------------------------------------------------
>
> Key: HADOOP-6578
> URL: https://issues.apache.org/jira/browse/HADOOP-6578
> Project: Hadoop Common
> Issue Type: Improvement
> Components: conf
> Affects Versions: 0.22.0
> Reporter: Todd Lipcon
> Assignee: Michele Catasta
> Priority: Minor
> Attachments: HADOOP-6578.patch
>
>
> I've seen multiple users make an error where they've listed some whitespace around a class name (eg for configuring a scheduler). This results in a ClassNotFoundException which is very hard to debug, as you don't notice the whitespace in the exception! We should simply trim the whitespace in Configuration.getClass and Configuration.getClasses to avoid this class of user error.
> Similarly, we should trim in getInt, getLong, etc - anywhere that whitespace doesn't have semantic meaning we should be a little less strict on input.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-6578) Configuration should trim
whitespace around a lot of value types
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12928659#action_12928659 ]
Hadoop QA commented on HADOOP-6578:
-----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12438609/HADOOP-6578.patch
against trunk revision 1031422.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 3 new or modified tests.
-1 javadoc. The javadoc tool appears to have generated 1 warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
+1 system test framework. The patch passed system test framework compile.
Test results: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/61//testReport/
Findbugs warnings: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/61//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/61//console
This message is automatically generated.
> Configuration should trim whitespace around a lot of value types
> ----------------------------------------------------------------
>
> Key: HADOOP-6578
> URL: https://issues.apache.org/jira/browse/HADOOP-6578
> Project: Hadoop Common
> Issue Type: Improvement
> Components: conf
> Affects Versions: 0.22.0
> Reporter: Todd Lipcon
> Assignee: Michele Catasta
> Priority: Minor
> Attachments: HADOOP-6578.patch
>
>
> I've seen multiple users make an error where they've listed some whitespace around a class name (eg for configuring a scheduler). This results in a ClassNotFoundException which is very hard to debug, as you don't notice the whitespace in the exception! We should simply trim the whitespace in Configuration.getClass and Configuration.getClasses to avoid this class of user error.
> Similarly, we should trim in getInt, getLong, etc - anywhere that whitespace doesn't have semantic meaning we should be a little less strict on input.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-6578) Configuration should trim
whitespace around a lot of value types
Posted by "Michele (@pirroh) Catasta (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12845909#action_12845909 ]
Michele (@pirroh) Catasta commented on HADOOP-6578:
---------------------------------------------------
Only one test failed in the previous Hudson build, and it looks unrelated.
I run the full test suite in local with the patch applied to trunk and all tests passed.
> Configuration should trim whitespace around a lot of value types
> ----------------------------------------------------------------
>
> Key: HADOOP-6578
> URL: https://issues.apache.org/jira/browse/HADOOP-6578
> Project: Hadoop Common
> Issue Type: Improvement
> Components: conf
> Affects Versions: 0.22.0
> Reporter: Todd Lipcon
> Assignee: Michele (@pirroh) Catasta
> Priority: Minor
> Attachments: HADOOP-6578.patch
>
>
> I've seen multiple users make an error where they've listed some whitespace around a class name (eg for configuring a scheduler). This results in a ClassNotFoundException which is very hard to debug, as you don't notice the whitespace in the exception! We should simply trim the whitespace in Configuration.getClass and Configuration.getClasses to avoid this class of user error.
> Similarly, we should trim in getInt, getLong, etc - anywhere that whitespace doesn't have semantic meaning we should be a little less strict on input.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-6578) Configuration should trim whitespace
around a lot of value types
Posted by "Michele (@pirroh) Catasta (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6578?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Michele (@pirroh) Catasta updated HADOOP-6578:
----------------------------------------------
Status: Open (was: Patch Available)
> Configuration should trim whitespace around a lot of value types
> ----------------------------------------------------------------
>
> Key: HADOOP-6578
> URL: https://issues.apache.org/jira/browse/HADOOP-6578
> Project: Hadoop Common
> Issue Type: Improvement
> Components: conf
> Affects Versions: 0.22.0
> Reporter: Todd Lipcon
> Assignee: Michele (@pirroh) Catasta
> Priority: Minor
> Attachments: HADOOP-6578.patch
>
>
> I've seen multiple users make an error where they've listed some whitespace around a class name (eg for configuring a scheduler). This results in a ClassNotFoundException which is very hard to debug, as you don't notice the whitespace in the exception! We should simply trim the whitespace in Configuration.getClass and Configuration.getClasses to avoid this class of user error.
> Similarly, we should trim in getInt, getLong, etc - anywhere that whitespace doesn't have semantic meaning we should be a little less strict on input.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-6578) Configuration should trim whitespace
around a lot of value types
Posted by "Michele (@pirroh) Catasta (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6578?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Michele (@pirroh) Catasta updated HADOOP-6578:
----------------------------------------------
Attachment: (was: HADOOP-6578.patch)
> Configuration should trim whitespace around a lot of value types
> ----------------------------------------------------------------
>
> Key: HADOOP-6578
> URL: https://issues.apache.org/jira/browse/HADOOP-6578
> Project: Hadoop Common
> Issue Type: Improvement
> Components: conf
> Affects Versions: 0.22.0
> Reporter: Todd Lipcon
> Assignee: Michele (@pirroh) Catasta
> Priority: Minor
> Attachments: HADOOP-6578.patch
>
>
> I've seen multiple users make an error where they've listed some whitespace around a class name (eg for configuring a scheduler). This results in a ClassNotFoundException which is very hard to debug, as you don't notice the whitespace in the exception! We should simply trim the whitespace in Configuration.getClass and Configuration.getClasses to avoid this class of user error.
> Similarly, we should trim in getInt, getLong, etc - anywhere that whitespace doesn't have semantic meaning we should be a little less strict on input.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-6578) Configuration should trim whitespace
around a lot of value types
Posted by "Michele (@pirroh) Catasta (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6578?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Michele (@pirroh) Catasta updated HADOOP-6578:
----------------------------------------------
Status: Patch Available (was: Open)
> Configuration should trim whitespace around a lot of value types
> ----------------------------------------------------------------
>
> Key: HADOOP-6578
> URL: https://issues.apache.org/jira/browse/HADOOP-6578
> Project: Hadoop Common
> Issue Type: Improvement
> Components: conf
> Affects Versions: 0.22.0
> Reporter: Todd Lipcon
> Assignee: Michele (@pirroh) Catasta
> Priority: Minor
> Attachments: HADOOP-6578.patch
>
>
> I've seen multiple users make an error where they've listed some whitespace around a class name (eg for configuring a scheduler). This results in a ClassNotFoundException which is very hard to debug, as you don't notice the whitespace in the exception! We should simply trim the whitespace in Configuration.getClass and Configuration.getClasses to avoid this class of user error.
> Similarly, we should trim in getInt, getLong, etc - anywhere that whitespace doesn't have semantic meaning we should be a little less strict on input.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-6578) Configuration should trim
whitespace around a lot of value types
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12844482#action_12844482 ]
Hadoop QA commented on HADOOP-6578:
-----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12438609/HADOOP-6578.patch
against trunk revision 921980.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 3 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/418/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/418/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/418/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/418/console
This message is automatically generated.
> Configuration should trim whitespace around a lot of value types
> ----------------------------------------------------------------
>
> Key: HADOOP-6578
> URL: https://issues.apache.org/jira/browse/HADOOP-6578
> Project: Hadoop Common
> Issue Type: Improvement
> Components: conf
> Affects Versions: 0.22.0
> Reporter: Todd Lipcon
> Assignee: Michele (@pirroh) Catasta
> Priority: Minor
> Attachments: HADOOP-6578.patch
>
>
> I've seen multiple users make an error where they've listed some whitespace around a class name (eg for configuring a scheduler). This results in a ClassNotFoundException which is very hard to debug, as you don't notice the whitespace in the exception! We should simply trim the whitespace in Configuration.getClass and Configuration.getClasses to avoid this class of user error.
> Similarly, we should trim in getInt, getLong, etc - anywhere that whitespace doesn't have semantic meaning we should be a little less strict on input.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.