You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@atlas.apache.org by Sidharth Mishra <si...@gmail.com> on 2021/04/27 05:49:52 UTC
Review Request 73304: ATLAS-4261: Bulk Glossary Import Response and
Failed Error Message Improvements
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73304/
-----------------------------------------------------------
Review request for atlas, Ashutosh Mestry, Deep Singh, Radhika Kundam, and Sarath Subramanian.
Bugs: ATLAS-4261
https://issues.apache.org/jira/browse/ATLAS-4261
Repository: atlas
Description
-------
ATLAS-4261: Bulk Glossary Import Response and Failed Error Message Improvements
Diffs
-----
intg/src/main/java/org/apache/atlas/AtlasErrorCode.java 5ef62d310
intg/src/main/java/org/apache/atlas/model/glossary/AtlasGlossaryTerm.java 4fa1538df
repository/src/main/java/org/apache/atlas/glossary/GlossaryService.java b12c0b803
repository/src/main/java/org/apache/atlas/glossary/GlossaryTermUtils.java f5789a712
repository/src/test/java/org/apache/atlas/glossary/GlossaryServiceTest.java 27717c313
Diff: https://reviews.apache.org/r/73304/diff/1/
Testing
-------
Manually tested and example response looks like:
{
"failedImportInfoList": [
{
"parentObjectName": "Industry1",
"childObjectName": "Fact2",
"importStatus": "FAILED",
"remarks": "The provided Reference Fact14:Industry1 does not exist at Atlas referred at record with TermName : Fact2 and GlossaryName : Industry1\nThe provided Reference Horizontal14:Industry1 does not exist at Atlas referred at record with TermName : Fact2 and GlossaryName : Industry1\nThe provided Reference Horizontal14:Industry1 does not exist at Atlas referred at record with TermName : Fact2 and GlossaryName : Industry1\nThe provided Reference Fact14:Industry1 does not exist at Atlas referred at record with TermName : Fact2 and GlossaryName : Industry1"
},
{
"parentObjectName": "Industry1",
"childObjectName": "Vertical2",
"importStatus": "FAILED",
"remarks": "The provided Reference Horizontal14:Industry1 does not exist at Atlas referred at record with TermName : Vertical2 and GlossaryName : Industry1\nThe provided Reference Fact14:Industry1 does not exist at Atlas referred at record with TermName : Vertical2 and GlossaryName : Industry1\nThe provided Reference Fact14:Industry1 does not exist at Atlas referred at record with TermName : Vertical2 and GlossaryName : Industry1"
},
{
"parentObjectName": "Industry1",
"childObjectName": "Horizontal2",
"importStatus": "FAILED",
"remarks": "The provided Reference Vertical14:Industry1 does not exist at Atlas referred at record with TermName : Horizontal2 and GlossaryName : Industry1\nThe provided Reference Fact14:Industry1 does not exist at Atlas referred at record with TermName : Horizontal2 and GlossaryName : Industry1\nThe provided Reference Fact14:Industry1 does not exist at Atlas referred at record with TermName : Horizontal2 and GlossaryName : Industry1\nThe provided Reference Fact14:Industry1 does not exist at Atlas referred at record with TermName : Horizontal2 and GlossaryName : Industry1"
}
],
"successImportInfoList": [
{
"parentObjectName": "Industry1",
"childObjectName": "Fact2",
"importStatus": "SUCCESS",
"remarks": "Create Term without relations"
},
{
"parentObjectName": "Industry1",
"childObjectName": "Vertical2",
"importStatus": "SUCCESS",
"remarks": "Create Term without relations"
},
{
"parentObjectName": "Industry1",
"childObjectName": "Horizontal2",
"importStatus": "SUCCESS",
"remarks": "Create Term without relations"
},
{
"parentObjectName": "Industry1",
"childObjectName": "Fact2",
"importStatus": "SUCCESS",
"remarks": "Update Term Relation: {TRANSLATED_TERMS=[AtlasRelatedTermId{termGuid='362c17a2-3038-4a48-bfdc-37720ce6f80c', relationGuid='null', description='null', displayText='null', expression='null', steward='null', source='null', status=null}]}"
},
{
"parentObjectName": "Industry1",
"childObjectName": "Vertical2",
"importStatus": "SUCCESS",
"remarks": "Update Term Relation: {REPLACEMENT_TERMS=[AtlasRelatedTermId{termGuid='f1322f40-7a7f-4362-bbfd-e758d5df4e05', relationGuid='null', description='null', displayText='null', expression='null', steward='null', source='null', status=null}], TRANSLATION_TERMS=[AtlasRelatedTermId{termGuid='145657fd-3b04-4faa-bb63-c2177518f120', relationGuid='null', description='null', displayText='null', expression='null', steward='null', source='null', status=null}]}"
},
{
"parentObjectName": "Industry1",
"childObjectName": "Horizontal2",
"importStatus": "SUCCESS",
"remarks": "Update Term Relation: {TRANSLATION_TERMS=[AtlasRelatedTermId{termGuid='145657fd-3b04-4faa-bb63-c2177518f120', relationGuid='null', description='null', displayText='null', expression='null', steward='null', source='null', status=null}]}"
}
]
}
Thanks,
Sidharth Mishra
Re: Review Request 73304: ATLAS-4261: Bulk Glossary Import Response
and Failed Error Message Improvements
Posted by Sidharth Mishra <si...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73304/
-----------------------------------------------------------
(Updated April 27, 2021, 9:20 p.m.)
Review request for atlas, Ashutosh Mestry, Deep Singh, Radhika Kundam, and Sarath Subramanian.
Bugs: ATLAS-4261
https://issues.apache.org/jira/browse/ATLAS-4261
Repository: atlas
Description
-------
ATLAS-4261: Bulk Glossary Import Response and Failed Error Message Improvements
Diffs (updated)
-----
intg/src/main/java/org/apache/atlas/AtlasErrorCode.java 5ef62d310
intg/src/main/java/org/apache/atlas/model/glossary/AtlasGlossaryTerm.java 4fa1538df
repository/src/main/java/org/apache/atlas/glossary/GlossaryService.java b12c0b803
repository/src/main/java/org/apache/atlas/glossary/GlossaryTermUtils.java f5789a712
repository/src/test/java/org/apache/atlas/glossary/GlossaryServiceTest.java 27717c313
Diff: https://reviews.apache.org/r/73304/diff/3/
Changes: https://reviews.apache.org/r/73304/diff/2-3/
Testing
-------
Manually tested and example response looks like:
{
"failedImportInfoList": [
{
"parentObjectName": "Industry1",
"childObjectName": "Fact2",
"importStatus": "FAILED",
"remarks": "The provided Reference Fact14:Industry1 does not exist at Atlas referred at record with TermName : Fact2 and GlossaryName : Industry1\nThe provided Reference Horizontal14:Industry1 does not exist at Atlas referred at record with TermName : Fact2 and GlossaryName : Industry1\nThe provided Reference Horizontal14:Industry1 does not exist at Atlas referred at record with TermName : Fact2 and GlossaryName : Industry1\nThe provided Reference Fact14:Industry1 does not exist at Atlas referred at record with TermName : Fact2 and GlossaryName : Industry1"
},
{
"parentObjectName": "Industry1",
"childObjectName": "Vertical2",
"importStatus": "FAILED",
"remarks": "The provided Reference Horizontal14:Industry1 does not exist at Atlas referred at record with TermName : Vertical2 and GlossaryName : Industry1\nThe provided Reference Fact14:Industry1 does not exist at Atlas referred at record with TermName : Vertical2 and GlossaryName : Industry1\nThe provided Reference Fact14:Industry1 does not exist at Atlas referred at record with TermName : Vertical2 and GlossaryName : Industry1"
},
{
"parentObjectName": "Industry1",
"childObjectName": "Horizontal2",
"importStatus": "FAILED",
"remarks": "The provided Reference Vertical14:Industry1 does not exist at Atlas referred at record with TermName : Horizontal2 and GlossaryName : Industry1\nThe provided Reference Fact14:Industry1 does not exist at Atlas referred at record with TermName : Horizontal2 and GlossaryName : Industry1\nThe provided Reference Fact14:Industry1 does not exist at Atlas referred at record with TermName : Horizontal2 and GlossaryName : Industry1\nThe provided Reference Fact14:Industry1 does not exist at Atlas referred at record with TermName : Horizontal2 and GlossaryName : Industry1"
}
],
"successImportInfoList": [
{
"parentObjectName": "Industry1",
"childObjectName": "Fact2",
"importStatus": "SUCCESS",
"remarks": "Create Term without relations"
},
{
"parentObjectName": "Industry1",
"childObjectName": "Vertical2",
"importStatus": "SUCCESS",
"remarks": "Create Term without relations"
},
{
"parentObjectName": "Industry1",
"childObjectName": "Horizontal2",
"importStatus": "SUCCESS",
"remarks": "Create Term without relations"
},
{
"parentObjectName": "Industry1",
"childObjectName": "Fact2",
"importStatus": "SUCCESS",
"remarks": "Update Term Relation: {TRANSLATED_TERMS=[AtlasRelatedTermId{termGuid='362c17a2-3038-4a48-bfdc-37720ce6f80c', relationGuid='null', description='null', displayText='null', expression='null', steward='null', source='null', status=null}]}"
},
{
"parentObjectName": "Industry1",
"childObjectName": "Vertical2",
"importStatus": "SUCCESS",
"remarks": "Update Term Relation: {REPLACEMENT_TERMS=[AtlasRelatedTermId{termGuid='f1322f40-7a7f-4362-bbfd-e758d5df4e05', relationGuid='null', description='null', displayText='null', expression='null', steward='null', source='null', status=null}], TRANSLATION_TERMS=[AtlasRelatedTermId{termGuid='145657fd-3b04-4faa-bb63-c2177518f120', relationGuid='null', description='null', displayText='null', expression='null', steward='null', source='null', status=null}]}"
},
{
"parentObjectName": "Industry1",
"childObjectName": "Horizontal2",
"importStatus": "SUCCESS",
"remarks": "Update Term Relation: {TRANSLATION_TERMS=[AtlasRelatedTermId{termGuid='145657fd-3b04-4faa-bb63-c2177518f120', relationGuid='null', description='null', displayText='null', expression='null', steward='null', source='null', status=null}]}"
}
]
}
Thanks,
Sidharth Mishra
Re: Review Request 73304: ATLAS-4261: Bulk Glossary Import Response
and Failed Error Message Improvements
Posted by Sidharth Mishra <si...@gmail.com>.
> On April 28, 2021, 4:37 a.m., Sarath Subramanian wrote:
> > repository/src/main/java/org/apache/atlas/glossary/GlossaryService.java
> > Lines 1186 (patched)
> > <https://reviews.apache.org/r/73304/diff/5/?file=2249391#file2249391line1186>
> >
> > this method is unused, please review remove.
I have not uploaded the new patch which was using this. Now uploaded the new one
- Sidharth
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73304/#review222891
-----------------------------------------------------------
On April 28, 2021, 1:30 a.m., Sidharth Mishra wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73304/
> -----------------------------------------------------------
>
> (Updated April 28, 2021, 1:30 a.m.)
>
>
> Review request for atlas, Ashutosh Mestry, Deep Singh, Radhika Kundam, and Sarath Subramanian.
>
>
> Bugs: ATLAS-4261
> https://issues.apache.org/jira/browse/ATLAS-4261
>
>
> Repository: atlas
>
>
> Description
> -------
>
> ATLAS-4261: Bulk Glossary Import Response and Failed Error Message Improvements
>
>
> Diffs
> -----
>
> intg/src/main/java/org/apache/atlas/AtlasErrorCode.java 5ef62d310
> intg/src/main/java/org/apache/atlas/model/glossary/AtlasGlossaryTerm.java 4fa1538df
> repository/src/main/java/org/apache/atlas/glossary/GlossaryService.java b12c0b803
> repository/src/main/java/org/apache/atlas/glossary/GlossaryTermUtils.java f5789a712
>
>
> Diff: https://reviews.apache.org/r/73304/diff/5/
>
>
> Testing
> -------
>
> {
> "failedImportInfoList": [
> {
> "parentObjectName": "Auto",
> "childObjectName": "Price",
> "importStatus": "FAILED",
> "remarks": "Glossary term with qualifiedName Price@Auto already exists"
> },
> {
> "parentObjectName": "Auto",
> "childObjectName": "Brake",
> "importStatus": "FAILED",
> "remarks": "Glossary term with qualifiedName Brake@Auto already exists"
> }
> ],
> "successImportInfoList": [
> {
> "parentObjectName": "Banking4",
> "childObjectName": "Receivable",
> "importStatus": "SUCCESS",
> "remarks": "Receivable@Banking4"
> },
> {
> "parentObjectName": "Banking4",
> "childObjectName": "Payable",
> "importStatus": "SUCCESS",
> "remarks": "Payable@Banking4"
> },
> {
> "parentObjectName": "Auto4",
> "childObjectName": "Steering",
> "importStatus": "SUCCESS",
> "remarks": "Steering@Auto4"
> },
> {
> "parentObjectName": "Auto4",
> "childObjectName": "Paint",
> "importStatus": "SUCCESS",
> "remarks": "Paint@Auto4"
> }
> ]
> }
>
>
> Thanks,
>
> Sidharth Mishra
>
>
Re: Review Request 73304: ATLAS-4261: Bulk Glossary Import Response
and Failed Error Message Improvements
Posted by Sarath Subramanian <sa...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73304/#review222891
-----------------------------------------------------------
Fix it, then Ship it!
intg/src/main/java/org/apache/atlas/model/glossary/AtlasGlossaryTerm.java
Line 179 (original), 179 (patched)
<https://reviews.apache.org/r/73304/#comment312072>
on second thoughts, I think it is better to compute hasTerms only when 'seeAlso' is not empty:
if (CollectionUtils.isNotEmpty(seeAlso)) {
hasTerms = true;
}
repository/src/main/java/org/apache/atlas/glossary/GlossaryService.java
Lines 1186 (patched)
<https://reviews.apache.org/r/73304/#comment312073>
this method is unused, please review remove.
- Sarath Subramanian
On April 27, 2021, 6:30 p.m., Sidharth Mishra wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73304/
> -----------------------------------------------------------
>
> (Updated April 27, 2021, 6:30 p.m.)
>
>
> Review request for atlas, Ashutosh Mestry, Deep Singh, Radhika Kundam, and Sarath Subramanian.
>
>
> Bugs: ATLAS-4261
> https://issues.apache.org/jira/browse/ATLAS-4261
>
>
> Repository: atlas
>
>
> Description
> -------
>
> ATLAS-4261: Bulk Glossary Import Response and Failed Error Message Improvements
>
>
> Diffs
> -----
>
> intg/src/main/java/org/apache/atlas/AtlasErrorCode.java 5ef62d310
> intg/src/main/java/org/apache/atlas/model/glossary/AtlasGlossaryTerm.java 4fa1538df
> repository/src/main/java/org/apache/atlas/glossary/GlossaryService.java b12c0b803
> repository/src/main/java/org/apache/atlas/glossary/GlossaryTermUtils.java f5789a712
>
>
> Diff: https://reviews.apache.org/r/73304/diff/5/
>
>
> Testing
> -------
>
> {
> "failedImportInfoList": [
> {
> "parentObjectName": "Auto",
> "childObjectName": "Price",
> "importStatus": "FAILED",
> "remarks": "Glossary term with qualifiedName Price@Auto already exists"
> },
> {
> "parentObjectName": "Auto",
> "childObjectName": "Brake",
> "importStatus": "FAILED",
> "remarks": "Glossary term with qualifiedName Brake@Auto already exists"
> }
> ],
> "successImportInfoList": [
> {
> "parentObjectName": "Banking4",
> "childObjectName": "Receivable",
> "importStatus": "SUCCESS",
> "remarks": "Receivable@Banking4"
> },
> {
> "parentObjectName": "Banking4",
> "childObjectName": "Payable",
> "importStatus": "SUCCESS",
> "remarks": "Payable@Banking4"
> },
> {
> "parentObjectName": "Auto4",
> "childObjectName": "Steering",
> "importStatus": "SUCCESS",
> "remarks": "Steering@Auto4"
> },
> {
> "parentObjectName": "Auto4",
> "childObjectName": "Paint",
> "importStatus": "SUCCESS",
> "remarks": "Paint@Auto4"
> }
> ]
> }
>
>
> Thanks,
>
> Sidharth Mishra
>
>
Re: Review Request 73304: ATLAS-4261: Bulk Glossary Import Response
and Failed Error Message Improvements
Posted by Sidharth Mishra <si...@gmail.com>.
> On April 28, 2021, 1:02 p.m., Dharshana MK wrote:
> > Thanks Sidharth Mishra
> > We can obtain the qualified name from the input but getting the guid is tricky
> > Can we also pass the guid of the term created in the response "remarks"?
> >
> > GET /v2/glossary
> > POST /v2/glossary
> > POST /v2/glossary/categories
> > POST /v2/glossary/category
> > POST /v2/glossary/import
> > POST /v2/glossary/term
> > POST /v2/glossary/terms
> > DELETE /v2/glossary/{glossaryGuid}
> > GET /v2/glossary/{glossaryGuid}
> > PUT /v2/glossary/{glossaryGuid}
> > DELETE /v2/glossary/category/{categoryGuid}
> > GET /v2/glossary/category/{categoryGuid}
> > PUT /v2/glossary/category/{categoryGuid}
> > GET /v2/glossary/import/template
> > DELETE /v2/glossary/term/{termGuid}
> > GET /v2/glossary/term/{termGuid}
> > PUT /v2/glossary/term/{termGuid}
> > GET /v2/glossary/{glossaryGuid}/categories
> > GET /v2/glossary/{glossaryGuid}/detailed
> > PUT /v2/glossary/{glossaryGuid}/partial
> > GET /v2/glossary/{glossaryGuid}/terms
> > PUT /v2/glossary/category/{categoryGuid}/partial
> > GET /v2/glossary/category/{categoryGuid}/related
> > GET /v2/glossary/category/{categoryGuid}/terms
> > PUT /v2/glossary/term/{termGuid}/partial
> > DELETE /v2/glossary/terms/{termGuid}/assignedEntities
> > GET /v2/glossary/terms/{termGuid}/assignedEntities
> > POST /v2/glossary/terms/{termGuid}/assignedEntities
> > PUT /v2/glossary/terms/{termGuid}/assignedEntities
> > GET /v2/glossary/terms/{termGuid}/related
> > GET /v2/glossary/{glossaryGuid}/categories/headers
> > GET /v2/glossary/{glossaryGuid}/terms/headers
> >
> > From the available list of apis it will be difficult to get the complete details just by using the qualified name as we do not have a GET on /v2/glossary/terms
> >
> > But if the term guid is passed to GET /v2/glossary/term/{termGuid}, then we might get the complete details.
> >
> > Even customers might face this.
> >
> > Thoughts?
{
"failedImportInfoList": [
{
"parentObjectName": "Banking9",
"childObjectName": "Payable",
"importStatus": "FAILED",
"remarks": "Glossary term with qualifiedName Payable@Banking9 already exists"
},
{
"parentObjectName": "Auto9",
"childObjectName": "Steering",
"importStatus": "FAILED",
"remarks": "Glossary term with qualifiedName Steering@Auto9 already exists"
}
],
"successImportInfoList": [
{
"parentObjectName": "Banking16",
"childObjectName": "Receivable",
"importStatus": "SUCCESS",
"remarks": "{\"glossaryGuid\":\"f4f4c97a-7937-4639-8c3d-bdd46f0a6ed8\",\"qualifiedName\":\"Receivable@Banking16\"}"
}
]
}
- Sidharth
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73304/#review222895
-----------------------------------------------------------
On April 29, 2021, 1:35 a.m., Sidharth Mishra wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73304/
> -----------------------------------------------------------
>
> (Updated April 29, 2021, 1:35 a.m.)
>
>
> Review request for atlas, Ashutosh Mestry, Deep Singh, Radhika Kundam, and Sarath Subramanian.
>
>
> Bugs: ATLAS-4261
> https://issues.apache.org/jira/browse/ATLAS-4261
>
>
> Repository: atlas
>
>
> Description
> -------
>
> ATLAS-4261: Bulk Glossary Import Response and Failed Error Message Improvements
>
>
> Diffs
> -----
>
> intg/src/main/java/org/apache/atlas/AtlasErrorCode.java 5ef62d310
> intg/src/main/java/org/apache/atlas/model/glossary/AtlasGlossaryTerm.java 4fa1538df
> repository/src/main/java/org/apache/atlas/glossary/GlossaryService.java b12c0b803
> repository/src/main/java/org/apache/atlas/glossary/GlossaryTermUtils.java f5789a712
>
>
> Diff: https://reviews.apache.org/r/73304/diff/5/
>
>
> Testing
> -------
>
> {
> "failedImportInfoList": [
> {
> "parentObjectName": "Banking9",
> "childObjectName": "Payable",
> "importStatus": "FAILED",
> "remarks": "Glossary term with qualifiedName Payable@Banking9 already exists"
> },
> {
> "parentObjectName": "Auto9",
> "childObjectName": "Steering",
> "importStatus": "FAILED",
> "remarks": "Glossary term with qualifiedName Steering@Auto9 already exists"
> }
> ],
> "successImportInfoList": [
> {
> "parentObjectName": "Banking16",
> "childObjectName": "Receivable",
> "importStatus": "SUCCESS",
> "remarks": "{\"glossaryGuid\":\"f4f4c97a-7937-4639-8c3d-bdd46f0a6ed8\",\"qualifiedName\":\"Receivable@Banking16\"}"
> }
> ]
> }
>
>
> Thanks,
>
> Sidharth Mishra
>
>
Re: Review Request 73304: ATLAS-4261: Bulk Glossary Import Response
and Failed Error Message Improvements
Posted by Dharshana MK <dh...@gmail.com>.
> On April 28, 2021, 1:02 p.m., Dharshana MK wrote:
> > Thanks Sidharth Mishra
> > We can obtain the qualified name from the input but getting the guid is tricky
> > Can we also pass the guid of the term created in the response "remarks"?
> >
> > GET /v2/glossary
> > POST /v2/glossary
> > POST /v2/glossary/categories
> > POST /v2/glossary/category
> > POST /v2/glossary/import
> > POST /v2/glossary/term
> > POST /v2/glossary/terms
> > DELETE /v2/glossary/{glossaryGuid}
> > GET /v2/glossary/{glossaryGuid}
> > PUT /v2/glossary/{glossaryGuid}
> > DELETE /v2/glossary/category/{categoryGuid}
> > GET /v2/glossary/category/{categoryGuid}
> > PUT /v2/glossary/category/{categoryGuid}
> > GET /v2/glossary/import/template
> > DELETE /v2/glossary/term/{termGuid}
> > GET /v2/glossary/term/{termGuid}
> > PUT /v2/glossary/term/{termGuid}
> > GET /v2/glossary/{glossaryGuid}/categories
> > GET /v2/glossary/{glossaryGuid}/detailed
> > PUT /v2/glossary/{glossaryGuid}/partial
> > GET /v2/glossary/{glossaryGuid}/terms
> > PUT /v2/glossary/category/{categoryGuid}/partial
> > GET /v2/glossary/category/{categoryGuid}/related
> > GET /v2/glossary/category/{categoryGuid}/terms
> > PUT /v2/glossary/term/{termGuid}/partial
> > DELETE /v2/glossary/terms/{termGuid}/assignedEntities
> > GET /v2/glossary/terms/{termGuid}/assignedEntities
> > POST /v2/glossary/terms/{termGuid}/assignedEntities
> > PUT /v2/glossary/terms/{termGuid}/assignedEntities
> > GET /v2/glossary/terms/{termGuid}/related
> > GET /v2/glossary/{glossaryGuid}/categories/headers
> > GET /v2/glossary/{glossaryGuid}/terms/headers
> >
> > From the available list of apis it will be difficult to get the complete details just by using the qualified name as we do not have a GET on /v2/glossary/terms
> >
> > But if the term guid is passed to GET /v2/glossary/term/{termGuid}, then we might get the complete details.
> >
> > Even customers might face this.
> >
> > Thoughts?
>
> Sidharth Mishra wrote:
> {
> "failedImportInfoList": [
> {
> "parentObjectName": "Banking9",
> "childObjectName": "Payable",
> "importStatus": "FAILED",
> "remarks": "Glossary term with qualifiedName Payable@Banking9 already exists"
> },
> {
> "parentObjectName": "Auto9",
> "childObjectName": "Steering",
> "importStatus": "FAILED",
> "remarks": "Glossary term with qualifiedName Steering@Auto9 already exists"
> }
> ],
> "successImportInfoList": [
> {
> "parentObjectName": "Banking16",
> "childObjectName": "Receivable",
> "importStatus": "SUCCESS",
> "remarks": "{\"glossaryGuid\":\"f4f4c97a-7937-4639-8c3d-bdd46f0a6ed8\",\"qualifiedName\":\"Receivable@Banking16\"}"
> }
> ]
> }
you meant termGuid?
- Dharshana
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73304/#review222895
-----------------------------------------------------------
On April 29, 2021, 1:36 a.m., Sidharth Mishra wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73304/
> -----------------------------------------------------------
>
> (Updated April 29, 2021, 1:36 a.m.)
>
>
> Review request for atlas, Ashutosh Mestry, Deep Singh, Radhika Kundam, and Sarath Subramanian.
>
>
> Bugs: ATLAS-4261
> https://issues.apache.org/jira/browse/ATLAS-4261
>
>
> Repository: atlas
>
>
> Description
> -------
>
> ATLAS-4261: Bulk Glossary Import Response and Failed Error Message Improvements
>
>
> Diffs
> -----
>
> intg/src/main/java/org/apache/atlas/AtlasErrorCode.java 5ef62d310
> intg/src/main/java/org/apache/atlas/model/glossary/AtlasGlossaryTerm.java 4fa1538df
> intg/src/main/java/org/apache/atlas/model/glossary/AtlasGlossaryTermHeader.java PRE-CREATION
> repository/src/main/java/org/apache/atlas/glossary/GlossaryService.java b12c0b803
> repository/src/main/java/org/apache/atlas/glossary/GlossaryTermUtils.java f5789a712
>
>
> Diff: https://reviews.apache.org/r/73304/diff/6/
>
>
> Testing
> -------
>
> {
> "failedImportInfoList": [
> {
> "parentObjectName": "Banking9",
> "childObjectName": "Payable",
> "importStatus": "FAILED",
> "remarks": "Glossary term with qualifiedName Payable@Banking9 already exists"
> },
> {
> "parentObjectName": "Auto9",
> "childObjectName": "Steering",
> "importStatus": "FAILED",
> "remarks": "Glossary term with qualifiedName Steering@Auto9 already exists"
> }
> ],
> "successImportInfoList": [
> {
> "parentObjectName": "Banking16",
> "childObjectName": "Receivable",
> "importStatus": "SUCCESS",
> "remarks": "{\"glossaryGuid\":\"f4f4c97a-7937-4639-8c3d-bdd46f0a6ed8\",\"qualifiedName\":\"Receivable@Banking16\"}"
> }
> ]
> }
>
>
> Thanks,
>
> Sidharth Mishra
>
>
Re: Review Request 73304: ATLAS-4261: Bulk Glossary Import Response
and Failed Error Message Improvements
Posted by Dharshana MK <dh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73304/#review222895
-----------------------------------------------------------
Thanks Sidharth Mishra
We can obtain the qualified name from the input but getting the guid is tricky
Can we also pass the guid of the term created in the response "remarks"?
GET /v2/glossary
POST /v2/glossary
POST /v2/glossary/categories
POST /v2/glossary/category
POST /v2/glossary/import
POST /v2/glossary/term
POST /v2/glossary/terms
DELETE /v2/glossary/{glossaryGuid}
GET /v2/glossary/{glossaryGuid}
PUT /v2/glossary/{glossaryGuid}
DELETE /v2/glossary/category/{categoryGuid}
GET /v2/glossary/category/{categoryGuid}
PUT /v2/glossary/category/{categoryGuid}
GET /v2/glossary/import/template
DELETE /v2/glossary/term/{termGuid}
GET /v2/glossary/term/{termGuid}
PUT /v2/glossary/term/{termGuid}
GET /v2/glossary/{glossaryGuid}/categories
GET /v2/glossary/{glossaryGuid}/detailed
PUT /v2/glossary/{glossaryGuid}/partial
GET /v2/glossary/{glossaryGuid}/terms
PUT /v2/glossary/category/{categoryGuid}/partial
GET /v2/glossary/category/{categoryGuid}/related
GET /v2/glossary/category/{categoryGuid}/terms
PUT /v2/glossary/term/{termGuid}/partial
DELETE /v2/glossary/terms/{termGuid}/assignedEntities
GET /v2/glossary/terms/{termGuid}/assignedEntities
POST /v2/glossary/terms/{termGuid}/assignedEntities
PUT /v2/glossary/terms/{termGuid}/assignedEntities
GET /v2/glossary/terms/{termGuid}/related
GET /v2/glossary/{glossaryGuid}/categories/headers
GET /v2/glossary/{glossaryGuid}/terms/headers
From the available list of apis it will be difficult to get the complete details just by using the qualified name as we do not have a GET on /v2/glossary/terms
But if the term guid is passed to GET /v2/glossary/term/{termGuid}, then we might get the complete details.
Even customers might face this.
Thoughts?
- Dharshana MK
On April 28, 2021, 1:30 a.m., Sidharth Mishra wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73304/
> -----------------------------------------------------------
>
> (Updated April 28, 2021, 1:30 a.m.)
>
>
> Review request for atlas, Ashutosh Mestry, Deep Singh, Radhika Kundam, and Sarath Subramanian.
>
>
> Bugs: ATLAS-4261
> https://issues.apache.org/jira/browse/ATLAS-4261
>
>
> Repository: atlas
>
>
> Description
> -------
>
> ATLAS-4261: Bulk Glossary Import Response and Failed Error Message Improvements
>
>
> Diffs
> -----
>
> intg/src/main/java/org/apache/atlas/AtlasErrorCode.java 5ef62d310
> intg/src/main/java/org/apache/atlas/model/glossary/AtlasGlossaryTerm.java 4fa1538df
> repository/src/main/java/org/apache/atlas/glossary/GlossaryService.java b12c0b803
> repository/src/main/java/org/apache/atlas/glossary/GlossaryTermUtils.java f5789a712
>
>
> Diff: https://reviews.apache.org/r/73304/diff/5/
>
>
> Testing
> -------
>
> {
> "failedImportInfoList": [
> {
> "parentObjectName": "Auto",
> "childObjectName": "Price",
> "importStatus": "FAILED",
> "remarks": "Glossary term with qualifiedName Price@Auto already exists"
> },
> {
> "parentObjectName": "Auto",
> "childObjectName": "Brake",
> "importStatus": "FAILED",
> "remarks": "Glossary term with qualifiedName Brake@Auto already exists"
> }
> ],
> "successImportInfoList": [
> {
> "parentObjectName": "Banking4",
> "childObjectName": "Receivable",
> "importStatus": "SUCCESS",
> "remarks": "Receivable@Banking4"
> },
> {
> "parentObjectName": "Banking4",
> "childObjectName": "Payable",
> "importStatus": "SUCCESS",
> "remarks": "Payable@Banking4"
> },
> {
> "parentObjectName": "Auto4",
> "childObjectName": "Steering",
> "importStatus": "SUCCESS",
> "remarks": "Steering@Auto4"
> },
> {
> "parentObjectName": "Auto4",
> "childObjectName": "Paint",
> "importStatus": "SUCCESS",
> "remarks": "Paint@Auto4"
> }
> ]
> }
>
>
> Thanks,
>
> Sidharth Mishra
>
>
Re: Review Request 73304: ATLAS-4261: Bulk Glossary Import Response
and Failed Error Message Improvements
Posted by Dharshana MK <dh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73304/#review222894
-----------------------------------------------------------
Thanks Sidharth Mishra
We can obtain the qualified name from the input but getting the guild is tricky
Can we also pass the guid of the term created?
GET /v2/glossary
POST /v2/glossary
POST /v2/glossary/categories
POST /v2/glossary/category
POST /v2/glossary/import
POST /v2/glossary/term
POST /v2/glossary/terms
DELETE /v2/glossary/{glossaryGuid}
GET /v2/glossary/{glossaryGuid}
PUT /v2/glossary/{glossaryGuid}
DELETE /v2/glossary/category/{categoryGuid}
GET /v2/glossary/category/{categoryGuid}
PUT /v2/glossary/category/{categoryGuid}
GET /v2/glossary/import/template
DELETE /v2/glossary/term/{termGuid}
GET /v2/glossary/term/{termGuid}
PUT /v2/glossary/term/{termGuid}
GET /v2/glossary/{glossaryGuid}/categories
GET /v2/glossary/{glossaryGuid}/detailed
PUT /v2/glossary/{glossaryGuid}/partial
GET /v2/glossary/{glossaryGuid}/terms
PUT /v2/glossary/category/{categoryGuid}/partial
GET /v2/glossary/category/{categoryGuid}/related
GET /v2/glossary/category/{categoryGuid}/terms
PUT /v2/glossary/term/{termGuid}/partial
DELETE /v2/glossary/terms/{termGuid}/assignedEntities
GET /v2/glossary/terms/{termGuid}/assignedEntities
POST /v2/glossary/terms/{termGuid}/assignedEntities
PUT /v2/glossary/terms/{termGuid}/assignedEntities
GET /v2/glossary/terms/{termGuid}/related
GET /v2/glossary/{glossaryGuid}/categories/headers
GET /v2/glossary/{glossaryGuid}/terms/headers
From the available list of apis it will be difficult to get the complete details just by using the qualified name as we do not have a GET on /v2/glossary/terms
But if the term guid is passed to GET /v2/glossary/term/{termGuid}, then we might get the complete details.
Even customers might face this.
Thoughts?
- Dharshana MK
On April 28, 2021, 1:30 a.m., Sidharth Mishra wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73304/
> -----------------------------------------------------------
>
> (Updated April 28, 2021, 1:30 a.m.)
>
>
> Review request for atlas, Ashutosh Mestry, Deep Singh, Radhika Kundam, and Sarath Subramanian.
>
>
> Bugs: ATLAS-4261
> https://issues.apache.org/jira/browse/ATLAS-4261
>
>
> Repository: atlas
>
>
> Description
> -------
>
> ATLAS-4261: Bulk Glossary Import Response and Failed Error Message Improvements
>
>
> Diffs
> -----
>
> intg/src/main/java/org/apache/atlas/AtlasErrorCode.java 5ef62d310
> intg/src/main/java/org/apache/atlas/model/glossary/AtlasGlossaryTerm.java 4fa1538df
> repository/src/main/java/org/apache/atlas/glossary/GlossaryService.java b12c0b803
> repository/src/main/java/org/apache/atlas/glossary/GlossaryTermUtils.java f5789a712
>
>
> Diff: https://reviews.apache.org/r/73304/diff/5/
>
>
> Testing
> -------
>
> {
> "failedImportInfoList": [
> {
> "parentObjectName": "Auto",
> "childObjectName": "Price",
> "importStatus": "FAILED",
> "remarks": "Glossary term with qualifiedName Price@Auto already exists"
> },
> {
> "parentObjectName": "Auto",
> "childObjectName": "Brake",
> "importStatus": "FAILED",
> "remarks": "Glossary term with qualifiedName Brake@Auto already exists"
> }
> ],
> "successImportInfoList": [
> {
> "parentObjectName": "Banking4",
> "childObjectName": "Receivable",
> "importStatus": "SUCCESS",
> "remarks": "Receivable@Banking4"
> },
> {
> "parentObjectName": "Banking4",
> "childObjectName": "Payable",
> "importStatus": "SUCCESS",
> "remarks": "Payable@Banking4"
> },
> {
> "parentObjectName": "Auto4",
> "childObjectName": "Steering",
> "importStatus": "SUCCESS",
> "remarks": "Steering@Auto4"
> },
> {
> "parentObjectName": "Auto4",
> "childObjectName": "Paint",
> "importStatus": "SUCCESS",
> "remarks": "Paint@Auto4"
> }
> ]
> }
>
>
> Thanks,
>
> Sidharth Mishra
>
>
Re: Review Request 73304: ATLAS-4261: Bulk Glossary Import Response
and Failed Error Message Improvements
Posted by Dharshana MK <dh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73304/#review222904
-----------------------------------------------------------
Ship it!
Ship It!
- Dharshana MK
On April 29, 2021, 4:09 a.m., Sidharth Mishra wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73304/
> -----------------------------------------------------------
>
> (Updated April 29, 2021, 4:09 a.m.)
>
>
> Review request for atlas, Ashutosh Mestry, Deep Singh, Radhika Kundam, and Sarath Subramanian.
>
>
> Bugs: ATLAS-4261
> https://issues.apache.org/jira/browse/ATLAS-4261
>
>
> Repository: atlas
>
>
> Description
> -------
>
> ATLAS-4261: Bulk Glossary Import Response and Failed Error Message Improvements
>
>
> Diffs
> -----
>
> intg/src/main/java/org/apache/atlas/AtlasErrorCode.java 5ef62d310
> intg/src/main/java/org/apache/atlas/model/glossary/AtlasGlossaryTerm.java 4fa1538df
> intg/src/main/java/org/apache/atlas/model/glossary/AtlasGlossaryTermHeader.java PRE-CREATION
> repository/src/main/java/org/apache/atlas/glossary/GlossaryService.java b12c0b803
> repository/src/main/java/org/apache/atlas/glossary/GlossaryTermUtils.java f5789a712
>
>
> Diff: https://reviews.apache.org/r/73304/diff/7/
>
>
> Testing
> -------
>
> {
> "failedImportInfoList": [
> {
> "parentObjectName": "Banking9",
> "childObjectName": "Payable",
> "importStatus": "FAILED",
> "remarks": "Glossary term with qualifiedName Payable@Banking9 already exists"
> },
> {
> "parentObjectName": "Auto9",
> "childObjectName": "Steering",
> "importStatus": "FAILED",
> "remarks": "Glossary term with qualifiedName Steering@Auto9 already exists"
> }
> ],
> "successImportInfoList": [
> {
> "parentObjectName": "Banking16",
> "childObjectName": "Receivable",
> "importStatus": "SUCCESS",
> "remarks": "{\"termGuid\":\"f4f4c97a-7937-4639-8c3d-bdd46f0a6ed8\",\"qualifiedName\":\"Receivable@Banking16\"}"
> }
> ]
> }
>
>
> Thanks,
>
> Sidharth Mishra
>
>
Re: Review Request 73304: ATLAS-4261: Bulk Glossary Import Response
and Failed Error Message Improvements
Posted by Sidharth Mishra <si...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73304/
-----------------------------------------------------------
(Updated April 29, 2021, 4:09 a.m.)
Review request for atlas, Ashutosh Mestry, Deep Singh, Radhika Kundam, and Sarath Subramanian.
Bugs: ATLAS-4261
https://issues.apache.org/jira/browse/ATLAS-4261
Repository: atlas
Description
-------
ATLAS-4261: Bulk Glossary Import Response and Failed Error Message Improvements
Diffs
-----
intg/src/main/java/org/apache/atlas/AtlasErrorCode.java 5ef62d310
intg/src/main/java/org/apache/atlas/model/glossary/AtlasGlossaryTerm.java 4fa1538df
intg/src/main/java/org/apache/atlas/model/glossary/AtlasGlossaryTermHeader.java PRE-CREATION
repository/src/main/java/org/apache/atlas/glossary/GlossaryService.java b12c0b803
repository/src/main/java/org/apache/atlas/glossary/GlossaryTermUtils.java f5789a712
Diff: https://reviews.apache.org/r/73304/diff/7/
Testing (updated)
-------
{
"failedImportInfoList": [
{
"parentObjectName": "Banking9",
"childObjectName": "Payable",
"importStatus": "FAILED",
"remarks": "Glossary term with qualifiedName Payable@Banking9 already exists"
},
{
"parentObjectName": "Auto9",
"childObjectName": "Steering",
"importStatus": "FAILED",
"remarks": "Glossary term with qualifiedName Steering@Auto9 already exists"
}
],
"successImportInfoList": [
{
"parentObjectName": "Banking16",
"childObjectName": "Receivable",
"importStatus": "SUCCESS",
"remarks": "{\"termGuid\":\"f4f4c97a-7937-4639-8c3d-bdd46f0a6ed8\",\"qualifiedName\":\"Receivable@Banking16\"}"
}
]
}
Thanks,
Sidharth Mishra
Re: Review Request 73304: ATLAS-4261: Bulk Glossary Import Response
and Failed Error Message Improvements
Posted by Sidharth Mishra <si...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73304/
-----------------------------------------------------------
(Updated April 29, 2021, 4:07 a.m.)
Review request for atlas, Ashutosh Mestry, Deep Singh, Radhika Kundam, and Sarath Subramanian.
Bugs: ATLAS-4261
https://issues.apache.org/jira/browse/ATLAS-4261
Repository: atlas
Description
-------
ATLAS-4261: Bulk Glossary Import Response and Failed Error Message Improvements
Diffs (updated)
-----
intg/src/main/java/org/apache/atlas/AtlasErrorCode.java 5ef62d310
intg/src/main/java/org/apache/atlas/model/glossary/AtlasGlossaryTerm.java 4fa1538df
intg/src/main/java/org/apache/atlas/model/glossary/AtlasGlossaryTermHeader.java PRE-CREATION
repository/src/main/java/org/apache/atlas/glossary/GlossaryService.java b12c0b803
repository/src/main/java/org/apache/atlas/glossary/GlossaryTermUtils.java f5789a712
Diff: https://reviews.apache.org/r/73304/diff/7/
Changes: https://reviews.apache.org/r/73304/diff/6-7/
Testing
-------
{
"failedImportInfoList": [
{
"parentObjectName": "Banking9",
"childObjectName": "Payable",
"importStatus": "FAILED",
"remarks": "Glossary term with qualifiedName Payable@Banking9 already exists"
},
{
"parentObjectName": "Auto9",
"childObjectName": "Steering",
"importStatus": "FAILED",
"remarks": "Glossary term with qualifiedName Steering@Auto9 already exists"
}
],
"successImportInfoList": [
{
"parentObjectName": "Banking16",
"childObjectName": "Receivable",
"importStatus": "SUCCESS",
"remarks": "{\"glossaryGuid\":\"f4f4c97a-7937-4639-8c3d-bdd46f0a6ed8\",\"qualifiedName\":\"Receivable@Banking16\"}"
}
]
}
Thanks,
Sidharth Mishra
Re: Review Request 73304: ATLAS-4261: Bulk Glossary Import Response
and Failed Error Message Improvements
Posted by Dharshana MK <dh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73304/#review222901
-----------------------------------------------------------
Ship it!
Ship It!
- Dharshana MK
On April 29, 2021, 1:36 a.m., Sidharth Mishra wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73304/
> -----------------------------------------------------------
>
> (Updated April 29, 2021, 1:36 a.m.)
>
>
> Review request for atlas, Ashutosh Mestry, Deep Singh, Radhika Kundam, and Sarath Subramanian.
>
>
> Bugs: ATLAS-4261
> https://issues.apache.org/jira/browse/ATLAS-4261
>
>
> Repository: atlas
>
>
> Description
> -------
>
> ATLAS-4261: Bulk Glossary Import Response and Failed Error Message Improvements
>
>
> Diffs
> -----
>
> intg/src/main/java/org/apache/atlas/AtlasErrorCode.java 5ef62d310
> intg/src/main/java/org/apache/atlas/model/glossary/AtlasGlossaryTerm.java 4fa1538df
> intg/src/main/java/org/apache/atlas/model/glossary/AtlasGlossaryTermHeader.java PRE-CREATION
> repository/src/main/java/org/apache/atlas/glossary/GlossaryService.java b12c0b803
> repository/src/main/java/org/apache/atlas/glossary/GlossaryTermUtils.java f5789a712
>
>
> Diff: https://reviews.apache.org/r/73304/diff/6/
>
>
> Testing
> -------
>
> {
> "failedImportInfoList": [
> {
> "parentObjectName": "Banking9",
> "childObjectName": "Payable",
> "importStatus": "FAILED",
> "remarks": "Glossary term with qualifiedName Payable@Banking9 already exists"
> },
> {
> "parentObjectName": "Auto9",
> "childObjectName": "Steering",
> "importStatus": "FAILED",
> "remarks": "Glossary term with qualifiedName Steering@Auto9 already exists"
> }
> ],
> "successImportInfoList": [
> {
> "parentObjectName": "Banking16",
> "childObjectName": "Receivable",
> "importStatus": "SUCCESS",
> "remarks": "{\"glossaryGuid\":\"f4f4c97a-7937-4639-8c3d-bdd46f0a6ed8\",\"qualifiedName\":\"Receivable@Banking16\"}"
> }
> ]
> }
>
>
> Thanks,
>
> Sidharth Mishra
>
>
Re: Review Request 73304: ATLAS-4261: Bulk Glossary Import Response
and Failed Error Message Improvements
Posted by Sarath Subramanian <sa...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73304/#review222903
-----------------------------------------------------------
Ship it!
Ship It!
- Sarath Subramanian
On April 28, 2021, 6:36 p.m., Sidharth Mishra wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73304/
> -----------------------------------------------------------
>
> (Updated April 28, 2021, 6:36 p.m.)
>
>
> Review request for atlas, Ashutosh Mestry, Deep Singh, Radhika Kundam, and Sarath Subramanian.
>
>
> Bugs: ATLAS-4261
> https://issues.apache.org/jira/browse/ATLAS-4261
>
>
> Repository: atlas
>
>
> Description
> -------
>
> ATLAS-4261: Bulk Glossary Import Response and Failed Error Message Improvements
>
>
> Diffs
> -----
>
> intg/src/main/java/org/apache/atlas/AtlasErrorCode.java 5ef62d310
> intg/src/main/java/org/apache/atlas/model/glossary/AtlasGlossaryTerm.java 4fa1538df
> intg/src/main/java/org/apache/atlas/model/glossary/AtlasGlossaryTermHeader.java PRE-CREATION
> repository/src/main/java/org/apache/atlas/glossary/GlossaryService.java b12c0b803
> repository/src/main/java/org/apache/atlas/glossary/GlossaryTermUtils.java f5789a712
>
>
> Diff: https://reviews.apache.org/r/73304/diff/6/
>
>
> Testing
> -------
>
> {
> "failedImportInfoList": [
> {
> "parentObjectName": "Banking9",
> "childObjectName": "Payable",
> "importStatus": "FAILED",
> "remarks": "Glossary term with qualifiedName Payable@Banking9 already exists"
> },
> {
> "parentObjectName": "Auto9",
> "childObjectName": "Steering",
> "importStatus": "FAILED",
> "remarks": "Glossary term with qualifiedName Steering@Auto9 already exists"
> }
> ],
> "successImportInfoList": [
> {
> "parentObjectName": "Banking16",
> "childObjectName": "Receivable",
> "importStatus": "SUCCESS",
> "remarks": "{\"glossaryGuid\":\"f4f4c97a-7937-4639-8c3d-bdd46f0a6ed8\",\"qualifiedName\":\"Receivable@Banking16\"}"
> }
> ]
> }
>
>
> Thanks,
>
> Sidharth Mishra
>
>
Re: Review Request 73304: ATLAS-4261: Bulk Glossary Import Response
and Failed Error Message Improvements
Posted by Sidharth Mishra <si...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73304/
-----------------------------------------------------------
(Updated April 29, 2021, 1:36 a.m.)
Review request for atlas, Ashutosh Mestry, Deep Singh, Radhika Kundam, and Sarath Subramanian.
Bugs: ATLAS-4261
https://issues.apache.org/jira/browse/ATLAS-4261
Repository: atlas
Description
-------
ATLAS-4261: Bulk Glossary Import Response and Failed Error Message Improvements
Diffs (updated)
-----
intg/src/main/java/org/apache/atlas/AtlasErrorCode.java 5ef62d310
intg/src/main/java/org/apache/atlas/model/glossary/AtlasGlossaryTerm.java 4fa1538df
intg/src/main/java/org/apache/atlas/model/glossary/AtlasGlossaryTermHeader.java PRE-CREATION
repository/src/main/java/org/apache/atlas/glossary/GlossaryService.java b12c0b803
repository/src/main/java/org/apache/atlas/glossary/GlossaryTermUtils.java f5789a712
Diff: https://reviews.apache.org/r/73304/diff/6/
Changes: https://reviews.apache.org/r/73304/diff/5-6/
Testing
-------
{
"failedImportInfoList": [
{
"parentObjectName": "Banking9",
"childObjectName": "Payable",
"importStatus": "FAILED",
"remarks": "Glossary term with qualifiedName Payable@Banking9 already exists"
},
{
"parentObjectName": "Auto9",
"childObjectName": "Steering",
"importStatus": "FAILED",
"remarks": "Glossary term with qualifiedName Steering@Auto9 already exists"
}
],
"successImportInfoList": [
{
"parentObjectName": "Banking16",
"childObjectName": "Receivable",
"importStatus": "SUCCESS",
"remarks": "{\"glossaryGuid\":\"f4f4c97a-7937-4639-8c3d-bdd46f0a6ed8\",\"qualifiedName\":\"Receivable@Banking16\"}"
}
]
}
Thanks,
Sidharth Mishra
Re: Review Request 73304: ATLAS-4261: Bulk Glossary Import Response
and Failed Error Message Improvements
Posted by Sidharth Mishra <si...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73304/
-----------------------------------------------------------
(Updated April 29, 2021, 1:35 a.m.)
Review request for atlas, Ashutosh Mestry, Deep Singh, Radhika Kundam, and Sarath Subramanian.
Bugs: ATLAS-4261
https://issues.apache.org/jira/browse/ATLAS-4261
Repository: atlas
Description
-------
ATLAS-4261: Bulk Glossary Import Response and Failed Error Message Improvements
Diffs
-----
intg/src/main/java/org/apache/atlas/AtlasErrorCode.java 5ef62d310
intg/src/main/java/org/apache/atlas/model/glossary/AtlasGlossaryTerm.java 4fa1538df
repository/src/main/java/org/apache/atlas/glossary/GlossaryService.java b12c0b803
repository/src/main/java/org/apache/atlas/glossary/GlossaryTermUtils.java f5789a712
Diff: https://reviews.apache.org/r/73304/diff/5/
Testing (updated)
-------
{
"failedImportInfoList": [
{
"parentObjectName": "Banking9",
"childObjectName": "Payable",
"importStatus": "FAILED",
"remarks": "Glossary term with qualifiedName Payable@Banking9 already exists"
},
{
"parentObjectName": "Auto9",
"childObjectName": "Steering",
"importStatus": "FAILED",
"remarks": "Glossary term with qualifiedName Steering@Auto9 already exists"
}
],
"successImportInfoList": [
{
"parentObjectName": "Banking16",
"childObjectName": "Receivable",
"importStatus": "SUCCESS",
"remarks": "{\"glossaryGuid\":\"f4f4c97a-7937-4639-8c3d-bdd46f0a6ed8\",\"qualifiedName\":\"Receivable@Banking16\"}"
}
]
}
Thanks,
Sidharth Mishra
Re: Review Request 73304: ATLAS-4261: Bulk Glossary Import Response
and Failed Error Message Improvements
Posted by Sidharth Mishra <si...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73304/
-----------------------------------------------------------
(Updated April 28, 2021, 1:30 a.m.)
Review request for atlas, Ashutosh Mestry, Deep Singh, Radhika Kundam, and Sarath Subramanian.
Bugs: ATLAS-4261
https://issues.apache.org/jira/browse/ATLAS-4261
Repository: atlas
Description
-------
ATLAS-4261: Bulk Glossary Import Response and Failed Error Message Improvements
Diffs
-----
intg/src/main/java/org/apache/atlas/AtlasErrorCode.java 5ef62d310
intg/src/main/java/org/apache/atlas/model/glossary/AtlasGlossaryTerm.java 4fa1538df
repository/src/main/java/org/apache/atlas/glossary/GlossaryService.java b12c0b803
repository/src/main/java/org/apache/atlas/glossary/GlossaryTermUtils.java f5789a712
Diff: https://reviews.apache.org/r/73304/diff/5/
Testing (updated)
-------
{
"failedImportInfoList": [
{
"parentObjectName": "Auto",
"childObjectName": "Price",
"importStatus": "FAILED",
"remarks": "Glossary term with qualifiedName Price@Auto already exists"
},
{
"parentObjectName": "Auto",
"childObjectName": "Brake",
"importStatus": "FAILED",
"remarks": "Glossary term with qualifiedName Brake@Auto already exists"
}
],
"successImportInfoList": [
{
"parentObjectName": "Banking4",
"childObjectName": "Receivable",
"importStatus": "SUCCESS",
"remarks": "Receivable@Banking4"
},
{
"parentObjectName": "Banking4",
"childObjectName": "Payable",
"importStatus": "SUCCESS",
"remarks": "Payable@Banking4"
},
{
"parentObjectName": "Auto4",
"childObjectName": "Steering",
"importStatus": "SUCCESS",
"remarks": "Steering@Auto4"
},
{
"parentObjectName": "Auto4",
"childObjectName": "Paint",
"importStatus": "SUCCESS",
"remarks": "Paint@Auto4"
}
]
}
Thanks,
Sidharth Mishra
Re: Review Request 73304: ATLAS-4261: Bulk Glossary Import Response
and Failed Error Message Improvements
Posted by Sidharth Mishra <si...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73304/
-----------------------------------------------------------
(Updated April 28, 2021, 1:02 a.m.)
Review request for atlas, Ashutosh Mestry, Deep Singh, Radhika Kundam, and Sarath Subramanian.
Bugs: ATLAS-4261
https://issues.apache.org/jira/browse/ATLAS-4261
Repository: atlas
Description
-------
ATLAS-4261: Bulk Glossary Import Response and Failed Error Message Improvements
Diffs (updated)
-----
intg/src/main/java/org/apache/atlas/AtlasErrorCode.java 5ef62d310
intg/src/main/java/org/apache/atlas/model/glossary/AtlasGlossaryTerm.java 4fa1538df
repository/src/main/java/org/apache/atlas/glossary/GlossaryService.java b12c0b803
repository/src/main/java/org/apache/atlas/glossary/GlossaryTermUtils.java f5789a712
Diff: https://reviews.apache.org/r/73304/diff/5/
Changes: https://reviews.apache.org/r/73304/diff/4-5/
Testing
-------
Manually tested and example response looks like:
{
"failedImportInfoList": [
{
"parentObjectName": "Auto",
"childObjectName": "Price",
"importStatus": "FAILED",
"remarks": "Glossary term with qualifiedName Price@Auto already exists"
},
{
"parentObjectName": "Banking2",
"childObjectName": "Receivable",
"importStatus": "FAILED",
"remarks": "The provided Reference Test:Test does not exist at Atlas referred at record with TermName : Receivable and GlossaryName : Banking2"
},
{
"parentObjectName": "Auto",
"childObjectName": "Transmission",
"importStatus": "FAILED",
"remarks": "The provided Reference Test:Test does not exist at Atlas referred at record with TermName : Transmission and GlossaryName : Auto"
}
],
"successImportInfoList": [
{
"parentObjectName": "Banking2",
"childObjectName": "Receivable",
"importStatus": "SUCCESS",
"remarks": "{\"guid\":\"e9cb3e9e-2dc4-46af-99da-10bb975feb71\",\"qualifiedName\":\"Receivable@Banking2\",\"name\":\"Receivable\",\"shortDescription\":\"SD4\",\"longDescription\":\"LD4\",\"examples\":[\"EXAMPLE\"],\"abbreviation\":\"ABBREVIATION\",\"usage\":\"USAGE\",\"anchor\":{\"glossaryGuid\":\"db0a7768-d09e-4a47-9e4c-1c50ce93140e\",\"relationGuid\":\"b78a0728-3fff-4700-b3c7-47b48d500c3f\"}}"
},
{
"parentObjectName": "Banking2",
"childObjectName": "Payable",
"importStatus": "SUCCESS",
"remarks": "{\"guid\":\"1c3d26c6-5ce4-4008-8f73-4a69200930b9\",\"qualifiedName\":\"Payable@Banking2\",\"name\":\"Payable\",\"anchor\":{\"glossaryGuid\":\"db0a7768-d09e-4a47-9e4c-1c50ce93140e\",\"relationGuid\":\"6b47ae70-88f8-4dbe-b063-7db98f7a364f\"}}"
},
{
"parentObjectName": "Auto2",
"childObjectName": "Steering",
"importStatus": "SUCCESS",
"remarks": "{\"guid\":\"8614e449-f41c-4818-9baf-e89a21c2f652\",\"qualifiedName\":\"Steering@Auto2\",\"name\":\"Steering\",\"anchor\":{\"glossaryGuid\":\"5b044fc0-4577-4482-88cf-c9ade044100c\",\"relationGuid\":\"618ee0a3-722e-4dcb-b7f7-82bf9c1275b5\"}}"
},
{
"parentObjectName": "Auto2",
"childObjectName": "Transmission",
"importStatus": "SUCCESS",
"remarks": "{\"guid\":\"3a883c11-8fb5-4cf9-87bc-bd38c71dd6d9\",\"qualifiedName\":\"Transmission@Auto2\",\"name\":\"Transmission\",\"anchor\":{\"glossaryGuid\":\"5b044fc0-4577-4482-88cf-c9ade044100c\",\"relationGuid\":\"082df427-b73d-4c7c-9d24-879d7323d9dd\"}}"
}
]
}
Thanks,
Sidharth Mishra
Re: Review Request 73304: ATLAS-4261: Bulk Glossary Import Response
and Failed Error Message Improvements
Posted by Sidharth Mishra <si...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73304/
-----------------------------------------------------------
(Updated April 28, 2021, 12:01 a.m.)
Review request for atlas, Ashutosh Mestry, Deep Singh, Radhika Kundam, and Sarath Subramanian.
Bugs: ATLAS-4261
https://issues.apache.org/jira/browse/ATLAS-4261
Repository: atlas
Description
-------
ATLAS-4261: Bulk Glossary Import Response and Failed Error Message Improvements
Diffs (updated)
-----
intg/src/main/java/org/apache/atlas/AtlasErrorCode.java 5ef62d310
intg/src/main/java/org/apache/atlas/model/glossary/AtlasGlossaryTerm.java 4fa1538df
repository/src/main/java/org/apache/atlas/glossary/GlossaryService.java b12c0b803
repository/src/main/java/org/apache/atlas/glossary/GlossaryTermUtils.java f5789a712
repository/src/test/java/org/apache/atlas/glossary/GlossaryServiceTest.java 27717c313
Diff: https://reviews.apache.org/r/73304/diff/4/
Changes: https://reviews.apache.org/r/73304/diff/3-4/
Testing
-------
Manually tested and example response looks like:
{
"failedImportInfoList": [
{
"parentObjectName": "Auto",
"childObjectName": "Price",
"importStatus": "FAILED",
"remarks": "Glossary term with qualifiedName Price@Auto already exists"
},
{
"parentObjectName": "Banking2",
"childObjectName": "Receivable",
"importStatus": "FAILED",
"remarks": "The provided Reference Test:Test does not exist at Atlas referred at record with TermName : Receivable and GlossaryName : Banking2"
},
{
"parentObjectName": "Auto",
"childObjectName": "Transmission",
"importStatus": "FAILED",
"remarks": "The provided Reference Test:Test does not exist at Atlas referred at record with TermName : Transmission and GlossaryName : Auto"
}
],
"successImportInfoList": [
{
"parentObjectName": "Banking2",
"childObjectName": "Receivable",
"importStatus": "SUCCESS",
"remarks": "{\"guid\":\"e9cb3e9e-2dc4-46af-99da-10bb975feb71\",\"qualifiedName\":\"Receivable@Banking2\",\"name\":\"Receivable\",\"shortDescription\":\"SD4\",\"longDescription\":\"LD4\",\"examples\":[\"EXAMPLE\"],\"abbreviation\":\"ABBREVIATION\",\"usage\":\"USAGE\",\"anchor\":{\"glossaryGuid\":\"db0a7768-d09e-4a47-9e4c-1c50ce93140e\",\"relationGuid\":\"b78a0728-3fff-4700-b3c7-47b48d500c3f\"}}"
},
{
"parentObjectName": "Banking2",
"childObjectName": "Payable",
"importStatus": "SUCCESS",
"remarks": "{\"guid\":\"1c3d26c6-5ce4-4008-8f73-4a69200930b9\",\"qualifiedName\":\"Payable@Banking2\",\"name\":\"Payable\",\"anchor\":{\"glossaryGuid\":\"db0a7768-d09e-4a47-9e4c-1c50ce93140e\",\"relationGuid\":\"6b47ae70-88f8-4dbe-b063-7db98f7a364f\"}}"
},
{
"parentObjectName": "Auto2",
"childObjectName": "Steering",
"importStatus": "SUCCESS",
"remarks": "{\"guid\":\"8614e449-f41c-4818-9baf-e89a21c2f652\",\"qualifiedName\":\"Steering@Auto2\",\"name\":\"Steering\",\"anchor\":{\"glossaryGuid\":\"5b044fc0-4577-4482-88cf-c9ade044100c\",\"relationGuid\":\"618ee0a3-722e-4dcb-b7f7-82bf9c1275b5\"}}"
},
{
"parentObjectName": "Auto2",
"childObjectName": "Transmission",
"importStatus": "SUCCESS",
"remarks": "{\"guid\":\"3a883c11-8fb5-4cf9-87bc-bd38c71dd6d9\",\"qualifiedName\":\"Transmission@Auto2\",\"name\":\"Transmission\",\"anchor\":{\"glossaryGuid\":\"5b044fc0-4577-4482-88cf-c9ade044100c\",\"relationGuid\":\"082df427-b73d-4c7c-9d24-879d7323d9dd\"}}"
}
]
}
Thanks,
Sidharth Mishra
Re: Review Request 73304: ATLAS-4261: Bulk Glossary Import Response
and Failed Error Message Improvements
Posted by Sidharth Mishra <si...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73304/
-----------------------------------------------------------
(Updated April 28, 2021, midnight)
Review request for atlas, Ashutosh Mestry, Deep Singh, Radhika Kundam, and Sarath Subramanian.
Bugs: ATLAS-4261
https://issues.apache.org/jira/browse/ATLAS-4261
Repository: atlas
Description
-------
ATLAS-4261: Bulk Glossary Import Response and Failed Error Message Improvements
Diffs
-----
intg/src/main/java/org/apache/atlas/AtlasErrorCode.java 5ef62d310
intg/src/main/java/org/apache/atlas/model/glossary/AtlasGlossaryTerm.java 4fa1538df
repository/src/main/java/org/apache/atlas/glossary/GlossaryService.java b12c0b803
repository/src/main/java/org/apache/atlas/glossary/GlossaryTermUtils.java f5789a712
repository/src/test/java/org/apache/atlas/glossary/GlossaryServiceTest.java 27717c313
Diff: https://reviews.apache.org/r/73304/diff/3/
Testing (updated)
-------
Manually tested and example response looks like:
{
"failedImportInfoList": [
{
"parentObjectName": "Auto",
"childObjectName": "Price",
"importStatus": "FAILED",
"remarks": "Glossary term with qualifiedName Price@Auto already exists"
},
{
"parentObjectName": "Banking2",
"childObjectName": "Receivable",
"importStatus": "FAILED",
"remarks": "The provided Reference Test:Test does not exist at Atlas referred at record with TermName : Receivable and GlossaryName : Banking2"
},
{
"parentObjectName": "Auto",
"childObjectName": "Transmission",
"importStatus": "FAILED",
"remarks": "The provided Reference Test:Test does not exist at Atlas referred at record with TermName : Transmission and GlossaryName : Auto"
}
],
"successImportInfoList": [
{
"parentObjectName": "Banking2",
"childObjectName": "Receivable",
"importStatus": "SUCCESS",
"remarks": "{\"guid\":\"e9cb3e9e-2dc4-46af-99da-10bb975feb71\",\"qualifiedName\":\"Receivable@Banking2\",\"name\":\"Receivable\",\"shortDescription\":\"SD4\",\"longDescription\":\"LD4\",\"examples\":[\"EXAMPLE\"],\"abbreviation\":\"ABBREVIATION\",\"usage\":\"USAGE\",\"anchor\":{\"glossaryGuid\":\"db0a7768-d09e-4a47-9e4c-1c50ce93140e\",\"relationGuid\":\"b78a0728-3fff-4700-b3c7-47b48d500c3f\"}}"
},
{
"parentObjectName": "Banking2",
"childObjectName": "Payable",
"importStatus": "SUCCESS",
"remarks": "{\"guid\":\"1c3d26c6-5ce4-4008-8f73-4a69200930b9\",\"qualifiedName\":\"Payable@Banking2\",\"name\":\"Payable\",\"anchor\":{\"glossaryGuid\":\"db0a7768-d09e-4a47-9e4c-1c50ce93140e\",\"relationGuid\":\"6b47ae70-88f8-4dbe-b063-7db98f7a364f\"}}"
},
{
"parentObjectName": "Auto2",
"childObjectName": "Steering",
"importStatus": "SUCCESS",
"remarks": "{\"guid\":\"8614e449-f41c-4818-9baf-e89a21c2f652\",\"qualifiedName\":\"Steering@Auto2\",\"name\":\"Steering\",\"anchor\":{\"glossaryGuid\":\"5b044fc0-4577-4482-88cf-c9ade044100c\",\"relationGuid\":\"618ee0a3-722e-4dcb-b7f7-82bf9c1275b5\"}}"
},
{
"parentObjectName": "Auto2",
"childObjectName": "Transmission",
"importStatus": "SUCCESS",
"remarks": "{\"guid\":\"3a883c11-8fb5-4cf9-87bc-bd38c71dd6d9\",\"qualifiedName\":\"Transmission@Auto2\",\"name\":\"Transmission\",\"anchor\":{\"glossaryGuid\":\"5b044fc0-4577-4482-88cf-c9ade044100c\",\"relationGuid\":\"082df427-b73d-4c7c-9d24-879d7323d9dd\"}}"
}
]
}
Thanks,
Sidharth Mishra
Re: Review Request 73304: ATLAS-4261: Bulk Glossary Import Response
and Failed Error Message Improvements
Posted by Sarath Subramanian <sa...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73304/#review222887
-----------------------------------------------------------
intg/src/main/java/org/apache/atlas/model/glossary/AtlasGlossaryTerm.java
Line 179 (original), 180 (patched)
<https://reviews.apache.org/r/73304/#comment312070>
consider the following assignment to avoid 'if' check:
hasTerms = CollectionUtils.isNotEmpty(seeAlso);
please review other places as well.
repository/src/main/java/org/apache/atlas/glossary/GlossaryTermUtils.java
Line 646 (original), 666 (patched)
<https://reviews.apache.org/r/73304/#comment312071>
nit: add space between if and open braces:
else if (!populateRelations)
- Sarath Subramanian
On April 27, 2021, 2:20 p.m., Sidharth Mishra wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73304/
> -----------------------------------------------------------
>
> (Updated April 27, 2021, 2:20 p.m.)
>
>
> Review request for atlas, Ashutosh Mestry, Deep Singh, Radhika Kundam, and Sarath Subramanian.
>
>
> Bugs: ATLAS-4261
> https://issues.apache.org/jira/browse/ATLAS-4261
>
>
> Repository: atlas
>
>
> Description
> -------
>
> ATLAS-4261: Bulk Glossary Import Response and Failed Error Message Improvements
>
>
> Diffs
> -----
>
> intg/src/main/java/org/apache/atlas/AtlasErrorCode.java 5ef62d310
> intg/src/main/java/org/apache/atlas/model/glossary/AtlasGlossaryTerm.java 4fa1538df
> repository/src/main/java/org/apache/atlas/glossary/GlossaryService.java b12c0b803
> repository/src/main/java/org/apache/atlas/glossary/GlossaryTermUtils.java f5789a712
> repository/src/test/java/org/apache/atlas/glossary/GlossaryServiceTest.java 27717c313
>
>
> Diff: https://reviews.apache.org/r/73304/diff/3/
>
>
> Testing
> -------
>
> Manually tested and example response looks like:
>
> {
> "failedImportInfoList": [
> {
> "parentObjectName": "Industry1",
> "childObjectName": "Fact2",
> "importStatus": "FAILED",
> "remarks": "The provided Reference Fact14:Industry1 does not exist at Atlas referred at record with TermName : Fact2 and GlossaryName : Industry1\nThe provided Reference Horizontal14:Industry1 does not exist at Atlas referred at record with TermName : Fact2 and GlossaryName : Industry1\nThe provided Reference Horizontal14:Industry1 does not exist at Atlas referred at record with TermName : Fact2 and GlossaryName : Industry1\nThe provided Reference Fact14:Industry1 does not exist at Atlas referred at record with TermName : Fact2 and GlossaryName : Industry1"
> },
> {
> "parentObjectName": "Industry1",
> "childObjectName": "Vertical2",
> "importStatus": "FAILED",
> "remarks": "The provided Reference Horizontal14:Industry1 does not exist at Atlas referred at record with TermName : Vertical2 and GlossaryName : Industry1\nThe provided Reference Fact14:Industry1 does not exist at Atlas referred at record with TermName : Vertical2 and GlossaryName : Industry1\nThe provided Reference Fact14:Industry1 does not exist at Atlas referred at record with TermName : Vertical2 and GlossaryName : Industry1"
> },
> {
> "parentObjectName": "Industry1",
> "childObjectName": "Horizontal2",
> "importStatus": "FAILED",
> "remarks": "The provided Reference Vertical14:Industry1 does not exist at Atlas referred at record with TermName : Horizontal2 and GlossaryName : Industry1\nThe provided Reference Fact14:Industry1 does not exist at Atlas referred at record with TermName : Horizontal2 and GlossaryName : Industry1\nThe provided Reference Fact14:Industry1 does not exist at Atlas referred at record with TermName : Horizontal2 and GlossaryName : Industry1\nThe provided Reference Fact14:Industry1 does not exist at Atlas referred at record with TermName : Horizontal2 and GlossaryName : Industry1"
> }
> ],
> "successImportInfoList": [
> {
> "parentObjectName": "Industry1",
> "childObjectName": "Fact2",
> "importStatus": "SUCCESS",
> "remarks": "Create Term without relations"
> },
> {
> "parentObjectName": "Industry1",
> "childObjectName": "Vertical2",
> "importStatus": "SUCCESS",
> "remarks": "Create Term without relations"
> },
> {
> "parentObjectName": "Industry1",
> "childObjectName": "Horizontal2",
> "importStatus": "SUCCESS",
> "remarks": "Create Term without relations"
> },
> {
> "parentObjectName": "Industry1",
> "childObjectName": "Fact2",
> "importStatus": "SUCCESS",
> "remarks": "Update Term Relation: {TRANSLATED_TERMS=[AtlasRelatedTermId{termGuid='362c17a2-3038-4a48-bfdc-37720ce6f80c', relationGuid='null', description='null', displayText='null', expression='null', steward='null', source='null', status=null}]}"
> },
> {
> "parentObjectName": "Industry1",
> "childObjectName": "Vertical2",
> "importStatus": "SUCCESS",
> "remarks": "Update Term Relation: {REPLACEMENT_TERMS=[AtlasRelatedTermId{termGuid='f1322f40-7a7f-4362-bbfd-e758d5df4e05', relationGuid='null', description='null', displayText='null', expression='null', steward='null', source='null', status=null}], TRANSLATION_TERMS=[AtlasRelatedTermId{termGuid='145657fd-3b04-4faa-bb63-c2177518f120', relationGuid='null', description='null', displayText='null', expression='null', steward='null', source='null', status=null}]}"
> },
> {
> "parentObjectName": "Industry1",
> "childObjectName": "Horizontal2",
> "importStatus": "SUCCESS",
> "remarks": "Update Term Relation: {TRANSLATION_TERMS=[AtlasRelatedTermId{termGuid='145657fd-3b04-4faa-bb63-c2177518f120', relationGuid='null', description='null', displayText='null', expression='null', steward='null', source='null', status=null}]}"
> }
> ]
> }
>
>
> Thanks,
>
> Sidharth Mishra
>
>
Re: Review Request 73304: ATLAS-4261: Bulk Glossary Import Response
and Failed Error Message Improvements
Posted by Sidharth Mishra <si...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73304/
-----------------------------------------------------------
(Updated April 27, 2021, 9:20 p.m.)
Review request for atlas, Ashutosh Mestry, Deep Singh, Radhika Kundam, and Sarath Subramanian.
Bugs: ATLAS-4261
https://issues.apache.org/jira/browse/ATLAS-4261
Repository: atlas
Description
-------
ATLAS-4261: Bulk Glossary Import Response and Failed Error Message Improvements
Diffs (updated)
-----
intg/src/main/java/org/apache/atlas/AtlasErrorCode.java 5ef62d310
intg/src/main/java/org/apache/atlas/model/glossary/AtlasGlossaryTerm.java 4fa1538df
repository/src/main/java/org/apache/atlas/glossary/GlossaryService.java b12c0b803
repository/src/main/java/org/apache/atlas/glossary/GlossaryTermUtils.java f5789a712
repository/src/test/java/org/apache/atlas/glossary/GlossaryServiceTest.java 27717c313
Diff: https://reviews.apache.org/r/73304/diff/3/
Changes: https://reviews.apache.org/r/73304/diff/2-3/
Testing
-------
Manually tested and example response looks like:
{
"failedImportInfoList": [
{
"parentObjectName": "Industry1",
"childObjectName": "Fact2",
"importStatus": "FAILED",
"remarks": "The provided Reference Fact14:Industry1 does not exist at Atlas referred at record with TermName : Fact2 and GlossaryName : Industry1\nThe provided Reference Horizontal14:Industry1 does not exist at Atlas referred at record with TermName : Fact2 and GlossaryName : Industry1\nThe provided Reference Horizontal14:Industry1 does not exist at Atlas referred at record with TermName : Fact2 and GlossaryName : Industry1\nThe provided Reference Fact14:Industry1 does not exist at Atlas referred at record with TermName : Fact2 and GlossaryName : Industry1"
},
{
"parentObjectName": "Industry1",
"childObjectName": "Vertical2",
"importStatus": "FAILED",
"remarks": "The provided Reference Horizontal14:Industry1 does not exist at Atlas referred at record with TermName : Vertical2 and GlossaryName : Industry1\nThe provided Reference Fact14:Industry1 does not exist at Atlas referred at record with TermName : Vertical2 and GlossaryName : Industry1\nThe provided Reference Fact14:Industry1 does not exist at Atlas referred at record with TermName : Vertical2 and GlossaryName : Industry1"
},
{
"parentObjectName": "Industry1",
"childObjectName": "Horizontal2",
"importStatus": "FAILED",
"remarks": "The provided Reference Vertical14:Industry1 does not exist at Atlas referred at record with TermName : Horizontal2 and GlossaryName : Industry1\nThe provided Reference Fact14:Industry1 does not exist at Atlas referred at record with TermName : Horizontal2 and GlossaryName : Industry1\nThe provided Reference Fact14:Industry1 does not exist at Atlas referred at record with TermName : Horizontal2 and GlossaryName : Industry1\nThe provided Reference Fact14:Industry1 does not exist at Atlas referred at record with TermName : Horizontal2 and GlossaryName : Industry1"
}
],
"successImportInfoList": [
{
"parentObjectName": "Industry1",
"childObjectName": "Fact2",
"importStatus": "SUCCESS",
"remarks": "Create Term without relations"
},
{
"parentObjectName": "Industry1",
"childObjectName": "Vertical2",
"importStatus": "SUCCESS",
"remarks": "Create Term without relations"
},
{
"parentObjectName": "Industry1",
"childObjectName": "Horizontal2",
"importStatus": "SUCCESS",
"remarks": "Create Term without relations"
},
{
"parentObjectName": "Industry1",
"childObjectName": "Fact2",
"importStatus": "SUCCESS",
"remarks": "Update Term Relation: {TRANSLATED_TERMS=[AtlasRelatedTermId{termGuid='362c17a2-3038-4a48-bfdc-37720ce6f80c', relationGuid='null', description='null', displayText='null', expression='null', steward='null', source='null', status=null}]}"
},
{
"parentObjectName": "Industry1",
"childObjectName": "Vertical2",
"importStatus": "SUCCESS",
"remarks": "Update Term Relation: {REPLACEMENT_TERMS=[AtlasRelatedTermId{termGuid='f1322f40-7a7f-4362-bbfd-e758d5df4e05', relationGuid='null', description='null', displayText='null', expression='null', steward='null', source='null', status=null}], TRANSLATION_TERMS=[AtlasRelatedTermId{termGuid='145657fd-3b04-4faa-bb63-c2177518f120', relationGuid='null', description='null', displayText='null', expression='null', steward='null', source='null', status=null}]}"
},
{
"parentObjectName": "Industry1",
"childObjectName": "Horizontal2",
"importStatus": "SUCCESS",
"remarks": "Update Term Relation: {TRANSLATION_TERMS=[AtlasRelatedTermId{termGuid='145657fd-3b04-4faa-bb63-c2177518f120', relationGuid='null', description='null', displayText='null', expression='null', steward='null', source='null', status=null}]}"
}
]
}
Thanks,
Sidharth Mishra
Re: Review Request 73304: ATLAS-4261: Bulk Glossary Import Response
and Failed Error Message Improvements
Posted by Sidharth Mishra <si...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73304/
-----------------------------------------------------------
(Updated April 27, 2021, 9:06 p.m.)
Review request for atlas, Ashutosh Mestry, Deep Singh, Radhika Kundam, and Sarath Subramanian.
Bugs: ATLAS-4261
https://issues.apache.org/jira/browse/ATLAS-4261
Repository: atlas
Description
-------
ATLAS-4261: Bulk Glossary Import Response and Failed Error Message Improvements
Diffs (updated)
-----
intg/src/main/java/org/apache/atlas/AtlasErrorCode.java 5ef62d310
intg/src/main/java/org/apache/atlas/model/glossary/AtlasGlossaryTerm.java 4fa1538df
repository/src/main/java/org/apache/atlas/glossary/GlossaryService.java b12c0b803
repository/src/main/java/org/apache/atlas/glossary/GlossaryTermUtils.java f5789a712
repository/src/test/java/org/apache/atlas/glossary/GlossaryServiceTest.java 27717c313
Diff: https://reviews.apache.org/r/73304/diff/2/
Changes: https://reviews.apache.org/r/73304/diff/1-2/
Testing
-------
Manually tested and example response looks like:
{
"failedImportInfoList": [
{
"parentObjectName": "Industry1",
"childObjectName": "Fact2",
"importStatus": "FAILED",
"remarks": "The provided Reference Fact14:Industry1 does not exist at Atlas referred at record with TermName : Fact2 and GlossaryName : Industry1\nThe provided Reference Horizontal14:Industry1 does not exist at Atlas referred at record with TermName : Fact2 and GlossaryName : Industry1\nThe provided Reference Horizontal14:Industry1 does not exist at Atlas referred at record with TermName : Fact2 and GlossaryName : Industry1\nThe provided Reference Fact14:Industry1 does not exist at Atlas referred at record with TermName : Fact2 and GlossaryName : Industry1"
},
{
"parentObjectName": "Industry1",
"childObjectName": "Vertical2",
"importStatus": "FAILED",
"remarks": "The provided Reference Horizontal14:Industry1 does not exist at Atlas referred at record with TermName : Vertical2 and GlossaryName : Industry1\nThe provided Reference Fact14:Industry1 does not exist at Atlas referred at record with TermName : Vertical2 and GlossaryName : Industry1\nThe provided Reference Fact14:Industry1 does not exist at Atlas referred at record with TermName : Vertical2 and GlossaryName : Industry1"
},
{
"parentObjectName": "Industry1",
"childObjectName": "Horizontal2",
"importStatus": "FAILED",
"remarks": "The provided Reference Vertical14:Industry1 does not exist at Atlas referred at record with TermName : Horizontal2 and GlossaryName : Industry1\nThe provided Reference Fact14:Industry1 does not exist at Atlas referred at record with TermName : Horizontal2 and GlossaryName : Industry1\nThe provided Reference Fact14:Industry1 does not exist at Atlas referred at record with TermName : Horizontal2 and GlossaryName : Industry1\nThe provided Reference Fact14:Industry1 does not exist at Atlas referred at record with TermName : Horizontal2 and GlossaryName : Industry1"
}
],
"successImportInfoList": [
{
"parentObjectName": "Industry1",
"childObjectName": "Fact2",
"importStatus": "SUCCESS",
"remarks": "Create Term without relations"
},
{
"parentObjectName": "Industry1",
"childObjectName": "Vertical2",
"importStatus": "SUCCESS",
"remarks": "Create Term without relations"
},
{
"parentObjectName": "Industry1",
"childObjectName": "Horizontal2",
"importStatus": "SUCCESS",
"remarks": "Create Term without relations"
},
{
"parentObjectName": "Industry1",
"childObjectName": "Fact2",
"importStatus": "SUCCESS",
"remarks": "Update Term Relation: {TRANSLATED_TERMS=[AtlasRelatedTermId{termGuid='362c17a2-3038-4a48-bfdc-37720ce6f80c', relationGuid='null', description='null', displayText='null', expression='null', steward='null', source='null', status=null}]}"
},
{
"parentObjectName": "Industry1",
"childObjectName": "Vertical2",
"importStatus": "SUCCESS",
"remarks": "Update Term Relation: {REPLACEMENT_TERMS=[AtlasRelatedTermId{termGuid='f1322f40-7a7f-4362-bbfd-e758d5df4e05', relationGuid='null', description='null', displayText='null', expression='null', steward='null', source='null', status=null}], TRANSLATION_TERMS=[AtlasRelatedTermId{termGuid='145657fd-3b04-4faa-bb63-c2177518f120', relationGuid='null', description='null', displayText='null', expression='null', steward='null', source='null', status=null}]}"
},
{
"parentObjectName": "Industry1",
"childObjectName": "Horizontal2",
"importStatus": "SUCCESS",
"remarks": "Update Term Relation: {TRANSLATION_TERMS=[AtlasRelatedTermId{termGuid='145657fd-3b04-4faa-bb63-c2177518f120', relationGuid='null', description='null', displayText='null', expression='null', steward='null', source='null', status=null}]}"
}
]
}
Thanks,
Sidharth Mishra
Re: Review Request 73304: ATLAS-4261: Bulk Glossary Import Response
and Failed Error Message Improvements
Posted by Sidharth Mishra <si...@gmail.com>.
> On April 27, 2021, 10:42 a.m., Dharshana MK wrote:
> > Based on the description I have a feed back.
> > Only the termGuid in the relationship is updated. Once a relationship is created we expect the relationGuid also to be updated to keep it consistent with the previous response data.
> > Also displayText is not updated withing the relationship
> >
> > One more suggestion, it will be good to display only the non null values
Changed the response to include display test etc. Example response with new changes:
{
"failedImportInfoList": [
{
"parentObjectName": "Auto",
"childObjectName": "Price",
"importStatus": "FAILED",
"remarks": "Glossary term with qualifiedName Price@Auto already exists"
},
{
"parentObjectName": "Banking2",
"childObjectName": "Receivable",
"importStatus": "FAILED",
"remarks": "The provided Reference Test:Test does not exist at Atlas referred at record with TermName : Receivable and GlossaryName : Banking2"
},
{
"parentObjectName": "Auto",
"childObjectName": "Transmission",
"importStatus": "FAILED",
"remarks": "The provided Reference Test:Test does not exist at Atlas referred at record with TermName : Transmission and GlossaryName : Auto"
}
],
"successImportInfoList": [
{
"parentObjectName": "Banking2",
"childObjectName": "Receivable",
"importStatus": "SUCCESS",
"remarks": "{\"guid\":\"e9cb3e9e-2dc4-46af-99da-10bb975feb71\",\"qualifiedName\":\"Receivable@Banking2\",\"name\":\"Receivable\",\"shortDescription\":\"SD4\",\"longDescription\":\"LD4\",\"examples\":[\"EXAMPLE\"],\"abbreviation\":\"ABBREVIATION\",\"usage\":\"USAGE\",\"anchor\":{\"glossaryGuid\":\"db0a7768-d09e-4a47-9e4c-1c50ce93140e\",\"relationGuid\":\"b78a0728-3fff-4700-b3c7-47b48d500c3f\"}}"
},
{
"parentObjectName": "Banking2",
"childObjectName": "Payable",
"importStatus": "SUCCESS",
"remarks": "{\"guid\":\"1c3d26c6-5ce4-4008-8f73-4a69200930b9\",\"qualifiedName\":\"Payable@Banking2\",\"name\":\"Payable\",\"anchor\":{\"glossaryGuid\":\"db0a7768-d09e-4a47-9e4c-1c50ce93140e\",\"relationGuid\":\"6b47ae70-88f8-4dbe-b063-7db98f7a364f\"}}"
},
{
"parentObjectName": "Auto2",
"childObjectName": "Steering",
"importStatus": "SUCCESS",
"remarks": "{\"guid\":\"8614e449-f41c-4818-9baf-e89a21c2f652\",\"qualifiedName\":\"Steering@Auto2\",\"name\":\"Steering\",\"anchor\":{\"glossaryGuid\":\"5b044fc0-4577-4482-88cf-c9ade044100c\",\"relationGuid\":\"618ee0a3-722e-4dcb-b7f7-82bf9c1275b5\"}}"
},
{
"parentObjectName": "Auto2",
"childObjectName": "Transmission",
"importStatus": "SUCCESS",
"remarks": "{\"guid\":\"3a883c11-8fb5-4cf9-87bc-bd38c71dd6d9\",\"qualifiedName\":\"Transmission@Auto2\",\"name\":\"Transmission\",\"anchor\":{\"glossaryGuid\":\"5b044fc0-4577-4482-88cf-c9ade044100c\",\"relationGuid\":\"082df427-b73d-4c7c-9d24-879d7323d9dd\"}}"
}
]
}
- Sidharth
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73304/#review222876
-----------------------------------------------------------
On April 27, 2021, 9:20 p.m., Sidharth Mishra wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73304/
> -----------------------------------------------------------
>
> (Updated April 27, 2021, 9:20 p.m.)
>
>
> Review request for atlas, Ashutosh Mestry, Deep Singh, Radhika Kundam, and Sarath Subramanian.
>
>
> Bugs: ATLAS-4261
> https://issues.apache.org/jira/browse/ATLAS-4261
>
>
> Repository: atlas
>
>
> Description
> -------
>
> ATLAS-4261: Bulk Glossary Import Response and Failed Error Message Improvements
>
>
> Diffs
> -----
>
> intg/src/main/java/org/apache/atlas/AtlasErrorCode.java 5ef62d310
> intg/src/main/java/org/apache/atlas/model/glossary/AtlasGlossaryTerm.java 4fa1538df
> repository/src/main/java/org/apache/atlas/glossary/GlossaryService.java b12c0b803
> repository/src/main/java/org/apache/atlas/glossary/GlossaryTermUtils.java f5789a712
> repository/src/test/java/org/apache/atlas/glossary/GlossaryServiceTest.java 27717c313
>
>
> Diff: https://reviews.apache.org/r/73304/diff/3/
>
>
> Testing
> -------
>
> Manually tested and example response looks like:
>
> {
> "failedImportInfoList": [
> {
> "parentObjectName": "Industry1",
> "childObjectName": "Fact2",
> "importStatus": "FAILED",
> "remarks": "The provided Reference Fact14:Industry1 does not exist at Atlas referred at record with TermName : Fact2 and GlossaryName : Industry1\nThe provided Reference Horizontal14:Industry1 does not exist at Atlas referred at record with TermName : Fact2 and GlossaryName : Industry1\nThe provided Reference Horizontal14:Industry1 does not exist at Atlas referred at record with TermName : Fact2 and GlossaryName : Industry1\nThe provided Reference Fact14:Industry1 does not exist at Atlas referred at record with TermName : Fact2 and GlossaryName : Industry1"
> },
> {
> "parentObjectName": "Industry1",
> "childObjectName": "Vertical2",
> "importStatus": "FAILED",
> "remarks": "The provided Reference Horizontal14:Industry1 does not exist at Atlas referred at record with TermName : Vertical2 and GlossaryName : Industry1\nThe provided Reference Fact14:Industry1 does not exist at Atlas referred at record with TermName : Vertical2 and GlossaryName : Industry1\nThe provided Reference Fact14:Industry1 does not exist at Atlas referred at record with TermName : Vertical2 and GlossaryName : Industry1"
> },
> {
> "parentObjectName": "Industry1",
> "childObjectName": "Horizontal2",
> "importStatus": "FAILED",
> "remarks": "The provided Reference Vertical14:Industry1 does not exist at Atlas referred at record with TermName : Horizontal2 and GlossaryName : Industry1\nThe provided Reference Fact14:Industry1 does not exist at Atlas referred at record with TermName : Horizontal2 and GlossaryName : Industry1\nThe provided Reference Fact14:Industry1 does not exist at Atlas referred at record with TermName : Horizontal2 and GlossaryName : Industry1\nThe provided Reference Fact14:Industry1 does not exist at Atlas referred at record with TermName : Horizontal2 and GlossaryName : Industry1"
> }
> ],
> "successImportInfoList": [
> {
> "parentObjectName": "Industry1",
> "childObjectName": "Fact2",
> "importStatus": "SUCCESS",
> "remarks": "Create Term without relations"
> },
> {
> "parentObjectName": "Industry1",
> "childObjectName": "Vertical2",
> "importStatus": "SUCCESS",
> "remarks": "Create Term without relations"
> },
> {
> "parentObjectName": "Industry1",
> "childObjectName": "Horizontal2",
> "importStatus": "SUCCESS",
> "remarks": "Create Term without relations"
> },
> {
> "parentObjectName": "Industry1",
> "childObjectName": "Fact2",
> "importStatus": "SUCCESS",
> "remarks": "Update Term Relation: {TRANSLATED_TERMS=[AtlasRelatedTermId{termGuid='362c17a2-3038-4a48-bfdc-37720ce6f80c', relationGuid='null', description='null', displayText='null', expression='null', steward='null', source='null', status=null}]}"
> },
> {
> "parentObjectName": "Industry1",
> "childObjectName": "Vertical2",
> "importStatus": "SUCCESS",
> "remarks": "Update Term Relation: {REPLACEMENT_TERMS=[AtlasRelatedTermId{termGuid='f1322f40-7a7f-4362-bbfd-e758d5df4e05', relationGuid='null', description='null', displayText='null', expression='null', steward='null', source='null', status=null}], TRANSLATION_TERMS=[AtlasRelatedTermId{termGuid='145657fd-3b04-4faa-bb63-c2177518f120', relationGuid='null', description='null', displayText='null', expression='null', steward='null', source='null', status=null}]}"
> },
> {
> "parentObjectName": "Industry1",
> "childObjectName": "Horizontal2",
> "importStatus": "SUCCESS",
> "remarks": "Update Term Relation: {TRANSLATION_TERMS=[AtlasRelatedTermId{termGuid='145657fd-3b04-4faa-bb63-c2177518f120', relationGuid='null', description='null', displayText='null', expression='null', steward='null', source='null', status=null}]}"
> }
> ]
> }
>
>
> Thanks,
>
> Sidharth Mishra
>
>
Re: Review Request 73304: ATLAS-4261: Bulk Glossary Import Response
and Failed Error Message Improvements
Posted by Sidharth Mishra <si...@gmail.com>.
> On April 27, 2021, 10:42 a.m., Dharshana MK wrote:
> > Based on the description I have a feed back.
> > Only the termGuid in the relationship is updated. Once a relationship is created we expect the relationGuid also to be updated to keep it consistent with the previous response data.
> > Also displayText is not updated withing the relationship
> >
> > One more suggestion, it will be good to display only the non null values
>
> Sidharth Mishra wrote:
> Changed the response to include display test etc. Example response with new changes:
> {
> "failedImportInfoList": [
> {
> "parentObjectName": "Auto",
> "childObjectName": "Price",
> "importStatus": "FAILED",
> "remarks": "Glossary term with qualifiedName Price@Auto already exists"
> },
> {
> "parentObjectName": "Banking2",
> "childObjectName": "Receivable",
> "importStatus": "FAILED",
> "remarks": "The provided Reference Test:Test does not exist at Atlas referred at record with TermName : Receivable and GlossaryName : Banking2"
> },
> {
> "parentObjectName": "Auto",
> "childObjectName": "Transmission",
> "importStatus": "FAILED",
> "remarks": "The provided Reference Test:Test does not exist at Atlas referred at record with TermName : Transmission and GlossaryName : Auto"
> }
> ],
> "successImportInfoList": [
> {
> "parentObjectName": "Banking2",
> "childObjectName": "Receivable",
> "importStatus": "SUCCESS",
> "remarks": "{\"guid\":\"e9cb3e9e-2dc4-46af-99da-10bb975feb71\",\"qualifiedName\":\"Receivable@Banking2\",\"name\":\"Receivable\",\"shortDescription\":\"SD4\",\"longDescription\":\"LD4\",\"examples\":[\"EXAMPLE\"],\"abbreviation\":\"ABBREVIATION\",\"usage\":\"USAGE\",\"anchor\":{\"glossaryGuid\":\"db0a7768-d09e-4a47-9e4c-1c50ce93140e\",\"relationGuid\":\"b78a0728-3fff-4700-b3c7-47b48d500c3f\"}}"
> },
> {
> "parentObjectName": "Banking2",
> "childObjectName": "Payable",
> "importStatus": "SUCCESS",
> "remarks": "{\"guid\":\"1c3d26c6-5ce4-4008-8f73-4a69200930b9\",\"qualifiedName\":\"Payable@Banking2\",\"name\":\"Payable\",\"anchor\":{\"glossaryGuid\":\"db0a7768-d09e-4a47-9e4c-1c50ce93140e\",\"relationGuid\":\"6b47ae70-88f8-4dbe-b063-7db98f7a364f\"}}"
> },
> {
> "parentObjectName": "Auto2",
> "childObjectName": "Steering",
> "importStatus": "SUCCESS",
> "remarks": "{\"guid\":\"8614e449-f41c-4818-9baf-e89a21c2f652\",\"qualifiedName\":\"Steering@Auto2\",\"name\":\"Steering\",\"anchor\":{\"glossaryGuid\":\"5b044fc0-4577-4482-88cf-c9ade044100c\",\"relationGuid\":\"618ee0a3-722e-4dcb-b7f7-82bf9c1275b5\"}}"
> },
> {
> "parentObjectName": "Auto2",
> "childObjectName": "Transmission",
> "importStatus": "SUCCESS",
> "remarks": "{\"guid\":\"3a883c11-8fb5-4cf9-87bc-bd38c71dd6d9\",\"qualifiedName\":\"Transmission@Auto2\",\"name\":\"Transmission\",\"anchor\":{\"glossaryGuid\":\"5b044fc0-4577-4482-88cf-c9ade044100c\",\"relationGuid\":\"082df427-b73d-4c7c-9d24-879d7323d9dd\"}}"
> }
> ]
> }
As adding all the details to success will be a performance issue, I think it's better to remove. Finally there will be one row in success with the qualified name of the created term which can be used again to query to get more information like relations etc.
- Sidharth
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73304/#review222876
-----------------------------------------------------------
On April 28, 2021, 12:01 a.m., Sidharth Mishra wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73304/
> -----------------------------------------------------------
>
> (Updated April 28, 2021, 12:01 a.m.)
>
>
> Review request for atlas, Ashutosh Mestry, Deep Singh, Radhika Kundam, and Sarath Subramanian.
>
>
> Bugs: ATLAS-4261
> https://issues.apache.org/jira/browse/ATLAS-4261
>
>
> Repository: atlas
>
>
> Description
> -------
>
> ATLAS-4261: Bulk Glossary Import Response and Failed Error Message Improvements
>
>
> Diffs
> -----
>
> intg/src/main/java/org/apache/atlas/AtlasErrorCode.java 5ef62d310
> intg/src/main/java/org/apache/atlas/model/glossary/AtlasGlossaryTerm.java 4fa1538df
> repository/src/main/java/org/apache/atlas/glossary/GlossaryService.java b12c0b803
> repository/src/main/java/org/apache/atlas/glossary/GlossaryTermUtils.java f5789a712
> repository/src/test/java/org/apache/atlas/glossary/GlossaryServiceTest.java 27717c313
>
>
> Diff: https://reviews.apache.org/r/73304/diff/4/
>
>
> Testing
> -------
>
> Manually tested and example response looks like:
>
> {
> "failedImportInfoList": [
> {
> "parentObjectName": "Auto",
> "childObjectName": "Price",
> "importStatus": "FAILED",
> "remarks": "Glossary term with qualifiedName Price@Auto already exists"
> },
> {
> "parentObjectName": "Banking2",
> "childObjectName": "Receivable",
> "importStatus": "FAILED",
> "remarks": "The provided Reference Test:Test does not exist at Atlas referred at record with TermName : Receivable and GlossaryName : Banking2"
> },
> {
> "parentObjectName": "Auto",
> "childObjectName": "Transmission",
> "importStatus": "FAILED",
> "remarks": "The provided Reference Test:Test does not exist at Atlas referred at record with TermName : Transmission and GlossaryName : Auto"
> }
> ],
> "successImportInfoList": [
> {
> "parentObjectName": "Banking2",
> "childObjectName": "Receivable",
> "importStatus": "SUCCESS",
> "remarks": "{\"guid\":\"e9cb3e9e-2dc4-46af-99da-10bb975feb71\",\"qualifiedName\":\"Receivable@Banking2\",\"name\":\"Receivable\",\"shortDescription\":\"SD4\",\"longDescription\":\"LD4\",\"examples\":[\"EXAMPLE\"],\"abbreviation\":\"ABBREVIATION\",\"usage\":\"USAGE\",\"anchor\":{\"glossaryGuid\":\"db0a7768-d09e-4a47-9e4c-1c50ce93140e\",\"relationGuid\":\"b78a0728-3fff-4700-b3c7-47b48d500c3f\"}}"
> },
> {
> "parentObjectName": "Banking2",
> "childObjectName": "Payable",
> "importStatus": "SUCCESS",
> "remarks": "{\"guid\":\"1c3d26c6-5ce4-4008-8f73-4a69200930b9\",\"qualifiedName\":\"Payable@Banking2\",\"name\":\"Payable\",\"anchor\":{\"glossaryGuid\":\"db0a7768-d09e-4a47-9e4c-1c50ce93140e\",\"relationGuid\":\"6b47ae70-88f8-4dbe-b063-7db98f7a364f\"}}"
> },
> {
> "parentObjectName": "Auto2",
> "childObjectName": "Steering",
> "importStatus": "SUCCESS",
> "remarks": "{\"guid\":\"8614e449-f41c-4818-9baf-e89a21c2f652\",\"qualifiedName\":\"Steering@Auto2\",\"name\":\"Steering\",\"anchor\":{\"glossaryGuid\":\"5b044fc0-4577-4482-88cf-c9ade044100c\",\"relationGuid\":\"618ee0a3-722e-4dcb-b7f7-82bf9c1275b5\"}}"
> },
> {
> "parentObjectName": "Auto2",
> "childObjectName": "Transmission",
> "importStatus": "SUCCESS",
> "remarks": "{\"guid\":\"3a883c11-8fb5-4cf9-87bc-bd38c71dd6d9\",\"qualifiedName\":\"Transmission@Auto2\",\"name\":\"Transmission\",\"anchor\":{\"glossaryGuid\":\"5b044fc0-4577-4482-88cf-c9ade044100c\",\"relationGuid\":\"082df427-b73d-4c7c-9d24-879d7323d9dd\"}}"
> }
> ]
> }
>
>
> Thanks,
>
> Sidharth Mishra
>
>
Re: Review Request 73304: ATLAS-4261: Bulk Glossary Import Response
and Failed Error Message Improvements
Posted by Dharshana MK <dh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73304/#review222876
-----------------------------------------------------------
Based on the description I have a feed back.
Only the termGuid in the relationship is updated. Once a relationship is created we expect the relationGuid also to be updated to keep it consistent with the previous response data.
Also displayText is not updated withing the relationship
One more suggestion, it will be good to display only the non null values
- Dharshana MK
On April 27, 2021, 5:49 a.m., Sidharth Mishra wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73304/
> -----------------------------------------------------------
>
> (Updated April 27, 2021, 5:49 a.m.)
>
>
> Review request for atlas, Ashutosh Mestry, Deep Singh, Radhika Kundam, and Sarath Subramanian.
>
>
> Bugs: ATLAS-4261
> https://issues.apache.org/jira/browse/ATLAS-4261
>
>
> Repository: atlas
>
>
> Description
> -------
>
> ATLAS-4261: Bulk Glossary Import Response and Failed Error Message Improvements
>
>
> Diffs
> -----
>
> intg/src/main/java/org/apache/atlas/AtlasErrorCode.java 5ef62d310
> intg/src/main/java/org/apache/atlas/model/glossary/AtlasGlossaryTerm.java 4fa1538df
> repository/src/main/java/org/apache/atlas/glossary/GlossaryService.java b12c0b803
> repository/src/main/java/org/apache/atlas/glossary/GlossaryTermUtils.java f5789a712
> repository/src/test/java/org/apache/atlas/glossary/GlossaryServiceTest.java 27717c313
>
>
> Diff: https://reviews.apache.org/r/73304/diff/1/
>
>
> Testing
> -------
>
> Manually tested and example response looks like:
>
> {
> "failedImportInfoList": [
> {
> "parentObjectName": "Industry1",
> "childObjectName": "Fact2",
> "importStatus": "FAILED",
> "remarks": "The provided Reference Fact14:Industry1 does not exist at Atlas referred at record with TermName : Fact2 and GlossaryName : Industry1\nThe provided Reference Horizontal14:Industry1 does not exist at Atlas referred at record with TermName : Fact2 and GlossaryName : Industry1\nThe provided Reference Horizontal14:Industry1 does not exist at Atlas referred at record with TermName : Fact2 and GlossaryName : Industry1\nThe provided Reference Fact14:Industry1 does not exist at Atlas referred at record with TermName : Fact2 and GlossaryName : Industry1"
> },
> {
> "parentObjectName": "Industry1",
> "childObjectName": "Vertical2",
> "importStatus": "FAILED",
> "remarks": "The provided Reference Horizontal14:Industry1 does not exist at Atlas referred at record with TermName : Vertical2 and GlossaryName : Industry1\nThe provided Reference Fact14:Industry1 does not exist at Atlas referred at record with TermName : Vertical2 and GlossaryName : Industry1\nThe provided Reference Fact14:Industry1 does not exist at Atlas referred at record with TermName : Vertical2 and GlossaryName : Industry1"
> },
> {
> "parentObjectName": "Industry1",
> "childObjectName": "Horizontal2",
> "importStatus": "FAILED",
> "remarks": "The provided Reference Vertical14:Industry1 does not exist at Atlas referred at record with TermName : Horizontal2 and GlossaryName : Industry1\nThe provided Reference Fact14:Industry1 does not exist at Atlas referred at record with TermName : Horizontal2 and GlossaryName : Industry1\nThe provided Reference Fact14:Industry1 does not exist at Atlas referred at record with TermName : Horizontal2 and GlossaryName : Industry1\nThe provided Reference Fact14:Industry1 does not exist at Atlas referred at record with TermName : Horizontal2 and GlossaryName : Industry1"
> }
> ],
> "successImportInfoList": [
> {
> "parentObjectName": "Industry1",
> "childObjectName": "Fact2",
> "importStatus": "SUCCESS",
> "remarks": "Create Term without relations"
> },
> {
> "parentObjectName": "Industry1",
> "childObjectName": "Vertical2",
> "importStatus": "SUCCESS",
> "remarks": "Create Term without relations"
> },
> {
> "parentObjectName": "Industry1",
> "childObjectName": "Horizontal2",
> "importStatus": "SUCCESS",
> "remarks": "Create Term without relations"
> },
> {
> "parentObjectName": "Industry1",
> "childObjectName": "Fact2",
> "importStatus": "SUCCESS",
> "remarks": "Update Term Relation: {TRANSLATED_TERMS=[AtlasRelatedTermId{termGuid='362c17a2-3038-4a48-bfdc-37720ce6f80c', relationGuid='null', description='null', displayText='null', expression='null', steward='null', source='null', status=null}]}"
> },
> {
> "parentObjectName": "Industry1",
> "childObjectName": "Vertical2",
> "importStatus": "SUCCESS",
> "remarks": "Update Term Relation: {REPLACEMENT_TERMS=[AtlasRelatedTermId{termGuid='f1322f40-7a7f-4362-bbfd-e758d5df4e05', relationGuid='null', description='null', displayText='null', expression='null', steward='null', source='null', status=null}], TRANSLATION_TERMS=[AtlasRelatedTermId{termGuid='145657fd-3b04-4faa-bb63-c2177518f120', relationGuid='null', description='null', displayText='null', expression='null', steward='null', source='null', status=null}]}"
> },
> {
> "parentObjectName": "Industry1",
> "childObjectName": "Horizontal2",
> "importStatus": "SUCCESS",
> "remarks": "Update Term Relation: {TRANSLATION_TERMS=[AtlasRelatedTermId{termGuid='145657fd-3b04-4faa-bb63-c2177518f120', relationGuid='null', description='null', displayText='null', expression='null', steward='null', source='null', status=null}]}"
> }
> ]
> }
>
>
> Thanks,
>
> Sidharth Mishra
>
>