You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Dominic Hamon <dh...@twopensource.com> on 2014/06/13 01:37:59 UTC
Re: Review Request 22441: Intercept wait and allow for multiple status
update manager flushes.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22441/
-----------------------------------------------------------
(Updated June 12, 2014, 4:37 p.m.)
Review request for mesos, Ian Downes and Vinod Kone.
Summary (updated)
-----------------
Intercept wait and allow for multiple status update manager flushes.
Bugs: MESOS-1437
https://issues.apache.org/jira/browse/MESOS-1437
Repository: mesos-git
Description
-------
Occasionally the task would fail due to unknown container before we started the recover. Moving the pause earlier to ensure we are ready for the failure before we see it.
Diffs (updated)
-----
src/tests/slave_recovery_tests.cpp 44ffac40b9edc9940f17b5fbe1848d56cf53b69b
Diff: https://reviews.apache.org/r/22441/diff/
Testing
-------
make check x 1500
Thanks,
Dominic Hamon
Re: Review Request 22441: Intercept wait and allow for multiple status
update manager flushes.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22441/#review45559
-----------------------------------------------------------
Ship it!
src/tests/slave_recovery_tests.cpp
<https://reviews.apache.org/r/22441/#comment80446>
Add a comment here on why you are doing this.
- Vinod Kone
On June 12, 2014, 11:37 p.m., Dominic Hamon wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22441/
> -----------------------------------------------------------
>
> (Updated June 12, 2014, 11:37 p.m.)
>
>
> Review request for mesos, Ian Downes and Vinod Kone.
>
>
> Bugs: MESOS-1437
> https://issues.apache.org/jira/browse/MESOS-1437
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Occasionally the task would fail due to unknown container before we started the recover. Moving the pause earlier to ensure we are ready for the failure before we see it.
>
>
> Diffs
> -----
>
> src/tests/slave_recovery_tests.cpp 44ffac40b9edc9940f17b5fbe1848d56cf53b69b
>
> Diff: https://reviews.apache.org/r/22441/diff/
>
>
> Testing
> -------
>
> make check x 1500
>
>
> Thanks,
>
> Dominic Hamon
>
>
Re: Review Request 22441: Intercept wait and allow for multiple status
update manager flushes.
Posted by Dominic Hamon <dh...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22441/
-----------------------------------------------------------
(Updated June 12, 2014, 6:45 p.m.)
Review request for mesos, Ian Downes and Vinod Kone.
Changes
-------
commented
Bugs: MESOS-1437
https://issues.apache.org/jira/browse/MESOS-1437
Repository: mesos-git
Description
-------
Occasionally the task would fail due to unknown container before we started the recover. Moving the pause earlier to ensure we are ready for the failure before we see it.
Diffs (updated)
-----
src/tests/slave_recovery_tests.cpp 44ffac40b9edc9940f17b5fbe1848d56cf53b69b
Diff: https://reviews.apache.org/r/22441/diff/
Testing
-------
make check x 1500
Thanks,
Dominic Hamon