[GitHub] [skywalking] xbkaishui commented on a change in pull request #5628: Support Alarm to dingtalk

[GitBox <gi...@apache.org>]

xbkaishui commented on a change in pull request #5628:
URL: https://github.com/apache/skywalking/pull/5628#discussion_r499231489



##########
File path: docs/en/setup/backend/backend-alarm.md
##########
@@ -219,6 +219,26 @@ wechatHooks:
     - https://qyapi.weixin.qq.com/cgi-bin/webhook/send?key=dummy_key
 ```
 
+## Dingtalk Hook
+To do this you need to follow the [Dingtalk Webhooks guide](https://ding-doc.dingtalk.com/doc#/serverapi2/qf2nxq/uKPlK) and create new Webhooks.
+For security issue, you can config optional secret for individual webhook url.
+The alarm message will send through HTTP post by `application/json` content type if you configured Slack Incoming Webhooks as following:

Review comment:
       Yes, fixed

##########
File path: oap-server/server-bootstrap/src/main/resources/alarm-settings.yml
##########
@@ -69,3 +69,17 @@ wechatHooks:
     }
   webhooks:
 #    - https://qyapi.weixin.qq.com/cgi-bin/webhook/send?key=dummy_key
+
+dingtalkHooks:
+  textTemplate: |-
+    {
+      "msgtype": "text",
+      "text": {
+        "content": "Apache SkyWalking Alarm: \n %s."
+      }
+    }
+  webhooks:
+#    - url: https://oapi.dingtalk.com/robot/send?access_token=dummy_token
+#      secret: dummysecret
+#    - url: https://oapi.dingtalk.com/robot/send?access_token=dummy_token2
+#      secret:

Review comment:
       done

##########
File path: docs/en/setup/backend/backend-alarm.md
##########
@@ -219,6 +219,26 @@ wechatHooks:
     - https://qyapi.weixin.qq.com/cgi-bin/webhook/send?key=dummy_key
 ```
 
+## Dingtalk Hook
+To do this you need to follow the [Dingtalk Webhooks guide](https://ding-doc.dingtalk.com/doc#/serverapi2/qf2nxq/uKPlK) and create new Webhooks.
+For security issue, you can config optional secret for individual webhook url.
+The alarm message will send through HTTP post by `application/json` content type if you configured Slack Incoming Webhooks as following:
+```yml
+dingtalkHooks:
+  textTemplate: |-
+    {
+      "msgtype": "text",
+      "text": {
+        "content": "Apache SkyWalking Alarm: \n %s."
+      }
+    }
+  webhooks:
+    - url: https://oapi.dingtalk.com/robot/send?access_token=dummy_token
+      secret: dummysecret
+    - url: https://oapi.dingtalk.com/robot/send?access_token=dummy_token2
+      secret:

Review comment:
       done




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org