You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tinkerpop.apache.org by spmallette <gi...@git.apache.org> on 2016/01/16 01:55:56 UTC
[GitHub] incubator-tinkerpop pull request: TINKERPOP-1086 Added gryo serial...
GitHub user spmallette opened a pull request:
https://github.com/apache/incubator-tinkerpop/pull/203
TINKERPOP-1086 Added gryo serializers for virtually all java.time classes.
These classes did not have serializers native to kryo and were also not in the semi-standard contrib package of serializers. GraphSON serialization works out of the box with `FieldSerializer` - it's verbose output for JSON but I dont' think we need to build special serializers for that yet.
Ran both unit and integration tests successfully. Also did a manual test in the console via `:remote`:
```text
gremlin> :> java.time.Instant.now()
==>2016-01-15T19:39:16.569Z
gremlin> :> java.time.Duration.ZERO
==>PT0S
gremlin> :> java.time.Duration.ofDays(10)
==>PT240H
```
VOTE +1
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/apache/incubator-tinkerpop TINKERPOP-1086
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-tinkerpop/pull/203.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #203
----
commit 74b4c6186158037b20593a12e9b7ed4105632be1
Author: Stephen Mallette <sp...@genoprime.com>
Date: 2016-01-16T00:51:39Z
Added gryo serializers for virtually all java.time classes.
These classes did not have serializers natively to kryo and were also not in the semi-standard contrib package of serializers.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-tinkerpop pull request: TINKERPOP-1086 Added gryo serial...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-tinkerpop/pull/203
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-tinkerpop pull request: TINKERPOP-1086 Added gryo serial...
Posted by dkuppitz <gi...@git.apache.org>.
Github user dkuppitz commented on the pull request:
https://github.com/apache/incubator-tinkerpop/pull/203#issuecomment-172548799
* `mvn clean install`: passed
* integration tests: passed
VOTE: +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-tinkerpop pull request: TINKERPOP-1086 Added gryo serial...
Posted by BrynCooke <gi...@git.apache.org>.
Github user BrynCooke commented on the pull request:
https://github.com/apache/incubator-tinkerpop/pull/203#issuecomment-172468549
Awesome +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-tinkerpop pull request: TINKERPOP-1086 Added gryo serial...
Posted by okram <gi...@git.apache.org>.
Github user okram commented on the pull request:
https://github.com/apache/incubator-tinkerpop/pull/203#issuecomment-172575095
VOTE +1.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---