You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@geode.apache.org by GitBox <gi...@apache.org> on 2022/05/19 23:54:00 UTC

[GitHub] [geode] Bill commented on pull request #7703: GEODE-10318: do not add duplicate entries in the locators list

Bill commented on PR #7703:
URL: https://github.com/apache/geode/pull/7703#issuecomment-1132307557

   The ArchUnit test is failing. I recommend moving the locator string parsing logic from the `geode-membership` subproject to a class in a new package in the `geode-common` subproject maybe:
   
    `o.a.g.common.internal.net`
   
   Then we may need to add an ArchUnit rule to `MembershipDependenciesJUnitTest` after line 61 like:
   
     `.or(resideInAPackage("org.apache.geode.internal.common.."))`
   
   …that will let classes in `geode-membership` depend on classes in the new package you add to `geode-common`.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org