[jira] Commented: (JDKIM-20) jdkim will throw unexpected exceptions

["Stefano Bagnara (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/JDKIM-20?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12908560#action_12908560 ] 

Stefano Bagnara commented on JDKIM-20:
--------------------------------------

Hi Ben,

thank you for reporting the issue. Can you provide a couple of sample mail so that I can add them to the test suite as a proof of the bug & bugfix?

Otherwise a full stack trace for the 2 conditions would help understanding what the "condition" is and how to synthetize a couple of messages to prove that.

Stefano

> jdkim will throw unexpected exceptions
> --------------------------------------
>
>                 Key: JDKIM-20
>                 URL: https://issues.apache.org/jira/browse/JDKIM-20
>             Project: JAMES jDKIM
>          Issue Type: Bug
>          Components: library
>    Affects Versions: 0.2, 1.0
>         Environment: java version "1.6.0_18" ubuntu 10.04
>            Reporter: Ben Aldrich
>   Original Estimate: 0.5h
>  Remaining Estimate: 0.5h
>
> when calling validate I am seeing IllegalStateExceptions and IllegalArgumentException. 
> It looks like we just need to catch these exceptions in the DKIMVerifier.java
> more specifically, in the verify method we need to add this around line 270 :
>                     } catch (IllegalArgumentException e) {
>                         throw new PermFailException(e.getMessage());
> and we should also add this in the signatureVerify method:
>         try {
>           signature.initVerify(key.getPublicKey());
>         } catch (IllegalStateException e) {
>             throw new PermFailException(e.getMessage());
>         }

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org