You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Thomas Marshall (Code Review)" <ge...@cloudera.org> on 2018/12/18 00:52:28 UTC
[Impala-ASF-CR] IMPALA-7990: make test lifecycle failures more permissive
Thomas Marshall has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12103
Change subject: IMPALA-7990: make test_lifecycle_failures more permissive
......................................................................
IMPALA-7990: make test_lifecycle_failures more permissive
test_lifecycle_failures runs a query with a debug action set to cause
fragment thread creation to fail 50% of the time and checks that the
query either succeeded or failed with an expected error.
Generally, the failure happens early enough that the query hasn't yet
reached FINISHED, but its also correct under Impala's query lifecycle
model for the query to reach FINISHED before the error is hit, in
which case it will be returned by a call to fetch().
Previously, the expected error in the test only handled the first
case. This patch modifies it to be more permissive in order to handle
both cases.
Testing:
- Ran test_lifecycle_failures in a loop 200 times without a failure.
Previously it repro-ed for me ~10% of the time.
Change-Id: I2da4ca95692b445e05796105d3b7d14e51fece88
---
M tests/failure/test_failpoints.py
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/03/12103/1
--
To view, visit http://gerrit.cloudera.org:8080/12103
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I2da4ca95692b445e05796105d3b7d14e51fece88
Gerrit-Change-Number: 12103
Gerrit-PatchSet: 1
Gerrit-Owner: Thomas Marshall <th...@cmu.edu>
[Impala-ASF-CR] IMPALA-7990: make test lifecycle failures more permissive
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12103 )
Change subject: IMPALA-7990: make test_lifecycle_failures more permissive
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/12103
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2da4ca95692b445e05796105d3b7d14e51fece88
Gerrit-Change-Number: 12103
Gerrit-PatchSet: 1
Gerrit-Owner: Thomas Marshall <th...@cmu.edu>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 18 Dec 2018 00:54:44 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7990: make test lifecycle failures more permissive
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12103 )
Change subject: IMPALA-7990: make test_lifecycle_failures more permissive
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/1635/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/12103
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2da4ca95692b445e05796105d3b7d14e51fece88
Gerrit-Change-Number: 12103
Gerrit-PatchSet: 1
Gerrit-Owner: Thomas Marshall <th...@cmu.edu>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 18 Dec 2018 01:26:30 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7990: make test lifecycle failures more permissive
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12103 )
Change subject: IMPALA-7990: make test_lifecycle_failures more permissive
......................................................................
Patch Set 1:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/3579/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/12103
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2da4ca95692b445e05796105d3b7d14e51fece88
Gerrit-Change-Number: 12103
Gerrit-PatchSet: 1
Gerrit-Owner: Thomas Marshall <th...@cmu.edu>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 18 Dec 2018 00:56:51 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7990: make test lifecycle failures more permissive
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12103 )
Change subject: IMPALA-7990: make test_lifecycle_failures more permissive
......................................................................
Patch Set 1: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/12103
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2da4ca95692b445e05796105d3b7d14e51fece88
Gerrit-Change-Number: 12103
Gerrit-PatchSet: 1
Gerrit-Owner: Thomas Marshall <th...@cmu.edu>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 18 Dec 2018 04:57:36 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7990: make test lifecycle failures more permissive
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12103 )
Change subject: IMPALA-7990: make test_lifecycle_failures more permissive
......................................................................
IMPALA-7990: make test_lifecycle_failures more permissive
test_lifecycle_failures runs a query with a debug action set to cause
fragment thread creation to fail 50% of the time and checks that the
query either succeeded or failed with an expected error.
Generally, the failure happens early enough that the query hasn't yet
reached FINISHED, but its also correct under Impala's query lifecycle
model for the query to reach FINISHED before the error is hit, in
which case it will be returned by a call to fetch().
Previously, the expected error in the test only handled the first
case. This patch modifies it to be more permissive in order to handle
both cases.
Testing:
- Ran test_lifecycle_failures in a loop 200 times without a failure.
Previously it repro-ed for me ~10% of the time.
Change-Id: I2da4ca95692b445e05796105d3b7d14e51fece88
Reviewed-on: http://gerrit.cloudera.org:8080/12103
Reviewed-by: Tim Armstrong <ta...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M tests/failure/test_failpoints.py
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Tim Armstrong: Looks good to me, approved
Impala Public Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/12103
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I2da4ca95692b445e05796105d3b7d14e51fece88
Gerrit-Change-Number: 12103
Gerrit-PatchSet: 2
Gerrit-Owner: Thomas Marshall <th...@cmu.edu>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>