[jira] [Commented] (BIGTOP-2744) Fix zookeeper build error on AArch64

["Yuqi Gu (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/BIGTOP-2744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15972341#comment-15972341 ] 

Yuqi Gu commented on BIGTOP-2744:
---------------------------------

GCC does provide alternative primitives (sync*) which provide better cross platform compatibility; but that does make the assumption that a) gcc is being used or b) the primitives are provided by alternative compilers.
The patch to use _sync primitives rather than 'asm'.


This bug is fixed in zookeeper branch-3.5 but not  in branch-3.4. But, Zookeeper-3.4.10 is integrated into Bigtop. https://github.com/apache/bigtop/commit/b00ac093634437e749561c8837179d13d95fda91

Please merge this patch for this fixing building error.
When you guys want to upgrade zookeeper to branch 3.5+ in bigtop, please remove it correspondingly.


> Fix zookeeper build error on AArch64
> ------------------------------------
>
>                 Key: BIGTOP-2744
>                 URL: https://issues.apache.org/jira/browse/BIGTOP-2744
>             Project: Bigtop
>          Issue Type: Bug
>          Components: build
>         Environment: Hisilicon Taishan AArch64(Cortex-A57@2.1GHz) 
> 16.04.2 LTS (Xenial Xerus)
>            Reporter: Yuqi Gu
>             Fix For: 1.3.0
>
>
> The error occurred when we build the bigtop zookeeper component on AArch64 :
> "[exec] libtool: compile: gcc -DHAVE_CONFIG_H -I. -I/ws/output/zookeeper/zookeeper-3.4.10/src/c -I/ws/output/zookeeper/zookeeper-3.4.10/src/c/include -I/ws/output/zookeeper/zookeeper-3.4.10/src/c/tests -I/ws/output/zookeeper/zookeeper-3.4.10/src/c/generated -Wdate-time -D_FORTIFY_SOURCE=2 -DTHREADED -g -O2 -fstack-protector-strong -Wformat -Werror=format-security -MT libzkmt_la-mt_adaptor.lo -MD -MP -MF .deps/libzkmt_la-mt_adaptor.Tpo -c /ws/output/zookeeper/zookeeper-3.4.10/src/c/src/mt_adaptor.c -fPIC -DPIC -o .libs/libzkmt_la-mt_adaptor.o
> [exec] Makefile:946: recipe for target 'libzkmt_la-mt_adaptor.lo' failed
> [exec] make[2]: Leaving directory '/ws/output/zookeeper/zookeeper-3.4.10/build/c'
> [exec] /tmp/cc4YHZ73.s: Assembler messages:
> [exec] /tmp/cc4YHZ73.s:1713: Error: unknown mnemonic lock' --lock xaddl x1,[x0]'
> [exec] make[2]: *** [libzkmt_la-mt_adaptor.lo] Error 1
> "



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)