You are viewing a plain text version of this content. The canonical link for it is here.
Posted to pr@cassandra.apache.org by "QFREEE (via GitHub)" <gi...@apache.org> on 2025/07/02 05:28:22 UTC
[PR] CASSSIDECAR-265 init Spotless setup [cassandra-sidecar]
QFREEE opened a new pull request, #235:
URL: https://github.com/apache/cassandra-sidecar/pull/235
to review files formatted,
checkout this branch, drop commit 44a90c1cb5653e2863f9e4506a9b1108173b30a6 ( which contains files formatted from spotless)
run `./gradlew spotlessApply` to see what files are changes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
Re: [PR] CASSSIDECAR-265 init Spotless setup [cassandra-sidecar]
Posted by "QFREEE (via GitHub)" <gi...@apache.org>.
QFREEE commented on code in PR #235:
URL: https://github.com/apache/cassandra-sidecar/pull/235#discussion_r2180111785
##########
gradle/validation/spotless.gradle:
##########
@@ -0,0 +1,59 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+allprojects { prj ->
+ plugins.withType(JavaPlugin) {
+ prj.apply plugin: 'com.diffplug.spotless'
+
+ spotless {
+ java {
+
+
+ eclipse().configFile "${rootDir}/gradle/validation/cassandra-sidecar-cs-formatter.xml"
+
+ importOrder 'java', 'javax', 'com.google.common', 'org.apache.commons', 'org.junit', 'org.slf4j', '', '\\#org.junit','\\#'
Review Comment:
Our checkstyle config would check: 1. static import at the bottom 2. static import also follow our custom order ```'java', 'javax', 'com.google.common', 'org.apache.commons', 'org.junit', 'org.slf4j'```, i didn't find a good way to achieve that, so have to break static import into 2 groups ```'\\#org.junit','\\#'```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
Re: [PR] CASSSIDECAR-265 init Spotless setup [cassandra-sidecar]
Posted by "QFREEE (via GitHub)" <gi...@apache.org>.
QFREEE closed pull request #235: CASSSIDECAR-265 init Spotless setup
URL: https://github.com/apache/cassandra-sidecar/pull/235
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
Re: [PR] CASSSIDECAR-265 init Spotless setup [cassandra-sidecar]
Posted by "QFREEE (via GitHub)" <gi...@apache.org>.
QFREEE commented on PR #235:
URL: https://github.com/apache/cassandra-sidecar/pull/235#issuecomment-3027974132
Few areas i need to investigate:
1. warp lines at 160 have some edge cases where lines still over 160
2. the javadoc formatting is odd
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
Re: [PR] CASSSIDECAR-265 init Spotless setup [cassandra-sidecar]
Posted by "QFREEE (via GitHub)" <gi...@apache.org>.
QFREEE commented on PR #235:
URL: https://github.com/apache/cassandra-sidecar/pull/235#issuecomment-3518509016
closing this for now, I am not actively working on this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
Re: [PR] CASSSIDECAR-265 init Spotless setup [cassandra-sidecar]
Posted by "yifan-c (via GitHub)" <gi...@apache.org>.
yifan-c commented on PR #235:
URL: https://github.com/apache/cassandra-sidecar/pull/235#issuecomment-3215523441
Hi @QFREEE, how are things going with this patch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
Re: [PR] CASSSIDECAR-265 init Spotless setup [cassandra-sidecar]
Posted by "QFREEE (via GitHub)" <gi...@apache.org>.
QFREEE commented on code in PR #235:
URL: https://github.com/apache/cassandra-sidecar/pull/235#discussion_r2180116881
##########
gradle/validation/cassandra-sidecar-cs-formatter.xml:
##########
@@ -0,0 +1,259 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<!--
+ ~ Licensed to the Apache Software Foundation (ASF) under one
+ ~ or more contributor license agreements. See the NOTICE file
+ ~ distributed with this work for additional information
+ ~ regarding copyright ownership. The ASF licenses this file
+ ~ to you under the Apache License, Version 2.0 (the
+ ~ "License"); you may not use this file except in compliance
+ ~ with the License. You may obtain a copy of the License at
+ ~
+ ~ http://www.apache.org/licenses/LICENSE-2.0
+ ~
+ ~ Unless required by applicable law or agreed to in writing, software
+ ~ distributed under the License is distributed on an "AS IS" BASIS,
+ ~ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ ~ See the License for the specific language governing permissions and
+ ~ limitations under the License.
+ -->
+
+<profiles version="10">
Review Comment:
the base of this file is comming from using eclipse-cs plugin and convert `checkstyle.xml` to eclipse formatter rule
https://stackoverflow.com/questions/984778/how-to-generate-an-eclipse-formatter-configuration-from-a-checkstyle-configurati#:~:text=Right%2Dclick%20on%20your%20project,Click%20OK!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
Re: [PR] CASSSIDECAR-265 init Spotless setup [cassandra-sidecar]
Posted by "QFREEE (via GitHub)" <gi...@apache.org>.
QFREEE commented on code in PR #235:
URL: https://github.com/apache/cassandra-sidecar/pull/235#discussion_r2180116881
##########
gradle/validation/cassandra-sidecar-cs-formatter.xml:
##########
@@ -0,0 +1,259 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<!--
+ ~ Licensed to the Apache Software Foundation (ASF) under one
+ ~ or more contributor license agreements. See the NOTICE file
+ ~ distributed with this work for additional information
+ ~ regarding copyright ownership. The ASF licenses this file
+ ~ to you under the Apache License, Version 2.0 (the
+ ~ "License"); you may not use this file except in compliance
+ ~ with the License. You may obtain a copy of the License at
+ ~
+ ~ http://www.apache.org/licenses/LICENSE-2.0
+ ~
+ ~ Unless required by applicable law or agreed to in writing, software
+ ~ distributed under the License is distributed on an "AS IS" BASIS,
+ ~ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ ~ See the License for the specific language governing permissions and
+ ~ limitations under the License.
+ -->
+
+<profiles version="10">
Review Comment:
the base of this file is comming from using eclipse-cs plugin and convert `checkstyle.xml` to eclipse formatter rule
ref:
https://stackoverflow.com/questions/984778/how-to-generate-an-eclipse-formatter-configuration-from-a-checkstyle-configurati
##########
gradle/validation/cassandra-sidecar-cs-formatter.xml:
##########
@@ -0,0 +1,259 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<!--
+ ~ Licensed to the Apache Software Foundation (ASF) under one
+ ~ or more contributor license agreements. See the NOTICE file
+ ~ distributed with this work for additional information
+ ~ regarding copyright ownership. The ASF licenses this file
+ ~ to you under the Apache License, Version 2.0 (the
+ ~ "License"); you may not use this file except in compliance
+ ~ with the License. You may obtain a copy of the License at
+ ~
+ ~ http://www.apache.org/licenses/LICENSE-2.0
+ ~
+ ~ Unless required by applicable law or agreed to in writing, software
+ ~ distributed under the License is distributed on an "AS IS" BASIS,
+ ~ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ ~ See the License for the specific language governing permissions and
+ ~ limitations under the License.
+ -->
+
+<profiles version="10">
Review Comment:
the base of this file is comming from using eclipse-cs plugin and convert `checkstyle.xml` to eclipse formatter rule
ref:
https://stackoverflow.com/questions/984778/how-to-generate-an-eclipse-formatter-configuration-from-a-checkstyle-configurati
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org