You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Vinod Kone <vi...@gmail.com> on 2013/03/14 04:45:08 UTC
Review Request: Fixed the master to send updated framework pids and relink
to the reregistered slave.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9918/
-----------------------------------------------------------
Review request for mesos, Benjamin Hindman and Ben Mahler.
Description
-------
See summary.
Diffs
-----
src/master/master.cpp 48e12b4fd02acbc549f20c8eb36a111a2572cfc6
src/slave/slave.cpp c81b8110a5f619ddd418e572a13fb29b44a8783e
src/tests/slave_recovery_tests.cpp 8f224882b12bbf83c36f464509f376827dbd7744
Diff: https://reviews.apache.org/r/9918/diff/
Testing
-------
make check
Thanks,
Vinod Kone
Re: Review Request: Fixed the master to send updated framework pids and
relink to the reregistered slave.
Posted by Vinod Kone <vi...@gmail.com>.
> On March 14, 2013, 5:31 a.m., Benjamin Hindman wrote:
> > This seems like a pretty common case ... why no test?
I updated the slave recovery test, to catch this specific bug. But, as discussed offline, I will try to come up with more comprehensive tests regarding slave restart (another review).
- Vinod
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9918/#review17854
-----------------------------------------------------------
On March 14, 2013, 3:45 a.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9918/
> -----------------------------------------------------------
>
> (Updated March 14, 2013, 3:45 a.m.)
>
>
> Review request for mesos, Benjamin Hindman and Ben Mahler.
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/master/master.cpp 48e12b4fd02acbc549f20c8eb36a111a2572cfc6
> src/slave/slave.cpp c81b8110a5f619ddd418e572a13fb29b44a8783e
> src/tests/slave_recovery_tests.cpp 8f224882b12bbf83c36f464509f376827dbd7744
>
> Diff: https://reviews.apache.org/r/9918/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Vinod Kone
>
>
Re: Review Request: Fixed the master to send updated framework pids and
relink to the reregistered slave.
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9918/#review17854
-----------------------------------------------------------
Ship it!
This seems like a pretty common case ... why no test?
src/master/master.cpp
<https://reviews.apache.org/r/9918/#comment37814>
s/zookeeper/ZooKeeper/
src/master/master.cpp
<https://reviews.apache.org/r/9918/#comment37815>
CHECK_NOTNULL(slave);
- Benjamin Hindman
On March 14, 2013, 3:45 a.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9918/
> -----------------------------------------------------------
>
> (Updated March 14, 2013, 3:45 a.m.)
>
>
> Review request for mesos, Benjamin Hindman and Ben Mahler.
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/master/master.cpp 48e12b4fd02acbc549f20c8eb36a111a2572cfc6
> src/slave/slave.cpp c81b8110a5f619ddd418e572a13fb29b44a8783e
> src/tests/slave_recovery_tests.cpp 8f224882b12bbf83c36f464509f376827dbd7744
>
> Diff: https://reviews.apache.org/r/9918/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Vinod Kone
>
>
Re: Review Request: Fixed the master to send updated framework pids and
relink to the reregistered slave.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9918/
-----------------------------------------------------------
(Updated March 14, 2013, 6:05 a.m.)
Review request for mesos, Benjamin Hindman and Ben Mahler.
Changes
-------
benh's.
Description
-------
See summary.
Diffs (updated)
-----
src/master/master.cpp 48e12b4fd02acbc549f20c8eb36a111a2572cfc6
src/slave/slave.cpp c81b8110a5f619ddd418e572a13fb29b44a8783e
src/tests/slave_recovery_tests.cpp 8f224882b12bbf83c36f464509f376827dbd7744
Diff: https://reviews.apache.org/r/9918/diff/
Testing
-------
make check
Thanks,
Vinod Kone