You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2020/10/26 13:00:08 UTC
[GitHub] [rocketmq-externals] fantow opened a new pull request #643: fix issue#641
fantow opened a new pull request #643:
URL: https://github.com/apache/rocketmq-externals/pull/643
fix the [issue#641](https://github.com/apache/rocketmq-externals/issues/641)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-externals] fantow commented on a change in pull request #643: [ISSUE #641]Rename NameSrvAddrList to NameServerAddressList in OPS Page
Posted by GitBox <gi...@apache.org>.
fantow commented on a change in pull request #643:
URL: https://github.com/apache/rocketmq-externals/pull/643#discussion_r512609594
##########
File path: rocketmq-console/src/main/resources/static/view/pages/ops.html
##########
@@ -16,23 +16,26 @@
-->
<div class="container-fluid" id="deployHistoryList">
<div class="page-content">
- <h2 class="md-title">NameSvrAddrList</h2>
+ <h2 class="md-title">NameServerAddressList</h2>
<div class="pull-left">
- <md-chips ng-model="namesvrAddrList" readonly="ctrl.readonly" md-removable="ctrl.removable" md-enable-chip-edit="true"></md-chips>
+ <md-chips ng-model="namesvrAddrList" readonly="ctrl.readonly" md-removable="ctrl.removable"
+ md-enable-chip-edit="true"></md-chips>
</div>
<div class="pull-left">
- <button class="btn btn-raised btn-sm btn-primary" type="button" ng-click="updateNameSvrAddr()">{{'UPDATE' | translate}}
+ <button class="btn btn-raised btn-sm btn-primary" type="button" ng-click="updateNameSvrAddr()">{{'UPDATE' |
Review comment:
Sry,I sumbit another PR to fix it.I will close this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-externals] fantow closed pull request #643: [ISSUE #641]Rename NameSrvAddrList to NameServerAddressList in OPS Page
Posted by GitBox <gi...@apache.org>.
fantow closed pull request #643:
URL: https://github.com/apache/rocketmq-externals/pull/643
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-externals] vongosling commented on a change in pull request #643: [ISSUE #641]Rename NameSrvAddrList to NameServerAddressList in OPS Page
Posted by GitBox <gi...@apache.org>.
vongosling commented on a change in pull request #643:
URL: https://github.com/apache/rocketmq-externals/pull/643#discussion_r512356431
##########
File path: rocketmq-console/src/main/resources/static/view/pages/ops.html
##########
@@ -16,23 +16,26 @@
-->
<div class="container-fluid" id="deployHistoryList">
<div class="page-content">
- <h2 class="md-title">NameSvrAddrList</h2>
+ <h2 class="md-title">NameServerAddressList</h2>
<div class="pull-left">
- <md-chips ng-model="namesvrAddrList" readonly="ctrl.readonly" md-removable="ctrl.removable" md-enable-chip-edit="true"></md-chips>
+ <md-chips ng-model="namesvrAddrList" readonly="ctrl.readonly" md-removable="ctrl.removable"
+ md-enable-chip-edit="true"></md-chips>
</div>
<div class="pull-left">
- <button class="btn btn-raised btn-sm btn-primary" type="button" ng-click="updateNameSvrAddr()">{{'UPDATE' | translate}}
+ <button class="btn btn-raised btn-sm btn-primary" type="button" ng-click="updateNameSvrAddr()">{{'UPDATE' |
+ translate}}
</button>
</div>
<br/>
<br/>
<h2 class="md-title">IsUseVIPChannel</h2>
- <div class="pull-left">
+ <div class="pull-left">
<md-switch class="md-primary" md-no-ink aria-label="Switch No Ink" ng-model="useVIPChannel">
</md-switch>
</div>
<div class="pull-left">
- <button class="btn btn-raised btn-sm btn-primary" type="button" ng-click="updateIsVIPChannel()">{{'UPDATE' | translate}}
+ <button class="btn btn-raised btn-sm btn-primary" type="button" ng-click="updateIsVIPChannel()">{{'UPDATE' |
+ translate}}
Review comment:
Do not format here !
##########
File path: rocketmq-console/src/main/resources/static/view/pages/ops.html
##########
@@ -16,23 +16,26 @@
-->
<div class="container-fluid" id="deployHistoryList">
<div class="page-content">
- <h2 class="md-title">NameSvrAddrList</h2>
+ <h2 class="md-title">NameServerAddressList</h2>
<div class="pull-left">
- <md-chips ng-model="namesvrAddrList" readonly="ctrl.readonly" md-removable="ctrl.removable" md-enable-chip-edit="true"></md-chips>
+ <md-chips ng-model="namesvrAddrList" readonly="ctrl.readonly" md-removable="ctrl.removable"
Review comment:
Like others, you could format only the update spot.
##########
File path: rocketmq-console/src/main/resources/static/view/pages/ops.html
##########
@@ -16,23 +16,26 @@
-->
<div class="container-fluid" id="deployHistoryList">
<div class="page-content">
- <h2 class="md-title">NameSvrAddrList</h2>
+ <h2 class="md-title">NameServerAddressList</h2>
<div class="pull-left">
- <md-chips ng-model="namesvrAddrList" readonly="ctrl.readonly" md-removable="ctrl.removable" md-enable-chip-edit="true"></md-chips>
+ <md-chips ng-model="namesvrAddrList" readonly="ctrl.readonly" md-removable="ctrl.removable"
+ md-enable-chip-edit="true"></md-chips>
</div>
<div class="pull-left">
- <button class="btn btn-raised btn-sm btn-primary" type="button" ng-click="updateNameSvrAddr()">{{'UPDATE' | translate}}
+ <button class="btn btn-raised btn-sm btn-primary" type="button" ng-click="updateNameSvrAddr()">{{'UPDATE' |
Review comment:
Why format here ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org