[GitHub] [couchdb] nickva opened a new pull request, #4177: Remove the long deprecated bigcouch 0.4 change sequence support

[GitBox <gi...@apache.org>]

nickva opened a new pull request, #4177:
URL: https://github.com/apache/couchdb/pull/4177

   We always ran a regex match for it, then failed, and tried the regular pattern. Regexes are pretty fast (15-30 microseconds on my laptop), but it's still a waste of resources. For comparison a `config:get/3` is about microsecond, so it's like needlessly performing 10 extra config lookup per `_changes` feed request.
   
   Improve unit tests by having more cases and one test per case.
   
   Remove unreachable `"now"` clause in `validate_start_seq/2`. By that point `get_start_seq/2` should have transformed `"now"` into a proper sequence so it's confusing validating that case as passing. At that point it should be considered a 
    failure, which is what one of the new unit tests checks for.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [couchdb] nickva merged pull request #4177: Remove the long deprecated bigcouch 0.4 change sequence support

[GitBox <gi...@apache.org>]

nickva merged PR #4177:
URL: https://github.com/apache/couchdb/pull/4177


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org