You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "michael-s-molina (via GitHub)" <gi...@apache.org> on 2023/04/06 13:56:55 UTC

[GitHub] [superset] michael-s-molina opened a new pull request, #23613: fix: Increases the options limit for Annotation Layers

michael-s-molina opened a new pull request, #23613:
URL: https://github.com/apache/superset/pull/23613

   ### SUMMARY
   Increases the options limit for Annotation Layers in Explore. Previously, the options were limited to 20 results which is a problem for organizations with many records. Following the same pattern used in filters, the limit was increased to a 1000 values. Although, 1000 values will probably be sufficient for most of organizations, the endgame solution would be to create a control using the `AsyncSelect` and replace the sync version. This change is not in the scope of this PR.
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   <img width="505" alt="Screenshot 2023-04-06 at 10 47 44" src="https://user-images.githubusercontent.com/70410625/230399609-9bf9c4d3-48e5-477f-b714-3ca26cdffbf8.png">
   
   ### TESTING INSTRUCTIONS
   Make sure the Annotation Layers select in Explore can show up to a 1000 values.
   
   ### ADDITIONAL INFORMATION
   - [ ] Has associated issue:
   - [ ] Required feature flags:
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] michael-s-molina merged pull request #23613: fix: Increases the options limit for Annotation Layers

Posted by "michael-s-molina (via GitHub)" <gi...@apache.org>.
michael-s-molina merged PR #23613:
URL: https://github.com/apache/superset/pull/23613


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] Vitor-Avila commented on pull request #23613: fix: Increases the options limit for Annotation Layers

Posted by "Vitor-Avila (via GitHub)" <gi...@apache.org>.
Vitor-Avila commented on PR #23613:
URL: https://github.com/apache/superset/pull/23613#issuecomment-1671496687

   ohh, I see -- thanks for sharing!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] michael-s-molina commented on pull request #23613: fix: Increases the options limit for Annotation Layers

Posted by "michael-s-molina (via GitHub)" <gi...@apache.org>.
michael-s-molina commented on PR #23613:
URL: https://github.com/apache/superset/pull/23613#issuecomment-1671302236

   > Do you know if this server side limit is configureable and could be changed?
   
   The only one I can think of is [FAB_API_MAX_PAGE_SIZE](https://flask-appbuilder.readthedocs.io/en/latest/config.html) which is 100 by default.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] Vitor-Avila commented on pull request #23613: fix: Increases the options limit for Annotation Layers

Posted by "Vitor-Avila (via GitHub)" <gi...@apache.org>.
Vitor-Avila commented on PR #23613:
URL: https://github.com/apache/superset/pull/23613#issuecomment-1671263966

   hey @michael-s-molina @rusackas I was testing this change, and on my end the amount of returned results is `100` (rather than `1000`). In my tests, regardless if I increase the page size in the request arguments, it seems that Superset has a max size defined in the server side. 
   
   Do you know if this server side limit is configureable and could be changed? It could be an additional modification needed on my end. Currently I see this server-side hard limit of `100` to most API endpoints (charts, annotation layers, dashboards, datasets, etc).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org