[GitHub] [apisix-ingress-controller] tokers commented on a change in pull request #660: fix: add initContainers to verify if apisix is ready

[GitBox <gi...@apache.org>]

tokers commented on a change in pull request #660:
URL: https://github.com/apache/apisix-ingress-controller/pull/660#discussion_r700971230



##########
File path: docs/en/latest/practices/the-hard-way.md
##########
@@ -750,6 +750,10 @@ spec:
             items:
               - key: config.yaml
                 path: config.yaml
+      initContainers:
+        - name: wait-apisix-admin
+          image: busybox:1.28
+          command: ['sh', '-c', "until nc -z apisix-service.apisix.svc.cluster.local 9080 ; do echo waiting for apisix-admin; sleep 2; done;"]

Review comment:
       Its port is `9180`.

##########
File path: test/e2e/scaffold/ingress.go
##########
@@ -214,6 +214,10 @@ spec:
         app: ingress-apisix-controller-deployment-e2e-test
     spec:
       terminationGracePeriodSeconds: 0
+      initContainers:
+      - name: wait-apisix-admin
+        image: localhost:5000/busybox:1.28
+        command: ['sh', '-c', "until nc -z apisix-service-e2e-test.%s.svc.cluster.local 9080 ; do echo waiting for apisix-admin; sleep 2; done;"]

Review comment:
       Ditto, admin port is `9180`.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org