[GitHub] [lucene] rmuir commented on a change in pull request #68: LUCENE-9910: maximize javac lint

[GitBox <gi...@apache.org>]

rmuir commented on a change in pull request #68:
URL: https://github.com/apache/lucene/pull/68#discussion_r608213508



##########
File path: gradle/java/javac.gradle
##########
@@ -33,27 +33,51 @@ allprojects {
       options.compilerArgs += [
         "-Xlint:-deprecation",
         "-Xlint:-serial",
+        "-Xlint:auxiliaryclass",
         "-Xlint:cast",
         "-Xlint:classfile",
         "-Xlint:dep-ann",
         "-Xlint:divzero",
         "-Xlint:empty",
+        "-Xlint:exports",
         "-Xlint:fallthrough",
         "-Xlint:finally",
+        "-Xlint:opens",
         "-Xlint:options",
+        "-Xlint:overloads",
         "-Xlint:overrides",
+        // TODO: some tests seem to have bad classpaths?
+        // this check seems to be a good sanity check for gradle?
+        // "-Xlint:path",

Review comment:
       I left this TODO because this check seems genuinely useful. But currently it provokes some failures that must be addressed:
   ```
   $ RUNTIME_JAVA_HOME=/home/rmuir/Downloads/jdk-17 ./gradlew compileJava compileTestJava
   
   > Task :lucene:classification:compileTestJava FAILED
   warning: [path] bad path element "/home/rmuir/workspace/lucene/lucene/classification/build/resources/main": no such file or directory
   error: warnings found and -Werror specified
   1 error
   1 warning
   
   > Task :lucene:benchmark:compileTestJava
   warning: [path] bad path element "/home/rmuir/workspace/lucene/lucene/benchmark/build/resources/main": no such file or directory
   error: warnings found and -Werror specified
   1 error
   1 warning
   
   > Task :lucene:benchmark:compileTestJava FAILED
   > Task :lucene:codecs:compileTestJava
   
   > Task :lucene:backward-codecs:compileTestJava
   Note: Some input files use or override a deprecated API.
   Note: Recompile with -Xlint:deprecation for details.
   
   FAILURE: Build completed with 2 failures.
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org