You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by "kennknowles (via GitHub)" <gi...@apache.org> on 2023/04/28 17:01:28 UTC

[GitHub] [beam] kennknowles commented on pull request #26470: [Roll Fwd PR] Rename _namespace to _get_display_data_namespace""

kennknowles commented on PR #26470:
URL: https://github.com/apache/beam/pull/26470#issuecomment-1527837844

   Well, to be fair, if the field is a private field then it isn't really a breaking change. Yes, it broke some users, but they were violating the convention. I have seen some good projects have the convention also that only documented members "count" as API surface.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org