Re: [PR] AIP-82: Add RedisMessageQueueProvider [airflow]

["Jasperora (via GitHub)" <gi...@apache.org>]

Jasperora commented on PR #53556:
URL: https://github.com/apache/airflow/pull/53556#issuecomment-3154395050

   Hi @jason810496, during the period of adding integration test, I found that a bug exists in my unit test.
   From [pytest importorskip doc](https://docs.pytest.org/en/stable/reference/reference.html#pytest-importorskip), the parameter should be module name instead of class name.
   I tried using class name (`airflow.providers.common.messaging.providers.base_provider.BaseMessageQueueProvider`) in redis, and the test would be skipped since the class cannot be imported.
   I noticed that same issue exists in [Apache Kafka](https://github.com/apache/airflow/blob/main/providers/apache/kafka/tests/unit/apache/kafka/queues/test_kafka.py#L23) and [Amazon SQS](https://github.com/apache/airflow/blob/main/providers/amazon/tests/unit/amazon/aws/queues/test_sqs.py#L23).
   
   I could address the issue if my understanding is correct. However, I would appreciate hearing your suggestions first. Thank you!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org