You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Benno Evers <be...@mesosphere.com> on 2019/01/11 22:46:08 UTC
Review Request 69726: Disabled
MasterAPITest.AgentUpdatesUponOfferGone on Windows.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69726/
-----------------------------------------------------------
Review request for mesos, Gastón Kleiman and Greg Mann.
Repository: mesos
Description
-------
This test was broken on Windows due to the following:
W0111 20:44:47.175993 16980 slave.cpp:8949] Persisting resource
provider manager state is not supported on Windows
Diffs
-----
src/tests/api_tests.cpp c597243e2e210e83a4ab7441fbcfa3198b43d849
Diff: https://reviews.apache.org/r/69726/diff/1/
Testing
-------
Thanks,
Benno Evers
Re: Review Request 69726: Fixed flakiness in
MasterAPITest.OperationUpdatesUponOfferGone.
Posted by Benno Evers <be...@mesosphere.com>.
> On Jan. 12, 2019, 8:50 p.m., Benjamin Bannier wrote:
> > src/tests/api_tests.cpp
> > Line 4830 (original), 4830 (patched)
> > <https://reviews.apache.org/r/69726/diff/1/?file=2119270#file2119270line4830>
> >
> > Could you explain what in particular is broken here (e.g., by linking a ticket)? Resource provider managers use in memory storage for their state which should be fine here (e.g., no agent restart). The message you are quoting in the commit message is just for user information.
> >
> > Right now it is hard to get a grasp for what needs to be done for this test to be enabled again.
Interestingly, this was actually on the wrong test! (`TaskUpdatesUponAgentGone` vs. `OperationUpdatesUponAgentGone`).
After some investigation it also turned out that the error is not even windows-specific, just for some reason far more likely to happen there (i.e. 2 out of 2 runs, as opposed to 0 out of ca. 20 on linux), so I reverted the disabling and included a proper fix in this review.
- Benno
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69726/#review211936
-----------------------------------------------------------
On Jan. 14, 2019, 4:35 p.m., Benno Evers wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69726/
> -----------------------------------------------------------
>
> (Updated Jan. 14, 2019, 4:35 p.m.)
>
>
> Review request for mesos, Gastón Kleiman and Greg Mann.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> It could happen that the first offer was sent before the allocator
> had been updated with the resources from the resource provider.
>
> To further increase reliability, stopped the clock during this test.
>
>
> Diffs
> -----
>
> src/tests/api_tests.cpp c597243e2e210e83a4ab7441fbcfa3198b43d849
>
>
> Diff: https://reviews.apache.org/r/69726/diff/2/
>
>
> Testing
> -------
>
> `./src/mesos-tests --gtest_filter="*OperationUpdates*" --gtest_repeat=50000 --gtest_throw_on_failure`
>
>
> Thanks,
>
> Benno Evers
>
>
Re: Review Request 69726: Disabled
MasterAPITest.AgentUpdatesUponOfferGone on Windows.
Posted by Benjamin Bannier <be...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69726/#review211936
-----------------------------------------------------------
src/tests/api_tests.cpp
Line 4830 (original), 4830 (patched)
<https://reviews.apache.org/r/69726/#comment297500>
Could you explain what in particular is broken here (e.g., by linking a ticket)? Resource provider managers use in memory storage for their state which should be fine here (e.g., no agent restart). The message you are quoting in the commit message is just for user information.
Right now it is hard to get a grasp for what needs to be done for this test to be enabled again.
- Benjamin Bannier
On Jan. 11, 2019, 11:46 p.m., Benno Evers wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69726/
> -----------------------------------------------------------
>
> (Updated Jan. 11, 2019, 11:46 p.m.)
>
>
> Review request for mesos, Gastón Kleiman and Greg Mann.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This test was broken on Windows due to the following:
>
> W0111 20:44:47.175993 16980 slave.cpp:8949] Persisting resource
> provider manager state is not supported on Windows
>
>
> Diffs
> -----
>
> src/tests/api_tests.cpp c597243e2e210e83a4ab7441fbcfa3198b43d849
>
>
> Diff: https://reviews.apache.org/r/69726/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Benno Evers
>
>
Re: Review Request 69726: Fixed flakiness in
MasterAPITest.OperationUpdatesUponOfferGone.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69726/#review211956
-----------------------------------------------------------
PASS: Mesos patch 69726 was successfully built and tested.
Reviews applied: `['69726']`
All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2772/mesos-review-69726
- Mesos Reviewbot Windows
On Jan. 14, 2019, 4:35 p.m., Benno Evers wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69726/
> -----------------------------------------------------------
>
> (Updated Jan. 14, 2019, 4:35 p.m.)
>
>
> Review request for mesos, Gastón Kleiman and Greg Mann.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> It could happen that the first offer was sent before the allocator
> had been updated with the resources from the resource provider.
>
> To further increase reliability, stopped the clock during this test.
>
>
> Diffs
> -----
>
> src/tests/api_tests.cpp c597243e2e210e83a4ab7441fbcfa3198b43d849
>
>
> Diff: https://reviews.apache.org/r/69726/diff/2/
>
>
> Testing
> -------
>
> `./src/mesos-tests --gtest_filter="*OperationUpdates*" --gtest_repeat=50000 --gtest_throw_on_failure`
>
>
> Thanks,
>
> Benno Evers
>
>
Re: Review Request 69726: Fixed flakiness in
MasterAPITest.OperationUpdatesUponOfferGone.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69726/#review212044
-----------------------------------------------------------
Patch looks great!
Reviews applied: [69726]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On Jan. 14, 2019, 4:35 p.m., Benno Evers wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69726/
> -----------------------------------------------------------
>
> (Updated Jan. 14, 2019, 4:35 p.m.)
>
>
> Review request for mesos, Gastón Kleiman and Greg Mann.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> It could happen that the first offer was sent before the allocator
> had been updated with the resources from the resource provider.
>
> To further increase reliability, stopped the clock during this test.
>
>
> Diffs
> -----
>
> src/tests/api_tests.cpp c597243e2e210e83a4ab7441fbcfa3198b43d849
>
>
> Diff: https://reviews.apache.org/r/69726/diff/2/
>
>
> Testing
> -------
>
> `./src/mesos-tests --gtest_filter="*OperationUpdates*" --gtest_repeat=50000 --gtest_throw_on_failure`
>
>
> Thanks,
>
> Benno Evers
>
>
Re: Review Request 69726: Fixed flakiness in
MasterAPITest.OperationUpdatesUponOfferGone.
Posted by Benno Evers <be...@mesosphere.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69726/
-----------------------------------------------------------
(Updated Jan. 14, 2019, 4:35 p.m.)
Review request for mesos, Gastón Kleiman and Greg Mann.
Changes
-------
Updated review to fix the flakiness instead of disabling the test.
Summary (updated)
-----------------
Fixed flakiness in MasterAPITest.OperationUpdatesUponOfferGone.
Repository: mesos
Description (updated)
-------
It could happen that the first offer was sent before the allocator
had been updated with the resources from the resource provider.
To further increase reliability, stopped the clock during this test.
Diffs (updated)
-----
src/tests/api_tests.cpp c597243e2e210e83a4ab7441fbcfa3198b43d849
Diff: https://reviews.apache.org/r/69726/diff/2/
Changes: https://reviews.apache.org/r/69726/diff/1-2/
Testing
-------
Thanks,
Benno Evers
Re: Review Request 69726: Disabled
MasterAPITest.AgentUpdatesUponOfferGone on Windows.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69726/#review211931
-----------------------------------------------------------
PASS: Mesos patch 69726 was successfully built and tested.
Reviews applied: `['69726']`
All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2768/mesos-review-69726
- Mesos Reviewbot Windows
On Jan. 11, 2019, 10:46 p.m., Benno Evers wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69726/
> -----------------------------------------------------------
>
> (Updated Jan. 11, 2019, 10:46 p.m.)
>
>
> Review request for mesos, Gastón Kleiman and Greg Mann.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This test was broken on Windows due to the following:
>
> W0111 20:44:47.175993 16980 slave.cpp:8949] Persisting resource
> provider manager state is not supported on Windows
>
>
> Diffs
> -----
>
> src/tests/api_tests.cpp c597243e2e210e83a4ab7441fbcfa3198b43d849
>
>
> Diff: https://reviews.apache.org/r/69726/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Benno Evers
>
>
Re: Review Request 69726: Disabled
MasterAPITest.AgentUpdatesUponOfferGone on Windows.
Posted by Gastón Kleiman <ga...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69726/#review211916
-----------------------------------------------------------
Ship it!
Ship It!
- Gastón Kleiman
On Jan. 11, 2019, 2:46 p.m., Benno Evers wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69726/
> -----------------------------------------------------------
>
> (Updated Jan. 11, 2019, 2:46 p.m.)
>
>
> Review request for mesos, Gastón Kleiman and Greg Mann.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This test was broken on Windows due to the following:
>
> W0111 20:44:47.175993 16980 slave.cpp:8949] Persisting resource
> provider manager state is not supported on Windows
>
>
> Diffs
> -----
>
> src/tests/api_tests.cpp c597243e2e210e83a4ab7441fbcfa3198b43d849
>
>
> Diff: https://reviews.apache.org/r/69726/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Benno Evers
>
>