You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/02/18 02:13:13 UTC

[GitHub] [spark] maropu commented on a change in pull request #31548: [SPARK-34127][SQL] Support table valued command

maropu commented on a change in pull request #31548:
URL: https://github.com/apache/spark/pull/31548#discussion_r578077671



##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/unresolved.scala
##########
@@ -136,6 +136,29 @@ case class UnresolvedTableValuedFunction(
   override lazy val resolved = false
 }
 
+/**
+ * A table-valued command, e.g.
+ * {{{
+ *   select tableName from command("show tables");

Review comment:
       We cannot add a new built-in function for this purpose instead? The implementation will be simpler than the current syntax-based approach, I think.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org