You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/06/22 06:31:51 UTC

[GitHub] [pulsar] Technoboy- opened a new pull request, #16167: [feature][CLI] Add query options to the get topics in Namespace.

Technoboy- opened a new pull request, #16167:
URL: https://github.com/apache/pulsar/pull/16167

   ### Motivation
   
   Since #2025 has added query param - `Mode`,  but the CLI is still not supported.
   
   #15410 has introduced to filter system topic. 
   
   So this patch is supported the above query params for Namespace#getTopics.
   
   ### Documentation
   
   - [x] `doc-not-needed` 
   (Please explain why)
     


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] codelipenghui merged pull request #16167: [feature][CLI] Add query options to the get topics in Namespace.

Posted by GitBox <gi...@apache.org>.
codelipenghui merged PR #16167:
URL: https://github.com/apache/pulsar/pull/16167


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] codelipenghui commented on a diff in pull request #16167: [feature][CLI] Add query options to the get topics in Namespace.

Posted by GitBox <gi...@apache.org>.
codelipenghui commented on code in PR #16167:
URL: https://github.com/apache/pulsar/pull/16167#discussion_r904510308


##########
pulsar-client-admin-api/src/main/java/org/apache/pulsar/client/admin/Namespaces.java:
##########
@@ -143,6 +143,7 @@ public interface Namespaces {
      * @throws PulsarAdminException
      *             Unexpected error
      */
+    @Deprecated

Review Comment:
   We don't need to deprecate the existing method? 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] Technoboy- commented on a diff in pull request #16167: [feature][CLI] Add query options to the get topics in Namespace.

Posted by GitBox <gi...@apache.org>.
Technoboy- commented on code in PR #16167:
URL: https://github.com/apache/pulsar/pull/16167#discussion_r905654736


##########
pulsar-client-admin-api/src/main/java/org/apache/pulsar/client/admin/Namespaces.java:
##########
@@ -143,6 +143,7 @@ public interface Namespaces {
      * @throws PulsarAdminException
      *             Unexpected error
      */
+    @Deprecated

Review Comment:
   ok, fixed.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org