You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@fineract.apache.org by "a7med3del1973 (via GitHub)" <gi...@apache.org> on 2025/06/01 21:03:30 UTC
[PR] FINERACT-2181: Refactor code quality [fineract]
a7med3del1973 opened a new pull request, #4720:
URL: https://github.com/apache/fineract/pull/4720
## Description
- Replace the type specification in this constructor call with the diamond operator ("<>").
- Remove the call `toString()`.
- Use `isEmpty()` to check whether the collection is empty or not.
- Remove `required`.
- Remove the parentheses around the `ctx` parameter.
Ignore if these details are present on the associated [Apache Fineract JIRA ticket](https://github.com/apache/fineract/pull/1284).
## Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
- [ ] Write the commit message as per https://github.com/apache/fineract/#pull-requests
- [ ] Acknowledge that we will not review PRs that are not passing the build _("green")_ - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
- [ ] Create/update unit or integration tests for verifying the changes made.
- [ ] Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.
- [ ] Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
- [ ] Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the developer mailing list for guidance, if required.)
FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] FINERACT-2181: Refactor code quality [fineract]
Posted by "adamsaghy (via GitHub)" <gi...@apache.org>.
adamsaghy commented on code in PR #4720:
URL: https://github.com/apache/fineract/pull/4720#discussion_r2120858939
##########
fineract-accounting/src/main/java/org/apache/fineract/accounting/journalentry/data/JournalEntryData.java:
##########
@@ -82,7 +82,7 @@ public class JournalEntryData {
private LocalDate submittedOnDate;
// import fields
- private transient Integer rowIndex;
Review Comment:
Why to remove the `transient` modifier? Do we need to serialize this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] FINERACT-2181: Refactor code quality [fineract]
Posted by "adamsaghy (via GitHub)" <gi...@apache.org>.
adamsaghy merged PR #4720:
URL: https://github.com/apache/fineract/pull/4720
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] FINERACT-2181: Refactor code quality [fineract]
Posted by "adamsaghy (via GitHub)" <gi...@apache.org>.
adamsaghy commented on code in PR #4720:
URL: https://github.com/apache/fineract/pull/4720#discussion_r2121189648
##########
fineract-accounting/src/main/java/org/apache/fineract/accounting/journalentry/data/JournalEntryData.java:
##########
@@ -82,7 +82,7 @@ public class JournalEntryData {
private LocalDate submittedOnDate;
// import fields
- private transient Integer rowIndex;
Review Comment:
It would make sense this class to be Serializable...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] FINERACT-2181: Refactor code quality [fineract]
Posted by "a7med3del1973 (via GitHub)" <gi...@apache.org>.
a7med3del1973 commented on code in PR #4720:
URL: https://github.com/apache/fineract/pull/4720#discussion_r2121331602
##########
fineract-accounting/src/main/java/org/apache/fineract/accounting/journalentry/data/JournalEntryData.java:
##########
@@ -82,7 +82,7 @@ public class JournalEntryData {
private LocalDate submittedOnDate;
// import fields
- private transient Integer rowIndex;
Review Comment:
Ok, Got it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] FINERACT-2181: Refactor code quality [fineract]
Posted by "a7med3del1973 (via GitHub)" <gi...@apache.org>.
a7med3del1973 commented on code in PR #4720:
URL: https://github.com/apache/fineract/pull/4720#discussion_r2121136286
##########
fineract-accounting/src/main/java/org/apache/fineract/accounting/journalentry/data/JournalEntryData.java:
##########
@@ -82,7 +82,7 @@ public class JournalEntryData {
private LocalDate submittedOnDate;
// import fields
- private transient Integer rowIndex;
Review Comment:
This rule raises an issue when a field is marked as `transient` even though the containing class doesn't implement `Serializable`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org