[GitHub] pritidesai commented on issue #609: Annotations on Actions only work if "web export" exists

[GitBox <gi...@apache.org>]

pritidesai commented on issue #609: Annotations on Actions only work if "web export" exists
URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/609#issuecomment-339479376
 
 
   I am running some sample tests to determine `wskdeploy` behavior for annotations on actions and found these facts:
   
   - If an action in manifest file has `annotations` section, the whole section is ignored and not added to action creation statement.
   
   **manifest.yaml**
   
   ```
   packages:
       packagebinding:
           actions:
               helloworld:
                   function: actions/helloworld.js
                   runtime: nodejs:6
                   annotations:
                       action_annotation_1: hello
                       action_annotation_2: this is an annotation
   ```
   
   - If an action in deployment file has `annotations`, the entire list of annotations are added to action creation.
   
   **deployment.yaml**
   
   ```
   application:
     name: BindingTest
     packages:
       packagebinding:
         actions:
           helloworld:
             annotations:
               tag: hello
               aaa: this is an annotation
   ```
   
   - When an action in manifest file has `annotations` section and an action in deployment file has `annotations` section, only `annotations` from deployment file is added to action creation. @mrutkows how should `wskdeploy` behave in this use case? combine action annotations from both manifest and deployment?
   
   (TODO) what happens when annotations and web export both are specified in manifest file?
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services