[PR] Use MySQL 8.0.40 for native JDBC and Proxy tests [shardingsphere]

["terrymanu (via GitHub)" <gi...@apache.org>]

terrymanu opened a new pull request, #40112:
URL: https://github.com/apache/shardingsphere/pull/40112

   (no comment)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Use MySQL 8.0.40 for native JDBC and Proxy tests [shardingsphere]

["terrymanu (via GitHub)" <gi...@apache.org>]

terrymanu merged PR #40112:
URL: https://github.com/apache/shardingsphere/pull/40112


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Use MySQL 8.0.40 for native JDBC and Proxy tests [shardingsphere]

["terrymanu (via GitHub)" <gi...@apache.org>]

terrymanu commented on PR #40112:
URL: https://github.com/apache/shardingsphere/pull/40112#issuecomment-6077802155

   ### Result
   
   **Review Result: Mergeable**
   
   The two Native MySQL tests now use `8.0.40`. The changes stay within the authorized scope, and no code issues requiring further changes were found.
   
   ### Evidence
   
   - Both tests retain `GenericContainer`, existing ports, environment variables, assertions, and lifecycle handling. Only the image tags and the formatting of the initialization expressions changed.
   - The freshly built Native binary executed both MySQL test cases successfully, with neither skipped.
   - The initial full Native run had 22 successful tests, 1 Doris failure, and 1 existing skip; Maven exited with code 1. Doris could not find allocatable disks during database initialization. A focused retry using the same Native binary passed 1/1 tests with exit code 0. The initial full run is not reported as passing.
   - Exact-file Spotless and Checkstyle checks passed with exit code 0, with coverage of both target files confirmed. Manual standards review passed. The independent defensive-code audit found 0 added or strengthened constructs. RAT is not applicable.
   
   ### Coverage
   
   - Standalone local candidate, based on `276f551fcee35f5702038bca0978cb437f195e0e`, containing only working-tree changes, +2/-6:
     - `test/native/src/test/java/org/apache/shardingsphere/test/natived/jdbc/databases/MySQLTest.java:58`
     - `test/native/src/test/java/org/apache/shardingsphere/test/natived/proxy/databases/MySQLTest.java:49`
   - The user explicitly authorized changing the MySQL version used by the existing tests. No production functionality, public contracts, or downstream commitments were added.
   - Both JDBC and Proxy behavior clusters were reviewed through the root-cause, impact, and runtime lenses. Final convergence found no new issues. The scope inventory and review ledger passed validation, with no unresolved evidence gaps within the task scope.
   - This result covers code correctness only. Local verification is complete; remote CI was not reviewed.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org