Rat check reporting error in travis-ci for geode-native

[Alberto Gomez <al...@est.tech>]

Hi,

I sent a PR for the geode-native repo and the travis-ci is reporting a 
Rat error on the following file:

./packer/windows/install-doxygen.ps1

The reason is that the copyright header is not included in it. I could 
add it in my PR but I guess it would be more convenient if this is fixed 
on a independent commit by someone working on it.

Could anyone take care of it?

Thanks,

- Alberto G.

Re: Rat check reporting error in travis-ci for geode-native

[Alberto Gomez <al...@est.tech>]

I created the following PR to fix the Rat error.

https://github.com/apache/geode-native/pull/512

Could someone review it and merge it if correct?

Thanks,

-Alberto G.

On 21/8/19 23:59, Dan Smith wrote:
> Hi Helena,
>
> I think the problem is that rat is currently broken on geode-native
> develop.
>
> -Dan
>
> On Wed, Aug 21, 2019 at 2:55 PM Helena Bales <hb...@pivotal.io> wrote:
>
>> Hi Alberto,
>>
>> If you have added a file as part of your PR, please add the header as a
>> commit to your working branch and add that as part of the same PR. Your
>> branch should be able to pass a build, spotlessCheck, and unit tests as a
>> prerequisite for making a pull request.
>>
>> Please follow up here if you have more questions.
>> Thank you,
>> Helena Bales
>>
>> On Tue, Aug 20, 2019 at 7:40 AM Alberto Gomez <al...@est.tech>
>> wrote:
>>
>>> Hi,
>>>
>>> I sent a PR for the geode-native repo and the travis-ci is reporting a
>>> Rat error on the following file:
>>>
>>> ./packer/windows/install-doxygen.ps1
>>>
>>> The reason is that the copyright header is not included in it. I could
>>> add it in my PR but I guess it would be more convenient if this is fixed
>>> on a independent commit by someone working on it.
>>>
>>> Could anyone take care of it?
>>>
>>> Thanks,
>>>
>>> - Alberto G.
>>>
>>>
>>>

Re: Rat check reporting error in travis-ci for geode-native

[Dan Smith <ds...@pivotal.io>]

Hi Helena,

I think the problem is that rat is currently broken on geode-native
develop.

-Dan

On Wed, Aug 21, 2019 at 2:55 PM Helena Bales <hb...@pivotal.io> wrote:

> Hi Alberto,
>
> If you have added a file as part of your PR, please add the header as a
> commit to your working branch and add that as part of the same PR. Your
> branch should be able to pass a build, spotlessCheck, and unit tests as a
> prerequisite for making a pull request.
>
> Please follow up here if you have more questions.
> Thank you,
> Helena Bales
>
> On Tue, Aug 20, 2019 at 7:40 AM Alberto Gomez <al...@est.tech>
> wrote:
>
> > Hi,
> >
> > I sent a PR for the geode-native repo and the travis-ci is reporting a
> > Rat error on the following file:
> >
> > ./packer/windows/install-doxygen.ps1
> >
> > The reason is that the copyright header is not included in it. I could
> > add it in my PR but I guess it would be more convenient if this is fixed
> > on a independent commit by someone working on it.
> >
> > Could anyone take care of it?
> >
> > Thanks,
> >
> > - Alberto G.
> >
> >
> >
>

Re: Rat check reporting error in travis-ci for geode-native

[Helena Bales <hb...@pivotal.io>]

Hi Alberto,

If you have added a file as part of your PR, please add the header as a
commit to your working branch and add that as part of the same PR. Your
branch should be able to pass a build, spotlessCheck, and unit tests as a
prerequisite for making a pull request.

Please follow up here if you have more questions.
Thank you,
Helena Bales

On Tue, Aug 20, 2019 at 7:40 AM Alberto Gomez <al...@est.tech>
wrote:

> Hi,
>
> I sent a PR for the geode-native repo and the travis-ci is reporting a
> Rat error on the following file:
>
> ./packer/windows/install-doxygen.ps1
>
> The reason is that the copyright header is not included in it. I could
> add it in my PR but I guess it would be more convenient if this is fixed
> on a independent commit by someone working on it.
>
> Could anyone take care of it?
>
> Thanks,
>
> - Alberto G.
>
>
>