[GitHub] [tomcat] markt-asf commented on pull request #383: Fix so ResponseUtil:addVaryFieldName() stop adding duplicate values

[GitBox <gi...@apache.org>]

markt-asf commented on pull request #383:
URL: https://github.com/apache/tomcat/pull/383#issuecomment-737428376


   Thanks for the pull request. I've applied a slightly different version as:
   
   - we patch 10.0.x first and then back-port
   - I agree it is better if the tests don't use Set
   - On reflection, I think it is better not to modify the existing header order and add any new value to the end
   
   That last point isn't strictly necessary but it strikes me as what users will expect.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org