[GitHub] [accumulo] dlmarion commented on a diff in pull request #2921: Updated TableOperations javadoc to remove compaction strategy ref

[GitBox <gi...@apache.org>]

dlmarion commented on code in PR #2921:
URL: https://github.com/apache/accumulo/pull/2921#discussion_r967153098


##########
core/src/main/java/org/apache/accumulo/core/client/admin/TableOperations.java:
##########
@@ -427,13 +427,8 @@ void compact(String tableName, Text start, Text end, List<IteratorSetting> itera
       throws AccumuloSecurityException, TableNotFoundException, AccumuloException;
 
   /**
-   * Starts a full major compaction of the tablets in the range (start, end]. If the config does not
-   * specify a compaction strategy, then all files in a tablet are compacted. The compaction is
-   * performed even for tablets that have only one file.
-   *
-   * <p>
-   * Only one compact call at a time can pass iterators and/or a compaction strategy. If two threads
-   * call compaction with iterators and/or a compaction strategy, then one will fail.
+   * Starts a full major compaction of the tablets in the range (start, end]. Files to be compacted
+   * will be selected by the compaction service configured on the table.

Review Comment:
   Honestly, you're the better person to make this fix. Wasn't sure how much you were working this lately.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org