You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2021/01/28 18:10:10 UTC

[GitHub] [nifi-minifi-cpp] lordgamez commented on a change in pull request #982: MINIFICPP-1465 Add AWS to docker minimal image and 16.04 all tests

lordgamez commented on a change in pull request #982:
URL: https://github.com/apache/nifi-minifi-cpp/pull/982#discussion_r566304366



##########
File path: docker/Dockerfile
##########
@@ -127,7 +127,7 @@ RUN cd ${MINIFI_BASE_DIR} \
     -DDISABLE_CURL=${DISABLE_CURL} -DDISABLE_JEMALLOC=${DISABLE_JEMALLOC} -DDISABLE_CIVET=${DISABLE_CIVET} \
     -DDISABLE_EXPRESSION_LANGUAGE=${DISABLE_EXPRESSION_LANGUAGE} -DDISABLE_ROCKSDB=${DISABLE_ROCKSDB} \
     -DDISABLE_LIBARCHIVE=${DISABLE_LIBARCHIVE} -DDISABLE_LZMA=${DISABLE_LZMA} -DDISABLE_BZIP2=${DISABLE_BZIP2} \
-    -DDISABLE_SCRIPTING=${DISABLE_SCRIPTING} -DDISABLE_CONTROLLER=${DISABLE_CONTROLLER} .. \

Review comment:
       The problem with `RelWithDebInfo` was that it resulted in way too big docker images, due to the large minifi and minificontroller libraries when debuginfo was included. With Release the final image is 232MB with AWS and Kafka included, but with debuginfo the image size becomes more thatn 600MBs.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org