You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by "assignUser (via GitHub)" <gi...@apache.org> on 2023/02/09 15:59:31 UTC

[GitHub] [arrow] assignUser commented on a diff in pull request #34100: GH-34094: [C++] Increase Boost minimum version for clang >= 16

assignUser commented on code in PR #34100:
URL: https://github.com/apache/arrow/pull/34100#discussion_r1101687238


##########
cpp/cmake_modules/ThirdpartyToolchain.cmake:
##########
@@ -1057,7 +1057,11 @@ macro(build_boost)
   set(BOOST_VENDORED TRUE)
 endmacro()
 
-if(ARROW_BUILD_TESTS)
+if(CMAKE_CXX_COMPILER_ID STREQUAL "Clang" AND CMAKE_CXX_COMPILER_VERSION
+                                              VERSION_GREATER_EQUAL 16)
+  # GH-34094 we require newer Boost versions for Clang 16 or newer

Review Comment:
   AH yes that's a good clarification, thanks



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org