You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/07/02 19:38:57 UTC
[GitHub] [superset] betodealmeida opened a new pull request #15534: fix: show all DBs in available endpoint
betodealmeida opened a new pull request #15534:
URL: https://github.com/apache/superset/pull/15534
### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
Some DBs were not showing up in the `/available/` endpoint.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
After:
```json
{
"databases": [
{
"available_drivers": [
"psycopg2"
],
"default_driver": "psycopg2",
"engine": "postgresql",
"name": "PostgreSQL",
"parameters": {
"properties": {
"database": {
"description": "Database name",
"type": "string"
},
"encryption": {
"description": "Use an encrypted connection to the database",
"type": "boolean"
},
"host": {
"description": "Hostname or IP address",
"type": "string"
},
"password": {
"description": "Password",
"nullable": true,
"type": "string"
},
"port": {
"description": "Database port",
"format": "int32",
"maximum": 65536,
"minimum": 0,
"type": "integer"
},
"query": {
"additionalProperties": {},
"description": "Additional parameters",
"type": "object"
},
"username": {
"description": "Username",
"nullable": true,
"type": "string"
}
},
"required": [
"database",
"host",
"port",
"username"
],
"type": "object"
},
"preferred": true,
"sqlalchemy_uri_placeholder": "postgresql://user:password@host:port/dbname[?key=value&key=value...]"
},
{
"available_drivers": [],
"engine": "",
"name": "PostgreSQL",
"preferred": true
},
{
"available_drivers": [
"rest"
],
"engine": "presto",
"name": "Presto",
"preferred": true
},
{
"available_drivers": [],
"engine": "awsathena",
"name": "Amazon Athena",
"preferred": false
},
{
"available_drivers": [],
"default_driver": "psycopg2",
"engine": "redshift",
"name": "Amazon Redshift",
"preferred": false
},
{
"available_drivers": [],
"default_driver": "sadrill",
"engine": "drill",
"name": "Apache Drill",
"preferred": false
},
{
"available_drivers": [
"rest"
],
"engine": "druid",
"name": "Apache Druid",
"preferred": false
},
{
"available_drivers": [
"thrift"
],
"engine": "hive",
"name": "Apache Hive",
"preferred": false
},
{
"available_drivers": [],
"engine": "impala",
"name": "Apache Impala",
"preferred": false
},
{
"available_drivers": [],
"engine": "kylin",
"name": "Apache Kylin",
"preferred": false
},
{
"available_drivers": [],
"engine": "pinot",
"name": "Apache Pinot",
"preferred": false
},
{
"available_drivers": [],
"engine": "solr",
"name": "Apache Solr",
"preferred": false
},
{
"available_drivers": [
"thrift"
],
"engine": "hive",
"name": "Apache Spark SQL",
"preferred": false
},
{
"available_drivers": [],
"engine": "ascend",
"name": "Ascend",
"preferred": false
},
{
"available_drivers": [
"pymssql",
"pyodbc",
"turbodbc"
],
"default_driver": "pyodbc",
"engine": "mssql",
"name": "Azure Synapse",
"preferred": false
},
{
"available_drivers": [],
"engine": "clickhouse",
"name": "ClickHouse",
"preferred": false
},
{
"available_drivers": [],
"default_driver": "",
"engine": "cockroachdb",
"name": "CockroachDB",
"preferred": false
},
{
"available_drivers": [],
"engine": "crate",
"name": "CrateDB",
"preferred": false
},
{
"available_drivers": [
"pyhive",
"pyodbc"
],
"engine": "databricks",
"name": "Databricks Hive",
"preferred": false
},
{
"available_drivers": [],
"engine": "dremio",
"name": "Dremio",
"preferred": false
},
{
"available_drivers": [],
"engine": "odelasticsearch",
"name": "ElasticSearch (OpenDistro SQL)",
"preferred": false
},
{
"available_drivers": [],
"engine": "elasticsearch",
"name": "ElasticSearch (SQL API)",
"preferred": false
},
{
"available_drivers": [],
"engine": "exa",
"name": "Exasol",
"preferred": false
},
{
"available_drivers": [],
"engine": "firebird",
"name": "Firebird",
"preferred": false
},
{
"available_drivers": [
"bigquery"
],
"default_driver": "bigquery",
"engine": "bigquery",
"name": "Google BigQuery",
"parameters": {
"properties": {
"credentials_info": {
"description": "Contents of BigQuery JSON credentials.",
"type": "string",
"x-encrypted-extra": true
},
"query": {
"type": "object"
}
},
"type": "object"
},
"preferred": false,
"sqlalchemy_uri_placeholder": "bigquery://{project_id}"
},
{
"available_drivers": [
"apsw"
],
"engine": "gsheets",
"name": "Google Sheets",
"preferred": false
},
{
"available_drivers": [],
"engine": "db2",
"name": "IBM Db2",
"preferred": false
},
{
"available_drivers": [],
"default_driver": "nzpy",
"engine": "netezza",
"name": "IBM Netezza Performance Server",
"preferred": false
},
{
"available_drivers": [
"pymssql",
"pyodbc",
"turbodbc"
],
"engine": "mssql",
"name": "Microsoft SQL Server",
"preferred": false
},
{
"available_drivers": [
"mysqlconnector",
"mysqldb",
"pyodbc"
],
"default_driver": "mysqldb",
"engine": "mysql",
"name": "MySQL",
"parameters": {
"properties": {
"database": {
"description": "Database name",
"type": "string"
},
"encryption": {
"description": "Use an encrypted connection to the database",
"type": "boolean"
},
"host": {
"description": "Hostname or IP address",
"type": "string"
},
"password": {
"description": "Password",
"nullable": true,
"type": "string"
},
"port": {
"description": "Database port",
"format": "int32",
"maximum": 65536,
"minimum": 0,
"type": "integer"
},
"query": {
"additionalProperties": {},
"description": "Additional parameters",
"type": "object"
},
"username": {
"description": "Username",
"nullable": true,
"type": "string"
}
},
"required": [
"database",
"host",
"port",
"username"
],
"type": "object"
},
"preferred": false,
"sqlalchemy_uri_placeholder": "mysql://user:password@host:port/dbname[?key=value&key=value...]"
},
{
"available_drivers": [],
"engine": "oracle",
"name": "Oracle",
"preferred": false
},
{
"available_drivers": [],
"engine": "hana",
"name": "SAP HANA",
"preferred": false
},
{
"available_drivers": [
"pysqlite"
],
"engine": "sqlite",
"name": "SQLite",
"preferred": false
},
{
"available_drivers": [],
"engine": "snowflake",
"name": "Snowflake",
"preferred": false
},
{
"available_drivers": [],
"engine": "teradata",
"name": "Teradata",
"preferred": false
},
{
"available_drivers": [],
"engine": "trino",
"name": "Trino",
"preferred": false
},
{
"available_drivers": [
"vertica_python"
],
"engine": "vertica",
"name": "Vertica",
"preferred": false
}
]
}
```
### TESTING INSTRUCTIONS
<!--- Required! What steps can be taken to manually verify the changes? -->
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #15534: fix: show all DBs in available endpoint
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #15534:
URL: https://github.com/apache/superset/pull/15534#issuecomment-873226544
# [Codecov](https://codecov.io/gh/apache/superset/pull/15534?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#15534](https://codecov.io/gh/apache/superset/pull/15534?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a1a81d1) into [master](https://codecov.io/gh/apache/superset/commit/e5ab9a40914dfada7e76f74e9cf7c6393df8d933?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (e5ab9a4) will **decrease** coverage by `0.24%`.
> The diff coverage is `71.05%`.
> :exclamation: Current head a1a81d1 differs from pull request most recent head 8ff872e. Consider uploading reports for the commit 8ff872e to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/15534?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #15534 +/- ##
==========================================
- Coverage 76.97% 76.72% -0.25%
==========================================
Files 976 976
Lines 51260 51283 +23
Branches 6900 6901 +1
==========================================
- Hits 39456 39349 -107
- Misses 11585 11715 +130
Partials 219 219
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `?` | |
| mysql | `81.60% <57.69%> (-0.02%)` | :arrow_down: |
| postgres | `81.62% <57.69%> (-0.02%)` | :arrow_down: |
| presto | `?` | |
| python | `81.71% <57.69%> (-0.47%)` | :arrow_down: |
| sqlite | `81.24% <57.69%> (-0.02%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/15534?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [.../database/DatabaseModal/DatabaseConnectionForm.tsx](https://codecov.io/gh/apache/superset/pull/15534/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9kYXRhYmFzZS9EYXRhYmFzZU1vZGFsL0RhdGFiYXNlQ29ubmVjdGlvbkZvcm0udHN4) | `63.09% <ø> (ø)` | |
| [...s/CRUD/data/database/DatabaseModal/ModalHeader.tsx](https://codecov.io/gh/apache/superset/pull/15534/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9kYXRhYmFzZS9EYXRhYmFzZU1vZGFsL01vZGFsSGVhZGVyLnRzeA==) | `91.66% <ø> (ø)` | |
| [superset/db\_engine\_specs/\_\_init\_\_.py](https://codecov.io/gh/apache/superset/pull/15534/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL19faW5pdF9fLnB5) | `50.00% <26.66%> (-4.24%)` | :arrow_down: |
| [...end/src/components/Form/LabeledErrorBoundInput.tsx](https://codecov.io/gh/apache/superset/pull/15534/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRm9ybS9MYWJlbGVkRXJyb3JCb3VuZElucHV0LnRzeA==) | `100.00% <100.00%> (ø)` | |
| [...rset-frontend/src/components/InfoTooltip/index.tsx](https://codecov.io/gh/apache/superset/pull/15534/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvSW5mb1Rvb2x0aXAvaW5kZXgudHN4) | `100.00% <100.00%> (ø)` | |
| [...c/views/CRUD/data/database/DatabaseModal/index.tsx](https://codecov.io/gh/apache/superset/pull/15534/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9kYXRhYmFzZS9EYXRhYmFzZU1vZGFsL2luZGV4LnRzeA==) | `47.86% <100.00%> (ø)` | |
| [...c/views/CRUD/data/database/DatabaseModal/styles.ts](https://codecov.io/gh/apache/superset/pull/15534/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9kYXRhYmFzZS9EYXRhYmFzZU1vZGFsL3N0eWxlcy50cw==) | `82.72% <100.00%> (-3.39%)` | :arrow_down: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/superset/pull/15534/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `88.24% <100.00%> (-1.63%)` | :arrow_down: |
| [superset/db\_engine\_specs/drill.py](https://codecov.io/gh/apache/superset/pull/15534/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2RyaWxsLnB5) | `83.33% <100.00%> (+0.57%)` | :arrow_up: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/superset/pull/15534/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `69.44% <100.00%> (-16.96%)` | :arrow_down: |
| ... and [10 more](https://codecov.io/gh/apache/superset/pull/15534/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/15534?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/15534?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [e5ab9a4...8ff872e](https://codecov.io/gh/apache/superset/pull/15534?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] betodealmeida merged pull request #15534: fix: show all DBs in available endpoint
Posted by GitBox <gi...@apache.org>.
betodealmeida merged pull request #15534:
URL: https://github.com/apache/superset/pull/15534
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] commented on pull request #15534: fix: show all DBs in available endpoint
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on pull request #15534:
URL: https://github.com/apache/superset/pull/15534#issuecomment-873226544
# [Codecov](https://codecov.io/gh/apache/superset/pull/15534?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#15534](https://codecov.io/gh/apache/superset/pull/15534?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a1a81d1) into [master](https://codecov.io/gh/apache/superset/commit/e5ab9a40914dfada7e76f74e9cf7c6393df8d933?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (e5ab9a4) will **decrease** coverage by `0.26%`.
> The diff coverage is `71.05%`.
> :exclamation: Current head a1a81d1 differs from pull request most recent head 8ff872e. Consider uploading reports for the commit 8ff872e to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/15534?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #15534 +/- ##
==========================================
- Coverage 76.97% 76.70% -0.27%
==========================================
Files 976 976
Lines 51260 51283 +23
Branches 6900 6901 +1
==========================================
- Hits 39456 39337 -119
- Misses 11585 11727 +142
Partials 219 219
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `?` | |
| mysql | `?` | |
| postgres | `81.62% <57.69%> (-0.02%)` | :arrow_down: |
| presto | `?` | |
| python | `81.66% <57.69%> (-0.51%)` | :arrow_down: |
| sqlite | `81.24% <57.69%> (-0.02%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/15534?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [.../database/DatabaseModal/DatabaseConnectionForm.tsx](https://codecov.io/gh/apache/superset/pull/15534/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9kYXRhYmFzZS9EYXRhYmFzZU1vZGFsL0RhdGFiYXNlQ29ubmVjdGlvbkZvcm0udHN4) | `63.09% <ø> (ø)` | |
| [...s/CRUD/data/database/DatabaseModal/ModalHeader.tsx](https://codecov.io/gh/apache/superset/pull/15534/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9kYXRhYmFzZS9EYXRhYmFzZU1vZGFsL01vZGFsSGVhZGVyLnRzeA==) | `91.66% <ø> (ø)` | |
| [superset/db\_engine\_specs/\_\_init\_\_.py](https://codecov.io/gh/apache/superset/pull/15534/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL19faW5pdF9fLnB5) | `50.00% <26.66%> (-4.24%)` | :arrow_down: |
| [...end/src/components/Form/LabeledErrorBoundInput.tsx](https://codecov.io/gh/apache/superset/pull/15534/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRm9ybS9MYWJlbGVkRXJyb3JCb3VuZElucHV0LnRzeA==) | `100.00% <100.00%> (ø)` | |
| [...rset-frontend/src/components/InfoTooltip/index.tsx](https://codecov.io/gh/apache/superset/pull/15534/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvSW5mb1Rvb2x0aXAvaW5kZXgudHN4) | `100.00% <100.00%> (ø)` | |
| [...c/views/CRUD/data/database/DatabaseModal/index.tsx](https://codecov.io/gh/apache/superset/pull/15534/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9kYXRhYmFzZS9EYXRhYmFzZU1vZGFsL2luZGV4LnRzeA==) | `47.86% <100.00%> (ø)` | |
| [...c/views/CRUD/data/database/DatabaseModal/styles.ts](https://codecov.io/gh/apache/superset/pull/15534/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9kYXRhYmFzZS9EYXRhYmFzZU1vZGFsL3N0eWxlcy50cw==) | `82.72% <100.00%> (-3.39%)` | :arrow_down: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/superset/pull/15534/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `88.24% <100.00%> (-1.63%)` | :arrow_down: |
| [superset/db\_engine\_specs/drill.py](https://codecov.io/gh/apache/superset/pull/15534/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2RyaWxsLnB5) | `83.33% <100.00%> (+0.57%)` | :arrow_up: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/superset/pull/15534/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `69.44% <100.00%> (-16.96%)` | :arrow_down: |
| ... and [12 more](https://codecov.io/gh/apache/superset/pull/15534/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/15534?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/15534?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [e5ab9a4...8ff872e](https://codecov.io/gh/apache/superset/pull/15534?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org