You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2021/02/11 14:32:43 UTC

[GitHub] [kafka] chia7712 commented on a change in pull request #10099: MINOR: Updated the package name to correct one.

chia7712 commented on a change in pull request #10099:
URL: https://github.com/apache/kafka/pull/10099#discussion_r574547061



##########
File path: core/src/test/scala/integration/kafka/server/IntegrationTestUtils.scala
##########
@@ -15,7 +15,7 @@
  * limitations under the License.
  */
 
-package integration.kafka.server
+package kafka.server

Review comment:
       I feel this package name is intentional. @mumrah WDYY?

##########
File path: checkstyle/import-control-core.xml
##########
@@ -65,7 +65,6 @@
     <allow pkg="kafka.api"/>
     <allow pkg="kafka.server"/>
     <allow pkg="org.apache.kafka.clients.admin"/>
-    <allow pkg="integration.kafka.server" class="IntegrationTestHelper"/>

Review comment:
       It seems the class `IntegrationTestHelper` was moved due to review comment (#9986)
   
   this should be included by separate PR and the `core/src/test/java/kafka/test/junit/README.md` need to be updated as well.
   
   
   @mumrah FYI




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org