You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/11/21 15:56:11 UTC

[GitHub] [shardingsphere] RaigorJiang opened a new issue, #22321: Can we unify the use of underscore and minus in YAML?

RaigorJiang opened a new issue, #22321:
URL: https://github.com/apache/shardingsphere/issues/22321

   Hi community,
   
   In YAML configuration, we can use underscore (`_`) or minus (`-`), but it is very strange to mix them irregularly in a same file, as shown in the following figure:
   
   <img width="610" alt="image" src="https://user-images.githubusercontent.com/5668787/203093931-82f366fe-33ad-490f-a0ab-0f97c00e0211.png">
   
   The above picture is from the sharding configuration document, and there are similar cases in examples, underscore (_) or minus (-) are used.
   
   While both symbols are legal, I think we should recommend one usage in our projects, maybe like table names, using underscores is just fine.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] RaigorJiang closed issue #22321: Can we unify the use of underscore and minus in YAML?

Posted by GitBox <gi...@apache.org>.
RaigorJiang closed issue #22321: Can we unify the use of underscore and minus in YAML?
URL: https://github.com/apache/shardingsphere/issues/22321


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] Qianyi951015 commented on issue #22321: Can we unify the use of underscore and minus in YAML?

Posted by GitBox <gi...@apache.org>.
Qianyi951015 commented on issue #22321:
URL: https://github.com/apache/shardingsphere/issues/22321#issuecomment-1331995536

   Please assign to me


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] RaigorJiang commented on issue #22321: Can we unify the use of underscore and minus in YAML?

Posted by GitBox <gi...@apache.org>.
RaigorJiang commented on issue #22321:
URL: https://github.com/apache/shardingsphere/issues/22321#issuecomment-1328070455

   After discussing with @terrymanu , we believe that the YAML configuration style in the project should be unified for the following reasons:
   - Avoid user confusion and reduce the cost of understanding
   - Facilitates interaction with DistSQL, since in DistSQL only underscore is allowed in identifier
   
   Therefore, we plan to update all YAML file separators in the example and documentation to underscore.
   Anyone wanna try it?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org