[GitHub] [incubator-pekko-http] jrudolph commented on a diff in pull request #67: include hpack details in license

["jrudolph (via GitHub)" <gi...@apache.org>]

jrudolph commented on code in PR #67:
URL: https://github.com/apache/incubator-pekko-http/pull/67#discussion_r1109530054


##########
project/AddMetaInfLicenseFiles.scala:
##########
@@ -17,9 +17,18 @@ import org.mdedetrich.apache.sonatype.SonatypeApachePlugin.autoImport._
  */
 object AddMetaInfLicenseFiles extends AutoPlugin {
 
+  private lazy val baseDir = LocalRootProject / baseDirectory
+
   override lazy val projectSettings = Seq(
+    apacheSonatypeLicenseFile := baseDir.value / "legal" / "StandardLicense.txt",
     apacheSonatypeDisclaimerFile := Some((LocalRootProject / baseDirectory).value / "DISCLAIMER"))
 
+  /**
+   * Settings specific for Pekko http-core subproject which require a different license file.
+   */
+  lazy val httpCoreSettings = Seq(
+    apacheSonatypeLicenseFile := baseDir.value / "LICENSE")

Review Comment:
   Does that work to override the `projectSettings`? It's somewhat brittle to define the same setting twice for a project...



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org