[GitHub] [iotdb] HTHou commented on pull request #2608: [To NewTsFileV2] Change the way of checking page in Upgrade Tool

[GitBox <gi...@apache.org>]

HTHou commented on pull request #2608:
URL: https://github.com/apache/iotdb/pull/2608#issuecomment-771281199


   > hi, HTHou, Do we need to process abnormal data during an online upgrade? Do we directly filter abnormal data or interrupt the upgrade?
   
   Hi wangchao, normally if the tsfile isn't sealed, there won't be a tsfile resource with it. And the IoTDB will tell users to run `flush` before upgrading. 
   
   Or if the tsfile is sealed and there is a resource file with it, but there are some bytes errors in TsFile. It may have different scenarios.
   
   1. the error is in Magic String or version number
   2. the error is in Metadata part
   3. the error is in data part
   
   For 1 and 3, the upgrade tool will throw the exception, keep this file and continue to upgrade the next file.
   For 2, the upgrade tool will upgrade the file normally, since we don't need to read the old metadata for upgrading.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org